Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2021.2] Added multiedit to UniversalRenderPipelineAsset #5664

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

Nzollner
Copy link
Contributor

Purpose of this PR

This is a backport of this PR adding multi-edit to the UniversalRenderPipelineAsset.

image


Testing status

This is only a UI change and because of that, I have not started any testing since there should be no changes to the result.

I have tested the multi-edit on my laptop(Windows 10, using DX11).
I tested the multi-edit by checking if I could change the values and if the values change affected the view and if the actions were undoable which they were.


Comments to reviewers

When you test this check if the values work as expected and if the changes correspond to the visual changes which should be applied with the changed values.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_2021.2

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@Nzollner Nzollner changed the title [Backport] Added multiedit to UniversalRenderPipelineAsset [Backport 2021.2] Added multiedit to UniversalRenderPipelineAsset Sep 16, 2021
@Nzollner Nzollner merged commit 9b28c79 into 2021.2/staging Sep 16, 2021
@Nzollner Nzollner deleted the 2021.2/universal/backport/multiedit branch September 16, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants