Skip to content

Conversation

Nzollner
Copy link
Contributor

Purpose of this PR

The purpose of this PR is to add multi-edit to the universal render pipeline asset, described in this fogbugz case.

This is only a UI change and because of that, I have not started any testing since there should be no changes to the result.

image


Testing status

I have tested the multi-edit on my laptop(Windows 10, using dx11).
I tested the multi-edit by checking if I could change the values and if the values change affected the view and if the actions were undoable which they were.


Comments to reviewers

When you test this check if the values work as expected and if the changes correspond to the visual changes which should be applied with the changed values.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@Nzollner Nzollner requested a review from a team September 13, 2021 12:18
@Nzollner Nzollner marked this pull request as ready for review September 13, 2021 12:22
@Nzollner Nzollner requested a review from a team as a code owner September 13, 2021 12:22
Copy link
Contributor

@alex-vazquez alex-vazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@martint-unity martint-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants