Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SetPerCameraShaderVariables function not working as expected #6249

Merged
merged 5 commits into from Nov 18, 2021

Conversation

thomas-zeng
Copy link
Contributor

@thomas-zeng thomas-zeng commented Nov 8, 2021

PR is second iteration of #6114
Shader Graph team had already approved the other iteration.


Purpose of this PR

  • This PR fixed an issue where _ScreenParams set by SetPerCameraShaderVariables are getting reset.

Testing status

  • Tested with local project that disaplays _ScreenParams.xy value on quad.
  • ABV

Comments to reviewers

@thomas-zeng thomas-zeng requested review from a team as code owners November 8, 2021 15:55
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@thomas-zeng thomas-zeng requested a review from a team as a code owner November 9, 2021 08:50
@phi-lira phi-lira changed the base branch from universal/staging to master November 10, 2021 09:30
@phi-lira phi-lira force-pushed the universal/xr/fix-percam-shadervar-urp branch from 8da6abb to e619900 Compare November 10, 2021 09:34
@phi-lira phi-lira changed the base branch from master to universal/staging November 10, 2021 09:36
@phi-lira phi-lira merged commit 3a6c4a1 into universal/staging Nov 18, 2021
@phi-lira phi-lira deleted the universal/xr/fix-percam-shadervar-urp branch November 18, 2021 17:17
This was referenced Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants