Skip to content

Conversation

phi-lira
Copy link
Contributor

@phi-lira phi-lira commented Nov 25, 2021

Second iteration of #6338 URP quality improvements

pbbastian and others added 8 commits November 18, 2021 16:56
* "Add Renderer Feature" menu now uses the same menu as "Volume Overrides"

* Universal Renderer help URL

* Add page hash to help URL helper

* Allow renderer features to use HelpURLAttribute and add it for SSAO, Decal, and Render Objects

* Remove Name input for SSAO and Screen Space Shadows

* Fix help URL for URP asset

* Update change log

* Fix change log

* Remove `Attribute` suffix from attribute usage

* Add docs for FilterWindow.Show

* Move GetHelpURL to DocumentationUtils

* Improve TryGetHelpURL interface
)

* Upgraded Runtime/Materials/*.mat files.

* Foundation CommonAssets/ *.mat files upgrade.

* Foundation Scenes/ .mat files upgrade.

* Foundation Scenes/ .renderTexture files upgrade.

* Lighting CommonAssets/ .mat upgrade.

* Lighting EditMode Assets .mat files upgrade.

* Lighting Scenes/ .mat files upgrade.

* Lighting Scenes/ .renderTexture files upgrade.

* Terrain CommonAssets/ .mat files upgrade.

* Terrain Scenes/ .mat files upgrade.

* PostProcessing CommonAssets/ .mat files upgrade.

* PostProcessing Scenes/ .mat files upgrade.
…de depth and fixing CopyDepth for editor to not use CameraTarget (#6336)
…st shader (#6260)

* Make USE_DRAW_PROCEDURAL variation only for vertex programs in UberPost shader

* Make USE_DRAW_PROCEDURAL variation only for vertex programs

This change was done only for shaders inside PostProcessing folder

* Update changelog

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
…6249)

* * Moved `SetPerCameraShaderVariables` into percamera setup scope. This call has to be called after SetupCameraProperties to reset the values.

* * Moved SetCameraMatrices call inside the SetPerCameraShaderVariables

* * Updated CHANGELOG.md.

Co-authored-by: Felipe Lira <felipedrl@gmail.com>
# Conflicts:
#	com.unity.render-pipelines.universal/CHANGELOG.md
@phi-lira phi-lira requested review from a team as code owners November 25, 2021 10:12
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@phi-lira phi-lira merged commit 354e558 into master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants