Fix path traced DoF focusing issue #732

pmavridis · 2020-06-05T08:31:29Z

Here is a life lesson: never base your implementation in a ShaderToy (or blog) that looks good enough. This is what a did for the path traced DoF and it turns out, the results were not 100% what we wanted.

This PR fixes an issue in the PT DoF implementation that was causing the edges of the picture to be out-of-focus (only the center was in perfect focus).

The following screenshot shows the difference between old and new:

The new implementation (based on the PBR book) is also simpler and uses less instructions.

Testing status

I have updated the PT DoF unit test reference image. All DXR tests are green.

Not sure if it needs to be re-tested, but I have added Remi for visibility.

sebastienlagarde

ok, no need for re-test . Merging

* Implement Constant Buffers for HDRP (part 2) (#87) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Minor adjustments to TAA anti flicker (#97) * small adjust to taa antiflicker * Changelog * Add support for lighting decomposition debug mode (+ AOV) (#99) * Add lighting decomposition debug mode * fix compil issue with probe volumes * Fix usage of debug exposure in debug mode * Add Test 3001 + fix reflection when sky only * remode _DebugExposure after merge * remode _DebugExposure after merge * fix merge issue * add exposure compensation to Fixed exposure mode * Update ColorUtils.cs * Fix MSAA resolve when there is no motion vectors (#1) * Fix MSAA resolve when there is no motion vectors * Update CHANGELOG.md * Cleaned up code * use multi_compile * Added _ Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix switch shader compilation (#111) * DXR Automated tests shader graph optimizations (#116) * Split 902 scene into 5 scenes + SG optimizations * Deleting old image for splited scene * Fix various leaks in HDRP. (#113) * Fixed a number of leak in HDRP * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile error with XR SubsystemManager (#107) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update SceneViewDrawMode.cs (#118) * Follow references when deleting unloading unused assets on shader graph save (case 1230996) (#114) * Follow references when unloading unneeded assets * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix culling of reflection probes that change position (#121) * Fix culling of reflection probes that change position * Avoid null reference * Avoid null reference - try 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix null reference when processing light probe (#131) * Hdrp/runtimetests/ps4 fix (#129) * Redo branch. Upgrade to 2020.1.0b5, reduce texture res, new HDRP asset. * Switch to HDRI, increase Garlic heap size to 4gb, turn on "Stop NaNs" on camera, decrease render target res. * Fix issues causing planar probes to be broken with multiple cameras in the scene (#4) * Set appropriate render datas before rendering cameras * changelog * update doc * comment update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * fix black screen in XR when HDRP package is present but not used (#137) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). (#18) * Fixed an issue with the specularFGD term being used when the material has a clear coat (lit shader). * update ssr screenshot Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for rasterized area light shadows in StackLit + slight refactor (#39) * Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled. * Doc: remove note about area light shadows for stacklit. [skipci] Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Fix for white flash happening when changing lighting condition (like teleport) (#140) * fix * Update PostProcessSystem.cs * Update CHANGELOG.md * Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection * Update CHANGELOG.md * adress PR feedback * Fix default volume profile collapse (#138) * Only re-create the volume profile editor when the asset is changed * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Bind missing buffer (#159) Bind buffer to make sure that something is bound Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163) * fix warning * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window. * Update changelog * Fix Unlit.template in shadergraph (#637) * Remove unused unlitpass.template * Update Lit.hlsl * re-add unlit pass * Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609) * - Fixed a bug where the light list is not cleared but still used when resizing the RT. * add changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram view improvements (#589) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * print exposure values in debug view * commit but it is nothing, need to switch branch * Add option to center histogram around exposure (fixed tonemap curve) * change color of text * fixup debug display merge issue * fixup merge issues * fixup issue with tonemap curve Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 9702_CustomPass_API.png.meta * Fix warning (#663) * add shader macros for XR single-pass (#687) * Adding 2 SG Pathtracer test scenes (#624) * New unlit pt scene * Add scene for PT Lit * Removing collider from the meshes * Renaming * Adding screenshots for PT scenes * Changing threshold for SSS deferred tests for stability * updating screenshot after staging being merged * Slightly increasing threshold for 5007 and 902 unlit scenes Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Render Graph Unit Tests (#607) * Render Graph Unit test WIP Fixed pruning of passes with no output. * Render Graph tests WIP * Increase max limit in UX of lights (#702) * Raise the max for lights * Update CHANGELOG.md * Fix null reference in volume debug menu (#705) * Update reference image for "502_RecursiveRenderingDisabled" (#704) * Update screenshot for 502 recursive rendering disabled test scene * upgrade shader material * Fix transparent movec scene view (#698) * Disable transparent movec when object motion vectors are disabled * changelog * Port (#599) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass API part 2 (#227) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Added the API to override camera rendering * Updated changelog * Updated changelog * Fixed compilation issue * Added custom pass API test scene * Begin to add custom pass override test * Factorized protection function * Update custom pass test scene * Fixed custom pass API doc * Begin to add camera override tests * Fixed camera override in scene view * Finished RenderFrom API fucntions * Fixed XR disable class * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations * Finished to fix the RenderFrom* functions * Moved obsolete execute function into the new one * Update reference images * Added all the API doc * Updated changelog * revert mats * Updated custom clear pass to use the new API * Fixed depth buffer random read/write error * Disable custom pass blur test part * Revert camera pixel rect changes * Rename multi-pass to single pass * Disable custom pass test on vulkan and XR Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix line that got lost in merge (#729) * Porting console fixes to staging (#699) * Path tracer: added support for transparency on the Unlit shader. (#717) * Added support for transparency in Unlit. * Updated Changelog. * Update capture for 5007_PathTracing Unlit Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor related fixes (#730) * Fixes for the compositor test * Enable the compoositor test in build settings * Avoid gc alloc, hide internal components from vomume menu * Vulkan and DX12 screens, adjust compositor UI refresh * Fixed a vulkan and metal warning in the SSGI compute shader. (#715) * - Fixed a vulkan and metal warning in the SSGI compute shader. * - Fixed an exception due to the color pyramid not allocated when SSGI is enabled. - Fixed an issue with the first depth history mip was incorrectly copied. * Fix path traced DoF focusing issue (#732) * Remove mip padding from PlanarReflectionProbeCache.cs * Disable 9702 test nor working + 9041 XR (instable) * Hdrp/pt pass no bsdf data (#710) * Removed direct use of BSDFData in path tracing pass. * Updated changelog. * Fixed float3 typo... * fix metal 9800 reference screnshots * update meta file and testcasefilter * Pre warm RT Handle system so that reallocations are reduced. (#713) * Pre warm rt handle system and initialize to screen width/height * changelog * not all was pushed Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fixes for Graphics tests with Render Graph (#725) * WIP for enabling valid graphics tests with Render Graph. Fixed a lot of gcalloc. * Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled. * First batch of disabled tests. * Fixed decal rendering * Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral) * Revert "First batch of disabled tests." This reverts commit 505924b6967041787c0698b4ede1d158686f990e. * Temp "texture not bound" error fix until bloom is implemented. * Fixed an error when using a stale invalid renderer list handle. Reduced error message spam when encountering an execution error. * Add some debug info to compiled passes and removed wrong refCount++ on passes. * Added possibility to disallow pass pruning Fixed a number of pass pruning issues. * Small fixes * temporarily removed pruning of passes without product * Fixed HDRP asset for test 5009 * Implement alpha copy for post processes * Small render graph error fix for motion vector pass. * Disabled for render graph tests that are currently broken. * Updated yamato with new render graph configurations * Fixed lens distortion * Reenabled 4021 * Revert "Reenabled 4021" This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64. * Revert "Updated yamato with new render graph configurations" This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9. * Revert "Disabled for render graph tests that are currently broken." This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026. * Reverted HDRP test framework files (will go to another PR) * Revert "Fixed HDRP asset for test 5009" This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fix and improvements for ray traced effects (#597) * Adding a minimal lit used for RTGI in peformance mode Dispatch binned rays in 1D instead of 2D Fix an issue with the half resolution Mode for RTGI Only read the geometric attributes that are required using the share pass info and shader graph defines Fix an issue with the color intensity of emissive for performance rtgi * Correct bug with shadow history rejection * reduce the exponential accumulation value a bit Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Procedural metering mask that follows target (#723) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * start of procedural mask * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * Some basic version of procedural working * need to switch branch * Exposure target and threshold. * fix merge mess * Fixes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Added presets quality settings for RTAO and RTGI. (#724) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue in HDRaytracingIndirectDiffuse * fix shader warning in exposure * Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648) * - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). * Simplifying the culling override. * Update 708_ShadowExtendedCulling.png Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Removed reference image for player (unused) in HDRP Test * Update preview naming (#753) * Cloud layer volume override (#461) * Added uv distorsion for …

* Added support for rasterized area light shadows in StackLit + slight refactor (#39) * Added support for rasterized area light shadows in StackLit. Also refactor code to avoid early return (compiler bug) and fix lux meter debug mode when anisotropy for area lights is enabled. * Doc: remove note about area light shadows for stacklit. [skipci] Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update the scripting API for FrameSettings, FrameSettingsOverrideMask and IBitArray (#110) * Fix for white flash happening when changing lighting condition (like teleport) (#140) * fix * Update PostProcessSystem.cs * Update CHANGELOG.md * Add some clamp to fp16 for case where we don't have a NaN killer pass like planar reflection * Update CHANGELOG.md * adress PR feedback * Fix default volume profile collapse (#138) * Only re-create the volume profile editor when the asset is changed * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Bind missing buffer (#159) Bind buffer to make sure that something is bound Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * AxF fix: Use CALCULATE_TEXTURE2D_LOD macro for future cross platform compatibility (Metal) (#162) * Fixed shader warning on Xbox for ResolveStencilBuffer.compute (#163) * fix warning * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window. * Update changelog * Fix Unlit.template in shadergraph (#637) * Remove unused unlitpass.template * Update Lit.hlsl * re-add unlit pass * Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609) * - Fixed a bug where the light list is not cleared but still used when resizing the RT. * add changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram view improvements (#589) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * print exposure values in debug view * commit but it is nothing, need to switch branch * Add option to center histogram around exposure (fixed tonemap curve) * change color of text * fixup debug display merge issue * fixup merge issues * fixup issue with tonemap curve Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 9702_CustomPass_API.png.meta * Fix warning (#663) * add shader macros for XR single-pass (#687) * Adding 2 SG Pathtracer test scenes (#624) * New unlit pt scene * Add scene for PT Lit * Removing collider from the meshes * Renaming * Adding screenshots for PT scenes * Changing threshold for SSS deferred tests for stability * updating screenshot after staging being merged * Slightly increasing threshold for 5007 and 902 unlit scenes Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Render Graph Unit Tests (#607) * Render Graph Unit test WIP Fixed pruning of passes with no output. * Render Graph tests WIP * Increase max limit in UX of lights (#702) * Raise the max for lights * Update CHANGELOG.md * Fix null reference in volume debug menu (#705) * Update reference image for "502_RecursiveRenderingDisabled" (#704) * Update screenshot for 502 recursive rendering disabled test scene * upgrade shader material * Fix transparent movec scene view (#698) * Disable transparent movec when object motion vectors are disabled * changelog * Port (#599) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass API part 2 (#227) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Added the API to override camera rendering * Updated changelog * Updated changelog * Fixed compilation issue * Added custom pass API test scene * Begin to add custom pass override test * Factorized protection function * Update custom pass test scene * Fixed custom pass API doc * Begin to add camera override tests * Fixed camera override in scene view * Finished RenderFrom API fucntions * Fixed XR disable class * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations * Finished to fix the RenderFrom* functions * Moved obsolete execute function into the new one * Update reference images * Added all the API doc * Updated changelog * revert mats * Updated custom clear pass to use the new API * Fixed depth buffer random read/write error * Disable custom pass blur test part * Revert camera pixel rect changes * Rename multi-pass to single pass * Disable custom pass test on vulkan and XR Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix line that got lost in merge (#729) * Porting console fixes to staging (#699) * Path tracer: added support for transparency on the Unlit shader. (#717) * Added support for transparency in Unlit. * Updated Changelog. * Update capture for 5007_PathTracing Unlit Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor related fixes (#730) * Fixes for the compositor test * Enable the compoositor test in build settings * Avoid gc alloc, hide internal components from vomume menu * Vulkan and DX12 screens, adjust compositor UI refresh * Fixed a vulkan and metal warning in the SSGI compute shader. (#715) * - Fixed a vulkan and metal warning in the SSGI compute shader. * - Fixed an exception due to the color pyramid not allocated when SSGI is enabled. - Fixed an issue with the first depth history mip was incorrectly copied. * Fix path traced DoF focusing issue (#732) * Remove mip padding from PlanarReflectionProbeCache.cs * Disable 9702 test nor working + 9041 XR (instable) * Hdrp/pt pass no bsdf data (#710) * Removed direct use of BSDFData in path tracing pass. * Updated changelog. * Fixed float3 typo... * fix metal 9800 reference screnshots * update meta file and testcasefilter * Pre warm RT Handle system so that reallocations are reduced. (#713) * Pre warm rt handle system and initialize to screen width/height * changelog * not all was pushed Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fixes for Graphics tests with Render Graph (#725) * WIP for enabling valid graphics tests with Render Graph. Fixed a lot of gcalloc. * Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled. * First batch of disabled tests. * Fixed decal rendering * Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral) * Revert "First batch of disabled tests." This reverts commit 505924b6967041787c0698b4ede1d158686f990e. * Temp "texture not bound" error fix until bloom is implemented. * Fixed an error when using a stale invalid renderer list handle. Reduced error message spam when encountering an execution error. * Add some debug info to compiled passes and removed wrong refCount++ on passes. * Added possibility to disallow pass pruning Fixed a number of pass pruning issues. * Small fixes * temporarily removed pruning of passes without product * Fixed HDRP asset for test 5009 * Implement alpha copy for post processes * Small render graph error fix for motion vector pass. * Disabled for render graph tests that are currently broken. * Updated yamato with new render graph configurations * Fixed lens distortion * Reenabled 4021 * Revert "Reenabled 4021" This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64. * Revert "Updated yamato with new render graph configurations" This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9. * Revert "Disabled for render graph tests that are currently broken." This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026. * Reverted HDRP test framework files (will go to another PR) * Revert "Fixed HDRP asset for test 5009" This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fix and improvements for ray traced effects (#597) * Adding a minimal lit used for RTGI in peformance mode Dispatch binned rays in 1D instead of 2D Fix an issue with the half resolution Mode for RTGI Only read the geometric attributes that are required using the share pass info and shader graph defines Fix an issue with the color intensity of emissive for performance rtgi * Correct bug with shadow history rejection * reduce the exponential accumulation value a bit Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Procedural metering mask that follows target (#723) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * start of procedural mask * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * Some basic version of procedural working * need to switch branch * Exposure target and threshold. * fix merge mess * Fixes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Added presets quality settings for RTAO and RTGI. (#724) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue in HDRaytracingIndirectDiffuse * fix shader warning in exposure * Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648) * - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). * Simplifying the culling override. * Update 708_ShadowExtendedCulling.png Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Removed reference image for player (unused) in HDRP Test * Update preview naming (#753) * Cloud layer volume override (#461) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * CloudLayer HDRI * CloudLayer Gradient * CloudLayer Physically Based * Documentation * Add clouds to Static Lighting Sky * Fix spherical conversion * Fix procedural flow * Fix lat long and procedural flow * replace trig functions. Correct wind dir * sync with hdri flow * Renamed variables * Allow full sphere coverage for procedural flowmap * Added missing doc * Fix cloud reset and unrelated warnings in hdri sky shader * Try different blending method * Fixes + test another blending * Tint and intensity parameters. Fix static sky used by lightmapper * Added graphic test. Updated doc * Updated tests using a disabled static sky If a sky override is used for static lighting and is disabled in the volume, it is not used anymore * Update LocalAmbientOcclusionNoisy.asset * update linux screenshots * Update CloudLayer.cs * update OSX screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Introduce LightLoop output structure (#754) * Add concept of LightLoop Output * update upgrade guide * Update Upgrading-from-2020.1-to-2020.2.md * update upgrade guide * Fix lightloop-output (#755) * Fix rendering when XrMaxViews is different than 2 (#733) * Use a fixed size for xr related fields in cbuffers * changelog * Update local shader config * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Improve transition between LOD for lit and layeredLit tessellation (#517) * Forest scale for tessellation change * Forest scale for tessellation change * Update Upgrading-from-2019.3-to-2020.1.md * Update Upgrading-from-2019.3-to-2020.1.md * fix ray tracing with XR single-pass (#769) * Revert "fix ray tracing with XR single-pass (#769)" This reverts commit 3e366334444febf450568b47ada2c00e4164ba12. * reviewed new additions to 2019.3 - 2020.1 and 2020.1 - 2020.2 upgrade guides (#766) * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Initial implementation for the new planar reflection filtering (#337) * Initial implementation for the new planar reflection filtering * Small improvement and "proper" support of oblique projection * quality improvement to the filtering. * Update PlanarReflectionFiltering.compute * review corrections * Update planar filter for all material (was not replaced) + update screenshots * Update IBLFilterGGX.cs * fix shader warning on vulkan * update references screenshots * Fixes for the plane normal and number of mips to be computed * Fix shift that was to the right in the blurred version * update references screenshots * fix shader warning * Some cleanup * change to fast Atan Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fast memory support (#772) * temp, gonna revert this, but have to merge staging. * again, need to switch branch, nothing functional * ESRAM support * changelog * Add guards * Standard terrain upgrader (#762) * Add render graph specific pipeline to HDRP tests. (#728) * Added an option to ignore tests when render graph is enabled. * Disabled for render graph tests that are currently broken. * Reenabled 4021 * Updated yamato script to add the RenderGraph pipeline. * Fixed HDRP asset for test 5009 * Revert unrelated yml files changes due to old configuration (#714) * Fixed an issue with not unregistering render graph debug. Disabled test 9401 for render graph after merge conflict. * Disabled 9800 for render graph * Revert hdrp asset for 5009 Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> * Added CPU and GPU timings for ray tracing effects. (#774) * Added CPU and GPU timings for ray tracing effects. * Only displaying the counters if ray tracing is supported on the asset. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Workaround for GetKernelThreadGroupSizes returning wrong data (#760) * Hard code group size * changelog * Add comment * Fixed the distanced based denoising being exposed for area lights (1251558). (#782) * Fix test project * Fix an issue with Fast memory code trying to access deleted resources when rendergraph is enabled (#791) * Fix issue accessing already released targets for rendergraph * changelog * Sanitize transparent motion vectors setting (#761) * Sanitize transparent motion vectors setting * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Revert "Add render graph specific pipeline to HDRP tests. (#728)" This reverts commit 4bcb4364fdd24a7d3205b46a5ce0ed63fe63cb5e. Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: victor-unity <50244023+victor-unity@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Sean Puller <43151199+SeanPuller@users.nore…

* Texture-weighted automatic exposure (#165) * Exposure weighted by texture * miss one in the renaming * Doc update * changelog * doc update * fix issue when disabling override * Update 3003_LightingMode.unity * Optimizing light loop part 2 (#2) * Saving 10% off the PrepareLightForGPU * 18% decrease in cost with this * Around 12% cost shaving off GetLightData * Around 6.5% win here * Faster View matrix flip * Missing *=-1 * About 7% win in preprocess light data * Another small batch * Small cleanup for first optimization pass * Tiny bit more cleanup * Make UpdateShadowRequests 12% cheaper * Address review points * A bit less than 20% win in ExtractPointLightData * Add comment * changelog * 25% reduction of ExtractPointLightData * 18% win in UpdateShadowRequest * Another around 11% win for UpdateShadowRequest * Move matrix multiply utils to core * less lighttype computation * Ooops * fixup changelog * Proper merge * Missing leftovers . * I'll manage to submit it all one day... Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added support for POM for emissive map (#51) * Add option to use Base UV Mapping for emission * Graphic test and doc * Changelog * Screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor Tool (#57) * HDRP compositor tool, first code drop documentation typo, move everything in compositor namespace documentation typo bugfix: dynamically add/remove properties when shadergraph changes UI bugfix: properly compute height of UI elements Missing tooltips, button to remove the compositor toggle layers now works when player is paused add chroma keying in the compositor test Changelog, workflow bugfix Use Unity's built'in icons AOV bugfixes AOV tooltip was wrong bugfix: disabling the compositor now disables all compositor cameras Proper monitoring of shadergraph changes Updated test image + minor changes Use better names for internal cameras Bugfix: selecting the same res for a layer Bugfix: deleting in-use texture layers from shadergraph now works Bugfix: setting AOV to none now works properly Use the term SubLayer in the UI Improve AOV tooltip Camera properties in layers are properly refreshed UI: Move checkbox for overrides on the left side of the label Remove default compositor camera when also deleting the compositor Bugfixes: no orphans (delete all children when removing a layer), saving the layer list now works again Hdrp/docs/compositor (#6013) * Added docs review * Changed fodler for images Bugfixe: deleting layers Bugfix: reordering layers Bugfix: creating a new compositor fails Remove redundant check Fix wrong tooltip Bugfix when deleting camera stack layers Bugfix: handle window resize Bugfix: sub-layers without parent when re-ordering, preview remains visible for disabled layers Bugfix: more robust re-ordering (also moves children) Bugfix: mark scene dirty when adding a compositor Bugfix: display warning when alpha is configured properly Change video layer icon Bugfix: adding a layer filter does not reset the UI state Bugfix: do not show composition properties that are marked with hide-in-inspector Better / more clean layer injection implementation minor code clean up Clear color mode should only be editable on the first layer of a stack Bugfix: setup of custom render was not always called Bugfix: make sure additional camera data always exist in the layer/compositor camera Change test id to 9800 Fix typos mark scene dirty when removing or disabling the compositor Default composition shadergraph and profile are now cloned Serialized objects are now properly updated minor code change: range checks bugfix: error message appears at beginning remove layer list from the asset file add default camera layer when creating the compositor replace getter function with c-sharp property update asset in unit test * move compositor unit test images * remove leftover code * review feedback #1 * review feedback 2 * review feedback - custom clear shader * fix variable names that don't affect serialization * fix serialized variable names * bugfix: image layers and camera stacking * use enum utility functions * Use multicompile in motion blur + bug fix * Make some variables private * Update Compositor-User-Guide.md * Review feedback * fix muticompile for motion blur without alpha * Update to new constant buffer / shadergraph api * Player test image for the compositor * Properly fill camera entries for global constant buffer * Fix after rebase / function rename * Make bg red for better debugging qnd cqtch unity exception * Disable compositor test until we fix it on yamato Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * PBR shader gbuffer ztest (#43) * Fixed PBR shader rendering in deferred * Updated changelog * Enable Light Baking Cookies by default + Warning (#79) * Enable * Fix typo * Importance Sampling Pipeline (#84) * Multiple Importance Sampling for HDRI Sky (Ray Generation) * backup * Multiple helpers * Add RTHandleDeleter (delay in K frame the Release of a RTHandle) * Fix GPU Operation when texture are too small * Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ... * Helper manager to generate one marginal per slice mip (one per frame) * backup * Add SampleCubemapProjectionNode (Project cubemap to Geometry) * delete useless files * update * Cube To LatLong for CubeArray * Functional generation * Integration on ray tracer step * Store HDRI Integral * . * Integrate HDRI Sky * Update Importance Sampling * Update Algorithm with Hemisphere Path * Backup * Update merge * Update Merge 001 * Update Merge 002 * Update Merge 003 * Update Merge 004 * Update Merge 005 * Update Merge 006 * Update Merge 007 * Cleanup * Update Integration of HDRISky Upper Hemisphere * Remove useless dump images on disk * Fix change log issue * backup * Backup * Pre-Clean * Pre-Clean * Clean Up - remove file * Remove Debug Code * Update * Update ChangeLog * Clean Up * update * Clean up * Remove useless texture * Fix CGAlloc + Default Litetime of a RTHandle on the "RTHandleDeleter" * CleanUp * remove useless comment * Add variable (Atmospherical) + Rename/Comment * Move parameter to CS, Clean & move to private RTHandleDeleter * Revert "Importance Sampling Pipeline (#84)" This reverts commit 835d6a45c15ec7cbebde2aa385134a780c363e11. * Reducing the number of variants for ray tracing when building a player (#94) * - Replaced the DIFFUSE_LIGHTING_ONLY multicompile by a uniform. - Removed the dynamic lightmap multicompile. - Remove the LOD cross fade multi compile for ray tracing. - Added a ray tracing mode option in the HDRP asset that allows to override and shader stripping. * fix merge * Update LayeredLit.shader * Update LayeredLit.shader Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 3003_LightingMode.unity * Fix compil issue with Enable BakeCookie * Enable Light Baking Cookies by default + Warning - part 3 #79 * Avoid building the mip chain a second time for SSR for transparent objects. (#93) * - Avoid building the mip chain a second time for SSR for transparent objects. * Update ScreenSpaceReflections.compute * fix merge issue Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Scalable volumetrics [skip ci] (#34) * Adaptive sampling works * Compute the PDF * URL * Fix stuff up (except for profile preview) * Attempt to fix previews * Fix transmission * Support quality levels * Clean shader * Remove 2 kernels * PURGE * Automatically adjust the number of samples at runtime * Changelog * Spaaaaace * Add comment * Spaaaaaace * Rename * Update ref img 1215, 1216, 1217 * Revert "Update ref img 1215, 1216, 1217" This reverts commit 9aeb1fee054bc0e8a24b76525eb4af5dc2316088. * Robust filter radius * Solve the NaN problem * Save 1x VGPR * Update SSS defaults * Add migration steps * Volume resolution WIP * Shorter names FTW * Comment * Dynamic slice count works * Dynamic res works * Changelog * Stretch the limits * Fix bug (order matters) * Comments * Remove volumetric quality presets * Changelog * Reorder * Solve the mystery of RTs going NULL * More robust bad history detection * Update test scenes for High Quality * More bug fixes * More accurate comment * Do not reinvent the wheel * Fix broken test 1351 * Attempt to migrate HQ SSS settings * Remove all branches * Optimize a bit * 7x WF * Fix the rounding error * Fix the rounding error * Remove garbage allocation * Fix typos * Copy the SSS value * Revert HDRP asset changes * Fix default UI value * Pass the right asset * Update ref img 1215 * update reference screenshots * Update CHANGELOG.md * Update CHANGELOG.md * Switch to RTHandles * Rename textures used by the fog filtering pass * Fix reprojection * Fix shader warning + typo+ * fix another shader warning Co-authored-by: EvgeniiG <7ee2cc898cca1b5fc49df740c2081dfc681e0a28> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed runtime test for Yamato (#177) * Revert "Hdrp/runtimetests/ps4 fix (#129)" This reverts commit 6fa52ab66c77d12088114577573fb45edfb2baba. * Update runtime test to use way less memory to be able to run on console * Fixed screenshots and test * Fix HDRP Wizard windows not compatible with "preview" package version (#178) * Fix async compute throwing errors because of global constant buffers. (#130) * Replaced commands incompatible with async compute in light list build process. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Diffusion Profile and Material references in HDRP materials are now correctly exported to unity packages. (#136) * Added external references inside a material to diffusion profiles and materials in order to handle Material export to a package correctly. * Update changelog * Removed useless test * Updated changelog message to add more info * Refactoring to share the code for light list building better between probe volumes and lights. (#156) * Refactoring to share the code for light list building better between probe volumes and lights. * Remove commented code * Fixed constant buffer update * Fixed kernel used for cluster generation * Fixed cluster kernel for oblique projection * Restored a resize test for XR * Removed unexpected Shuriken folder in Test Project * Add range attenuation to box-shaped spotlights [Skip CI] (#101) * Added range attenuation to box-shaped spotlights * Update tests * Update CHANGELOG.md * Remove file duplication * Added box range attenuation test * Clarify documentation * Update screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/decal transparent mip selection 1222437 (#96) * Improve MIP selection for decals to transparent * Add change logs * Communize Helper (ComputeTextureLOD{Bias?}(...) * Update * Rename * Comment * fix white space and 0.f Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix cookie atlas alloc for cone spot lights (#187) * Fix unneeded cookie texture allocation for cone stop lights * Updated changelog * Fix cone spot light cookie * update template (#189) * Hdrp/combine material samples with shader samples [Skip CI] (#117) * Fix MaterialBalls having same guid issue material samples and shader samples had the same prefabs with the same guids causing an issue when the guids are reassigned * Merge material samples and shader samples Merge shader samples into material samples * Update scene visuals update frame prefab with new visual style update scene to suit visual style * Fix spelling and grammatical errors alterates -> alters - this one isn't technically an error but alterates isn't used in common English oder -> order accross -> across * Create fabric scene create scene and rendering settings * Add fabric ball prefab with fabric mesh Add fabric ball prefab with fabric mesh * Add threadmaps to project Add threadmaps to project * Add materials to project Add materials to project Linen Nylon Satin Velvet Wool * Add scenes for hair and fabric and create prefabs for lighting and hair display Add scenes for hair and fabric Create prefabs for lighting and hair display Fix Decal prefab * Update scene and fix errors with materials that don't use threadmaps Update scene and fix errors with materials that don't use threadmaps * Update fabric materials and textures Update fabric materials and textures * Clean up project and add additional materials Add ShotSilk material Modify materials Rename textures Cleanup changes Add information to fabric scene * Update and organize scenes Update and organize scenes * Update Fabric scene , fix spelling errors and change to american spelling Update Fabric scene , fix spelling errors and change to american spelling * Update information in fabric scene * Update scene lighting Update scene lighting * Align lighting and rendering across scenes, remove old sample scene Create prefabs for common elements Change sky gradient Remove unused settings Remove old sample scene * Update textures and meshes Update denim color to tga file format to conform with other files Update cloth mesh to have better normals Update scene after changes to prefab * Update cloth mesh Update cloth mesh * Update scene text and cloth mesh Update scene text and cloth mesh * Update Changelog Update Changelog * Fix bug with material ball and parallax occlusion mapping due to mesh tangents Fix bug with material ball and parallax occlusion mapping due to mesh tangents * Remove shader samples from package json and update material samples description Remove shader samples from package json and update material samples description * Update sample content documentation * Update scene text * Move files in mesh folder to appropriate folders and remove additional material ball prefab * Add micro shadows * Update 1301_StackLitSG.png * Change guid reference in MaterialSamples scene Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * DisplayInfo attribute. (#172) * Added DisplayInfo attribute for generic display info. * Implemented volume parameter sorting for default inspector. * Update changelog * Named parameters for tuples in Volume Component Editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Compute Buffer management for render graph (#194) * Added import and usage of Compute Buffer API to render graph. * Missing clear of Compute buffer write/read lists. * Another missing clear. * Light loop compute buffers WIP # Conflicts: # com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs # com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDRenderPipeline.LightLoop.cs * Reverted Render Graph debug registering by default. * Post merge fixes * RenderPass debugger visualization and fixed null profiling sampler * Missing using directive. * Post merge fix * Use new light list build ouptut for deferred lighting pass * Use new light list build ouptut for contact shadow pass * Use new light list build ouptut for volumetric passes * Simplify the tooltip (#188) * Added MovedFrom attribute (#182) * Contact shadow min distance + fix scalarization code (#150) * Min distance * editor update * Update doc * Changelog * fix some ui issues * Update docs according to UI changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * TAA docs update (#132) * update docs * pr review * Added indentation as dashed * Hdrp/deferred shadow quality multi compile (#5) * shadow mask * Changelog * Have shadow quality as multi_compile * make old API obsolete * Update comment * Comment on pre processor * Update docs * Change shader versions of deferred Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/path traced dof (#164) * Path traced DoF implementation * Move focus distance from volume to physical camera * Small fixes * Small fixes in math * Small fixes in math 2 * Compile error * Make new functions private * Cosmetic changes * Move viewport matrix function to utils * Keep focus distance in the volume * Do not enable in scene view camera * Changelog * Review feedback * Use scale and bias instead of matrix mul for the viewport transform * Bugfix: post process DoF should still be executed for non-physical mode * Typo * avoid null reference when physical params is null * remove redundant check * Update HDRenderPipelineAsset.asset (#210) * Fixed volume debug menu in playmode (#149) * Refresh widgets in play mode. Added doc. Reduced refresh rate * Changelog * Added some code doc * Fix refresh rate and scroll over hidden volumes in play mode Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added a new test scene for physical camera DoF in Pathtracer (#211) * Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window. * Update changelog * Fix Unlit.template in shadergraph (#637) * Remove unused unlitpass.template * Update Lit.hlsl * re-add unlit pass * Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609) * - Fixed a bug where the light list is not cleared but still used when resizing the RT. * add changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram view improvements (#589) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * print exposure values in debug view * commit but it is nothing, need to switch branch * Add option to center histogram around exposure (fixed tonemap curve) * change color of text * fixup debug display merge issue * fixup merge issues * fixup issue with tonemap curve Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 9702_CustomPass_API.png.meta * Fix warning (#663) * add shader macros for XR single-pass (#687) * Adding 2 SG Pathtracer test scenes (#624) * New unlit pt scene * Add scene for PT Lit * Removing collider from the meshes * Renaming * Adding screenshots for PT scenes * Changing threshold for SSS deferred tests for stability * updating screenshot after staging being merged * Slightly increasing threshold for 5007 and 902 unlit scenes Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Render Graph Unit Tests (#607) * Render Graph Unit test WIP Fixed pruning of passes with no output. * Render Graph tests WIP * Increase max limit in UX of lights (#702) * Raise the max for lights * Update CHANGELOG.md * Fix null reference in volume debug menu (#705) * Update reference image for "502_RecursiveRenderingDisabled" (#704) * Update screenshot for 502 recursive rendering disabled test scene * upgrade shader material * Fix transparent movec scene view (#698) * Disable transparent movec when object motion vectors are disabled * changelog * Port (#599) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass API part 2 (#227) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Added the API to override camera rendering * Updated changelog * Updated changelog * Fixed compilation issue * Added custom pass API test scene * Begin to add custom pass override test * Factorized protection function * Update custom pass test scene * Fixed custom pass API doc * Begin to add camera override tests * Fixed camera override in scene view * Finished RenderFrom API fucntions * Fixed XR disable class * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations * Finished to fix the RenderFrom* functions * Moved obsolete execute function into the new one * Update reference images * Added all the API doc * Updated changelog * revert mats * Updated custom clear pass to use the new API * Fixed depth buffer random read/write error * Disable custom pass blur test part * Revert camera pixel rect changes * Rename multi-pass to single pass * Disable custom pass test on vulkan and XR Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix line that got lost in merge (#729) * Porting console fixes to staging (#699) * Path tracer: added support for transparency on the Unlit shader. (#717) * Added support for transparency in Unlit. * Updated Changelog. * Update capture for 5007_PathTracing Unlit Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor related fixes (#730) * Fixes for the compositor test * Enable the compoositor test in build settings * Avoid gc alloc, hide internal components from vomume menu * Vulkan and DX12 screens, adjust compositor UI refresh * Fixed a vulkan and metal warning in the SSGI compute shader. (#715) * - Fixed a vulkan and metal warning in the SSGI compute shader. * - Fixed an exception due to the color pyramid not allocated when SSGI is enabled. - Fixed an issue with the first depth history mip was incorrectly copied. * Fix path traced DoF focusing issue (#732) * Remove mip padding from PlanarReflectionProbeCache.cs * Disable 9702 test nor working + 9041 XR (instable) * Hdrp/pt pass no bsdf data (#710) * Removed direct use of BSDFData in path tracing pass. * Updated changelog. * Fixed float3 typo... * fix metal 9800 reference screnshots * update meta file and testcasefilter * Pre warm RT Handle system so that reallocations are reduced. (#713) * Pre warm rt handle system and initialize to screen width/height * changelog * not all was pushed Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fixes for Graphics tests with Render Graph (#725) * WIP for enabling valid graphics tests with Render Graph. Fixed a lot of gcalloc. * Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled. * First batch of disabled tests. * Fixed decal rendering * Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral) * Revert "First batch of disabled tests." This reverts commit 505924b6967041787c0698b4ede1d158686f990e. * Temp "texture not bound" error fix until bloom is implemented. * Fixed an error when using a stale invalid renderer list handle. Reduced error message spam when encountering an execution error. * Add some debug info to compiled passes and removed wrong refCount++ on passes. * Added possibility to disallow pass pruning Fixed a number of pass pruning issues. * Small fixes * temporarily removed pruning of passes without product * Fixed HDRP asset for test 5009 * Implement alpha copy for post processes * Small render graph error fix for motion vector pass. * Disabled for render graph tests that are currently broken. * Updated yamato with new render graph configurations * Fixed lens distortion * Reenabled 4021 * Revert "Reenabled 4021" This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64. * Revert "Updated yamato with new render graph configurations" This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9. * Revert "Disabled for render graph tests that are currently broken." This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026. * Reverted HDRP test framework files (will go to another PR) * Revert "Fixed HDRP asset for test 5009" This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fix and improvements for ray traced effects (#597) * Adding a minimal lit used for RTGI in peformance mode Dispatch binned rays in 1D instead of 2D Fix an issue with the half resolution Mode for RTGI Only read the geometric attributes that are required using the share pass info and shader graph defines Fix an issue with the color intensity of emissive for performance rtgi * Correct bug with shadow history rejection * reduce the exponential accumulation value a bit Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Procedural metering mask that follows target (#723) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * start of procedural mask * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * Some basic version of procedural working * need to switch branch * Exposure target and threshold. * fix merge mess * Fixes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Added presets quality settings for RTAO and RTGI. (#724) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue in HDRaytracingIndirectDiffuse * fix shader warning in exposure * Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648) * - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). * Simplifying the culling override. * Update 708_ShadowExtendedCulling.png Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Removed reference image for player (unused) in HDRP Test * Update preview naming (#753) * Cloud layer volume override (#461) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * CloudLayer HDRI * CloudLayer Gradient * CloudLayer Physically Based * Documentation * Add clouds to Static Lighting Sky * Fix spherical conversion * Fix procedural flow * Fix lat long and procedural flow * replace trig functions. Correct wind dir * sync with hdri flow * Renamed variables * Allow full sphere coverage for procedural flowmap * Added missing doc * Fix cloud reset and unrelated warnings in hdri sky shader * Try different blending method * Fixes + test another blending * Tint and intensity parameters. Fix static sky used by lightmapper * Added graphic test. Updated doc * Updated tests using a disabled static sky If a sky override is used for static lighting and is disabled in the volume, it is not used anymore * Update LocalAmbientOcclusionNoisy.asset * update linux screenshots * Update CloudLayer.cs * update OSX screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Introduce LightLoop output structure (#754) * Add concept of LightLoop Output * update upgrade guide * Update Upgrading-from-2020.1-to-2020.2.md * update upgrade guide * Fix lightloop-output (#755) * Fix rendering when XrMaxViews is different than 2 (#733) * Use a fixed size for xr related fields in cbuffers * changelog * Update local shader config * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Improve transition between LOD for lit and layeredLit tessellation (#517) * Forest scale for tessellation change * Forest scale for tessellation change * Update Upgrading-from-2019.3-to-2020.1.md * Update Upgrading-from-2019.3-to-2020.1.md * fix ray tracing with XR single-pass (#769) * Revert "fix ray tracing with XR single-pass (#769)" This reverts commit 3e366334444febf450568b47ada2c00e4164ba12. * reviewed new additions to 2019.3 - 2020.1 and 2020.1 - 2020.2 upgrade guides (#766) * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Initial implementation for the new planar reflection filtering (#337) * Initial implementation for the new planar reflection filtering * Small improvement and "proper" support of oblique projection * quality improvement to the filtering. * Update PlanarReflectionFiltering.compute * review corrections * Update planar filter for all material (was not replaced) + update screenshots * Update IBLFilterGGX.cs * fix shader warning on vulkan * update references screenshots * Fixes for the plane normal and number of mips to be computed * Fix shift that was to the right in the blurred version * update references screenshots * fix shader warning * Some cleanup * change to fast Atan Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fast memory support (#772) * temp, gonna revert this, but have to merge staging. * again, need to switch branch, nothing functional * ESRAM support * changelog * Add guards * Standard terrain upgrader (#762) * Add render graph specific pipeline to HDRP tests. (#728) * Added an option to ignore tests when render graph is enabled. * Disabled for render graph tests that are currently broken. * Reenabled 4021 * Updated yamato script to add the RenderGraph pipeline. * Fixed HDRP asset for test 5009 * Revert unrelated yml files changes due to old configuration (#714) * Fixed an issue with not unregistering render graph debug. Disabled test 9401 for render graph after merge conflict. * Disabled 9800 for render graph * Revert hdrp asset for 5009 Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> * Added CPU and GPU timings for ray tracing effects. (#774) * Added CPU and GPU timings for ray tracing effects. * Only displaying the counters if ray tracing is supported on the asset. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Workaround for GetKernelThreadGroupSizes returning wrong data (#760) * Hard code group size * changelog * Add comment * Fixed the distanced based denoising being exposed for area lights (1251558). (#782) * Fix test project * Fix an issue with Fast memory code trying to access deleted resources when rendergraph is enabled (#791) * Fix issue accessing already released targets for rendergraph * changelog * Sanitize transparent motion vectors setting (#761) * Sanitize transparent motion vectors setting * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Revert "Add render graph specific pipeline to HDRP tests. (#728)" This reverts commit 4bcb4364fdd24a7d3205b46a5ce0ed63fe63cb5e. * Increased path tracing roughness range. (#763) * Increased path tracing roughness range. * Updated failing tests reference images. * Update Upgrading-from-2020.1-to-2020.2.md (#798) * Force post process parent setting to be before child settings (#799) * Force post process parent setting to be before child * changelog * Fix exposure white flash when enabling SSGI or SSR (#801) * Inform post process that history have been nuked * changelog * Various fixes related to SSGI and RTGI (#803) * Added support to combine RTSSS and RTGI The ray traced indrect diffuse and RTGI were combined wrongly with the rest of the lighting. Fixed an exception happening when using RTSSS without using RTShadows Changing the default SSGI radius for the all configurations Update screenshots for GI scenes * changelog update Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Sean Puller <43151199+SeanPuller@users.noreply.github.com> Co-authored-by: Sean Puller <sean.puller@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Evgenii <evgenii@unity3d.com> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: pastasfuture <pastasfuture@gmail.com> Co-authored-by: Theo Penavaire…

* Fixed issue when toggling anything in HDRP asset that will produce an error (case 1238155) (#215) * fix bug 1238155 * Update CHANGELOG.md * Update HDRenderPipeline.cs * Update HDRenderPipelineAsset.cs * Fix warning in PCSS code when using Vulkan (#229) * Fix warning * changelog * Fix decal register + obsolete cookie API (#195) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Fix decal shader * Fixed HDRP cookie * Update HDLightUI.cs * correctly fix decal * Update CHANGELOG.md * Update ColorAdjustments.cs * Update ShaderVariablesDecal.hlsl * fix compil on 2020.1 * Update HDRP_Test_Def.asset * add test for 3RT decal * update decal test * Do shadow code cleanup + Fix Yamato after PR #5 Multi compile shadow (#244) * Do code cleanup + bugfix shadow * Update Upgrading-from-2020.1-to-2020.2.md * Update LightLoopDef.hlsl * Fixed issues with path traced SSS and accumulation. (#257) * Add missing documentation for AOV API params (#254) * Hdrp/public static sky (#253) * Made the static lighting sky public so that users can change it by script for baking purpose. * Update changelog * Update HDAdditionalLightData.Migration.cs (#269) * Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window. * Update changelog * Fix Unlit.template in shadergraph (#637) * Remove unused unlitpass.template * Update Lit.hlsl * re-add unlit pass * Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609) * - Fixed a bug where the light list is not cleared but still used when resizing the RT. * add changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram view improvements (#589) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * print exposure values in debug view * commit but it is nothing, need to switch branch * Add option to center histogram around exposure (fixed tonemap curve) * change color of text * fixup debug display merge issue * fixup merge issues * fixup issue with tonemap curve Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 9702_CustomPass_API.png.meta * Fix warning (#663) * add shader macros for XR single-pass (#687) * Adding 2 SG Pathtracer test scenes (#624) * New unlit pt scene * Add scene for PT Lit * Removing collider from the meshes * Renaming * Adding screenshots for PT scenes * Changing threshold for SSS deferred tests for stability * updating screenshot after staging being merged * Slightly increasing threshold for 5007 and 902 unlit scenes Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Render Graph Unit Tests (#607) * Render Graph Unit test WIP Fixed pruning of passes with no output. * Render Graph tests WIP * Increase max limit in UX of lights (#702) * Raise the max for lights * Update CHANGELOG.md * Fix null reference in volume debug menu (#705) * Update reference image for "502_RecursiveRenderingDisabled" (#704) * Update screenshot for 502 recursive rendering disabled test scene * upgrade shader material * Fix transparent movec scene view (#698) * Disable transparent movec when object motion vectors are disabled * changelog * Port (#599) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass API part 2 (#227) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Added the API to override camera rendering * Updated changelog * Updated changelog * Fixed compilation issue * Added custom pass API test scene * Begin to add custom pass override test * Factorized protection function * Update custom pass test scene * Fixed custom pass API doc * Begin to add camera override tests * Fixed camera override in scene view * Finished RenderFrom API fucntions * Fixed XR disable class * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations * Finished to fix the RenderFrom* functions * Moved obsolete execute function into the new one * Update reference images * Added all the API doc * Updated changelog * revert mats * Updated custom clear pass to use the new API * Fixed depth buffer random read/write error * Disable custom pass blur test part * Revert camera pixel rect changes * Rename multi-pass to single pass * Disable custom pass test on vulkan and XR Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix line that got lost in merge (#729) * Porting console fixes to staging (#699) * Path tracer: added support for transparency on the Unlit shader. (#717) * Added support for transparency in Unlit. * Updated Changelog. * Update capture for 5007_PathTracing Unlit Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor related fixes (#730) * Fixes for the compositor test * Enable the compoositor test in build settings * Avoid gc alloc, hide internal components from vomume menu * Vulkan and DX12 screens, adjust compositor UI refresh * Fixed a vulkan and metal warning in the SSGI compute shader. (#715) * - Fixed a vulkan and metal warning in the SSGI compute shader. * - Fixed an exception due to the color pyramid not allocated when SSGI is enabled. - Fixed an issue with the first depth history mip was incorrectly copied. * Fix path traced DoF focusing issue (#732) * Remove mip padding from PlanarReflectionProbeCache.cs * Disable 9702 test nor working + 9041 XR (instable) * Hdrp/pt pass no bsdf data (#710) * Removed direct use of BSDFData in path tracing pass. * Updated changelog. * Fixed float3 typo... * fix metal 9800 reference screnshots * update meta file and testcasefilter * Pre warm RT Handle system so that reallocations are reduced. (#713) * Pre warm rt handle system and initialize to screen width/height * changelog * not all was pushed Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fixes for Graphics tests with Render Graph (#725) * WIP for enabling valid graphics tests with Render Graph. Fixed a lot of gcalloc. * Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled. * First batch of disabled tests. * Fixed decal rendering * Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral) * Revert "First batch of disabled tests." This reverts commit 505924b6967041787c0698b4ede1d158686f990e. * Temp "texture not bound" error fix until bloom is implemented. * Fixed an error when using a stale invalid renderer list handle. Reduced error message spam when encountering an execution error. * Add some debug info to compiled passes and removed wrong refCount++ on passes. * Added possibility to disallow pass pruning Fixed a number of pass pruning issues. * Small fixes * temporarily removed pruning of passes without product * Fixed HDRP asset for test 5009 * Implement alpha copy for post processes * Small render graph error fix for motion vector pass. * Disabled for render graph tests that are currently broken. * Updated yamato with new render graph configurations * Fixed lens distortion * Reenabled 4021 * Revert "Reenabled 4021" This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64. * Revert "Updated yamato with new render graph configurations" This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9. * Revert "Disabled for render graph tests that are currently broken." This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026. * Reverted HDRP test framework files (will go to another PR) * Revert "Fixed HDRP asset for test 5009" This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fix and improvements for ray traced effects (#597) * Adding a minimal lit used for RTGI in peformance mode Dispatch binned rays in 1D instead of 2D Fix an issue with the half resolution Mode for RTGI Only read the geometric attributes that are required using the share pass info and shader graph defines Fix an issue with the color intensity of emissive for performance rtgi * Correct bug with shadow history rejection * reduce the exponential accumulation value a bit Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Procedural metering mask that follows target (#723) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * start of procedural mask * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * Some basic version of procedural working * need to switch branch * Exposure target and threshold. * fix merge mess * Fixes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Added presets quality settings for RTAO and RTGI. (#724) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue in HDRaytracingIndirectDiffuse * fix shader warning in exposure * Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648) * - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). * Simplifying the culling override. * Update 708_ShadowExtendedCulling.png Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Removed reference image for player (unused) in HDRP Test * Update preview naming (#753) * Cloud layer volume override (#461) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * CloudLayer HDRI * CloudLayer Gradient * CloudLayer Physically Based * Documentation * Add clouds to Static Lighting Sky * Fix spherical conversion * Fix procedural flow * Fix lat long and procedural flow * replace trig functions. Correct wind dir * sync with hdri flow * Renamed variables * Allow full sphere coverage for procedural flowmap * Added missing doc * Fix cloud reset and unrelated warnings in hdri sky shader * Try different blending method * Fixes + test another blending * Tint and intensity parameters. Fix static sky used by lightmapper * Added graphic test. Updated doc * Updated tests using a disabled static sky If a sky override is used for static lighting and is disabled in the volume, it is not used anymore * Update LocalAmbientOcclusionNoisy.asset * update linux screenshots * Update CloudLayer.cs * update OSX screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Introduce LightLoop output structure (#754) * Add concept of LightLoop Output * update upgrade guide * Update Upgrading-from-2020.1-to-2020.2.md * update upgrade guide * Fix lightloop-output (#755) * Fix rendering when XrMaxViews is different than 2 (#733) * Use a fixed size for xr related fields in cbuffers * changelog * Update local shader config * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Improve transition between LOD for lit and layeredLit tessellation (#517) * Forest scale for tessellation change * Forest scale for tessellation change * Update Upgrading-from-2019.3-to-2020.1.md * Update Upgrading-from-2019.3-to-2020.1.md * fix ray tracing with XR single-pass (#769) * Revert "fix ray tracing with XR single-pass (#769)" This reverts commit 3e366334444febf450568b47ada2c00e4164ba12. * reviewed new additions to 2019.3 - 2020.1 and 2020.1 - 2020.2 upgrade guides (#766) * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Initial implementation for the new planar reflection filtering (#337) * Initial implementation for the new planar reflection filtering * Small improvement and "proper" support of oblique projection * quality improvement to the filtering. * Update PlanarReflectionFiltering.compute * review corrections * Update planar filter for all material (was not replaced) + update screenshots * Update IBLFilterGGX.cs * fix shader warning on vulkan * update references screenshots * Fixes for the plane normal and number of mips to be computed * Fix shift that was to the right in the blurred version * update references screenshots * fix shader warning * Some cleanup * change to fast Atan Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fast memory support (#772) * temp, gonna revert this, but have to merge staging. * again, need to switch branch, nothing functional * ESRAM support * changelog * Add guards * Standard terrain upgrader (#762) * Add render graph specific pipeline to HDRP tests. (#728) * Added an option to ignore tests when render graph is enabled. * Disabled for render graph tests that are currently broken. * Reenabled 4021 * Updated yamato script to add the RenderGraph pipeline. * Fixed HDRP asset for test 5009 * Revert unrelated yml files changes due to old configuration (#714) * Fixed an issue with not unregistering render graph debug. Disabled test 9401 for render graph after merge conflict. * Disabled 9800 for render graph * Revert hdrp asset for 5009 Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> * Added CPU and GPU timings for ray tracing effects. (#774) * Added CPU and GPU timings for ray tracing effects. * Only displaying the counters if ray tracing is supported on the asset. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Workaround for GetKernelThreadGroupSizes returning wrong data (#760) * Hard code group size * changelog * Add comment * Fixed the distanced based denoising being exposed for area lights (1251558). (#782) * Fix test project * Fix an issue with Fast memory code trying to access deleted resources when rendergraph is enabled (#791) * Fix issue accessing already released targets for rendergraph * changelog * Sanitize transparent motion vectors setting (#761) * Sanitize transparent motion vectors setting * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Revert "Add render graph specific pipeline to HDRP tests. (#728)" This reverts commit 4bcb4364fdd24a7d3205b46a5ce0ed63fe63cb5e. * Increased path tracing roughness range. (#763) * Increased path tracing roughness range. * Updated failing tests reference images. * Update Upgrading-from-2020.1-to-2020.2.md (#798) * Force post process parent setting to be before child settings (#799) * Force post process parent setting to be before child * changelog * Fix exposure white flash when enabling SSGI or SSR (#801) * Inform post process that history have been nuked * changelog * Various fixes related to SSGI and RTGI (#803) * Added support to combine RTSSS and RTGI The ray traced indrect diffuse and RTGI were combined wrongly with the rest of the lighting. Fixed an exception happening when using RTSSS without using RTShadows Changing the default SSGI radius for the all configurations Update screenshots for GI scenes * changelog update * [Draft] Lighting/probevolumes cleanup (#756) * Simplify EvaluateProbeVolumes interface and builtin SampleBakedGI code * Fix clearing of uninitialized GI * Added ProbeVolumesEncodingMode to ShaderOptions in ShaderConfig to allow users to configure their project to store and sample probe volumes as SH0 terms, SH1 terms, or SH2 terms, for different performance / quality tradeoffs. Data pipeline for this seems to be working now (though only properly verified with SH1 at the moment). Next step is to update sampling / evaluation code to handle SH0, and SH2 variants. * Probe Volumes: SH0, SH1, and SH2 evaluation based on ShaderConfig fully working now. Lots of additional cleanup tasks as well. * Probe Volumes: Instead of specifying AtlasWidth, AtlasHeight and AtlasDepth for probe volume atlas on HDRenderPipelineAsset, have user simply specify AtlasResolution and use for all axes. Same treatment for AtlasOctahedralDepth. * Probe Volumes: HDRenderPipelineAsset: Add memory usage information to UI and ensure we never allocate the ProbeVolumeAtlas or OctahedralDepthAtlas to be larger than k_MaxCacheSize * Probe Volumes: Bugfix for Probe Volume UI: Only display Additive blendmode warning if additive blend support is disabled in ShaderConfig * Probe Volumes: Bugfix: DataIsAssigned function needed in build as well. * Probe Volumes: Accumulate SH coefficients, and evaluate SH at normal after accumulation. This allows us to avoid 2x accumulations, 1 for forward normal, and 1 for backward (transmission) normal. Light loop mode is tooled up to do single evaluation. Material Pass mode still accumulates twice, because SampleBakedGI() is called twice. Need to modify SampleBakedGI() signature to take both normals and internally accumulate front and back lighting. * Probe Volumes: Rename EvaluateProbeVolumes() to AccumulateProbeVolumes() to make it clear that evaluation happens in a following EvaluateProbeVolumeCoefficients() function. * Probe Volumes: Major cleanup to AccumulateProbeVolumes(), pulling out the majority of the logic into self contained supporting functions. * Probe Volumes: Add ShaderConfig.s_ProbeVolumesBilaterialFilteringMode and strip out octahedral depth logic and memory allocations when not in use. * Probe Volumes: Do not allocate or bake octahedral depth data in ProbeVolumeAsset if ShaderConfig does not enable octahedral depth bilateral filtering. * Probe Volumes: Always allocate and pass octahedralDepth array into GetAdditionalBakedProbes() because the API call without the octahedralDepth argument has been flagged as obsolete. In the future, we should remove this unnecessary allocation. * Probe Volumes: Explicit ProbeVolumeAccumulateSphericalHarmonicsL0, L1, and L2 variants exist so we can choose to sample any order we want in any atlas configuration. i.e: sample L0 for vfx with L2 atlas. Upsampling is lossy, but supported, i.e: sample L2 in L0 atlas. Atlas coefficient layout was changed to accomodate this, and ProbeVolumeAccumulate function was moved to its own include so that each order variant can be generated with the preprocessor. * Probe Volumes: Add simple method for configuring what order of SH Probe Volumes is sampled at per shader (via a define before include). * Probe Volumes: Fix to ProbeVolumeUI string names * Probe Volumes: Move LightLoop::CreateBoxVolumeDataAndBound out parameters to end of args to match HDRP convention. * Probe Volumes: Remove redundant include from DebugDisplayProbeVolume.shader * Probe Volumes: Only support SH1 and SH2 atlas (SH0 was not needed). Change / cleanup payload data layout. Now SH0 and SH1 terms are stored in one float array, and SH2 quadratic terms are stored in seperate float array. This allows us to always bake and serialize SH2, but conditionally upload only SH0 and SH1 terms if user only requests SH1 atlas. This will also make it easier for SH2 terms to be stripped from the build in the future. * Probe Volumes: Wrap supporting accumulation, evaluation, and fallback function calls into ProbeVolumeEvaluateSphericalHarmonics() function to hide static branches around SH order from LightLoop and SampleBakedGI. * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Probe Volumes: Fix DebugViewTiles shader after updates to ProbeVolumeGetCountAndStart() * Probe Volumes: Set ShaderConfig evaluation mode to be disabled by default. * Probe Volumes: Update EvaluateOctahedralDepth function name to match surrounding code convention. * Probe Volumes: Fix up ShaderVariablesGlobal after naming conflict from pulling in lastest. Co-authored-by: Tobias Alexander Franke <tobias@unity3d.com> Co-authored-by: pastasfuture <pastasfuture@gmail.com> * update DXR Test project * Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#788) * Allow camera only transparent motion vectors * Changelog * revert old way of doing it. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Made VT settings classes internal rather than private/public (#805) Co-authored-by: Nico Leyman <Nicolas@GraphineSoftware.com> * update test filter * fix shad variables globals after merge * Update ShaderVariablesGlobal.cs.hlsl * Update LightingDebug.cs.hlsl * Fix reflection probe framesettings override (#796) * Fix reflection probe framsettings override * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix artifacts in volumetric lighting near opaque geometry (#493) * Add view bias to volumetrics * Implement geometry-distance-aware volume rendering * Comment * Fix the flickering issue * Clean * Fix * Changelog * Implement lookup bias for volumetrics * Update CHANGELOG.md * update test filter * fix refernce screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed WRITE_NORMAL_BUFFER macro redefinition and generated interpolators in ShadowCaster and META pass (#816) * update reference screenshots * Hdrp/fix/cookie area light update (#828) * Fixed area light cookie not used when a spot cookie is assigned * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with dynamic resolution and CAS + issue with dynamic resolution updating while not in playmode (#827) * Make sure update of dynamic res happens only in game view and not when playing. * changelog * Allow forced res to still be valid while not playing Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Fix raytracing keyword & static render state leak (#829) * Fix raytracing keyword value * Fix static render state being modified and causing side effects * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow (#823) * specular color needs to be weighted back with the blend factor. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update HDShaderPasses.cs * Add custom post process before TAA injection point (#817) * Added custom post process before TAA injection point * Updated custom pp graphic test * Added before TAA post process in HDRP default settings * Re-enabling the bloom test (#809) * Re-enabling the bloom test * Moving the test at the proper position Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fix depth pyramid issues with dynamic resolution (#806) * Recompute the mip info before generating the mipchain * changelog * avoid compute mipchain if not needed Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix decal being duplicated in prefab isolation mode. (#789) * Fixed decals being duplicated in prefab isolation mode. * Update changelog. * Fix decals in the player. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed an issue where rendering preview with MSAA might generate render graph errors. (#800) * Fixed an issue where rendering preview with MSAA might generate render graph errors. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile issue on PS4 for PlanarReflectionFiltering.compute (#830) * Fix compile issue for PS4. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue * IES Light Support (Point, Spot & Rectangular Lights) (#459) * IES Importe & Generate 2D/Cube/Equirectangular Textues * Enable PreviewGUI for IES Light, Split Core & HDRP * IES Point sampling enable Octahedral * missing file * spaces * for test * Cut of push Yamato generation * Wrong merge: Missing file * Missing file * wip * Octahedral Tilling * Cleaner & introduce IESObject * missing dead code * Allow only Power of 2 textures, update when resize * Clean code, + change log + Area Light * remove useless code * minor update * Merge * Cleanup * Remove useless log * Unify code + cleanup * Update documentation * Disable IES for Directionnal Lights * Fix when we update the spot angle baked * Update documentation & rename UI * com * Fix error for Area/Rectangular lights * Minor typo + move internal (WIP) * minor * minor * fix Pyramid + Box light & Add support of IES for them * Unreachable code fix * fix HDRPTest for Box lights * Add missing public doc * Last missing doc issues - fix * Remove all CGAlloc; Remove IES + Cookie for emissive mesh of area light(+Update doc) * Remove useless code, typo * Update versions in manifests (#647) * update manifests * Update manifest.json * update hdrp runtime [skip ci] * update testing packages [skip ci] * remove unused references * Update reference to support octahedral for animated texture * Update GI Support (HDRP Test valid) * Update image reference * Add migration message for Cookies * Fix message * Typo in light-component.md * Forgot an "and" * Typo in display emissive mesh property * Update documentation to clarify the case for light baking + IES cases * Switch from slider to ComboBox for IES Resolution * Rewording sentence on cookie/ies baking tooltip * Used same sentence from elsewhere for coherence * Fix compilation issue after merge * Update Vulkan reference images * Update OSX Metal reference image for CubeCookie * Formating, type & convention * Formating & code convention * Fix warning message * Update upgrading 2020.1 to 2020.2 doc * Update light loop for fetching * Update Upgrading-from-2020.1-to-2020.2.md * Update Upgrading-from-2020.1-to-2020.2.md * Update LightCookieManager.cs * Update HDRenderPipelineAsset.Migration.cs * Fix DXR Text * Fix Yamato XR * update reference screenshots * update reference screenshots * fix for Yamato OSXEditor/Metal Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> * Revert "Re-enabling the bloom test (#809)" This reverts commit cc9a6498c9213174f27b14d5aa5f081667346d99. * Update reference screenshots for IES * fix shader warning in DepthTAA.shader * Update 2313_Shadow_Mask_Spotlight_Shapes.unity * Update VFX reference screenshots * Update 4060_CustomPostProcess.unity * Update HDSRP_ Test reference screenshots * Update TestCaseFilters.asset Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Evgenii <evgenii@unity3d.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: pastasfuture <pastasfuture@gmail.com> Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> Co-authored-by: Tobias Alexander Franke <tobias@unity3d.com> Co-authored-by: NicoLeyman <49522355+NicoLeyman@users.noreply.github.com> Co-authored-by: Nico Leyman <Nicolas@GraphineSoftware.com> Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com>

* Add missing docs attributes (#271) * Fixed an error about procedural sky being logged by mistake. (#273) * Fixed an error about procedural sky being logged by mistake. * Update changelog * Fix quality settings UI and shadow mask UI (#122) * Update HDRenderPipeline.cs * Update HDRenderPipeline.cs * Update CHANGELOG.md * Update HDRenderPipeline.cs * fix typo * fix typo 2 * Updated raytracing async compute warning. (#274) * Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a null ref exception in static sky when the default volume profile is invalid. (#278) * Fixed a null ref exception in static sky when the default volume profile is invalid. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added SubScenes cache to be compatible with HDRP/staging (#287) * Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window. * Update changelog * Fix Unlit.template in shadergraph (#637) * Remove unused unlitpass.template * Update Lit.hlsl * re-add unlit pass * Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609) * - Fixed a bug where the light list is not cleared but still used when resizing the RT. * add changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram view improvements (#589) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * print exposure values in debug view * commit but it is nothing, need to switch branch * Add option to center histogram around exposure (fixed tonemap curve) * change color of text * fixup debug display merge issue * fixup merge issues * fixup issue with tonemap curve Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 9702_CustomPass_API.png.meta * Fix warning (#663) * add shader macros for XR single-pass (#687) * Adding 2 SG Pathtracer test scenes (#624) * New unlit pt scene * Add scene for PT Lit * Removing collider from the meshes * Renaming * Adding screenshots for PT scenes * Changing threshold for SSS deferred tests for stability * updating screenshot after staging being merged * Slightly increasing threshold for 5007 and 902 unlit scenes Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Render Graph Unit Tests (#607) * Render Graph Unit test WIP Fixed pruning of passes with no output. * Render Graph tests WIP * Increase max limit in UX of lights (#702) * Raise the max for lights * Update CHANGELOG.md * Fix null reference in volume debug menu (#705) * Update reference image for "502_RecursiveRenderingDisabled" (#704) * Update screenshot for 502 recursive rendering disabled test scene * upgrade shader material * Fix transparent movec scene view (#698) * Disable transparent movec when object motion vectors are disabled * changelog * Port (#599) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass API part 2 (#227) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Added the API to override camera rendering * Updated changelog * Updated changelog * Fixed compilation issue * Added custom pass API test scene * Begin to add custom pass override test * Factorized protection function * Update custom pass test scene * Fixed custom pass API doc * Begin to add camera override tests * Fixed camera override in scene view * Finished RenderFrom API fucntions * Fixed XR disable class * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations * Finished to fix the RenderFrom* functions * Moved obsolete execute function into the new one * Update reference images * Added all the API doc * Updated changelog * revert mats * Updated custom clear pass to use the new API * Fixed depth buffer random read/write error * Disable custom pass blur test part * Revert camera pixel rect changes * Rename multi-pass to single pass * Disable custom pass test on vulkan and XR Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix line that got lost in merge (#729) * Porting console fixes to staging (#699) * Path tracer: added support for transparency on the Unlit shader. (#717) * Added support for transparency in Unlit. * Updated Changelog. * Update capture for 5007_PathTracing Unlit Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor related fixes (#730) * Fixes for the compositor test * Enable the compoositor test in build settings * Avoid gc alloc, hide internal components from vomume menu * Vulkan and DX12 screens, adjust compositor UI refresh * Fixed a vulkan and metal warning in the SSGI compute shader. (#715) * - Fixed a vulkan and metal warning in the SSGI compute shader. * - Fixed an exception due to the color pyramid not allocated when SSGI is enabled. - Fixed an issue with the first depth history mip was incorrectly copied. * Fix path traced DoF focusing issue (#732) * Remove mip padding from PlanarReflectionProbeCache.cs * Disable 9702 test nor working + 9041 XR (instable) * Hdrp/pt pass no bsdf data (#710) * Removed direct use of BSDFData in path tracing pass. * Updated changelog. * Fixed float3 typo... * fix metal 9800 reference screnshots * update meta file and testcasefilter * Pre warm RT Handle system so that reallocations are reduced. (#713) * Pre warm rt handle system and initialize to screen width/height * changelog * not all was pushed Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fixes for Graphics tests with Render Graph (#725) * WIP for enabling valid graphics tests with Render Graph. Fixed a lot of gcalloc. * Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled. * First batch of disabled tests. * Fixed decal rendering * Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral) * Revert "First batch of disabled tests." This reverts commit 505924b6967041787c0698b4ede1d158686f990e. * Temp "texture not bound" error fix until bloom is implemented. * Fixed an error when using a stale invalid renderer list handle. Reduced error message spam when encountering an execution error. * Add some debug info to compiled passes and removed wrong refCount++ on passes. * Added possibility to disallow pass pruning Fixed a number of pass pruning issues. * Small fixes * temporarily removed pruning of passes without product * Fixed HDRP asset for test 5009 * Implement alpha copy for post processes * Small render graph error fix for motion vector pass. * Disabled for render graph tests that are currently broken. * Updated yamato with new render graph configurations * Fixed lens distortion * Reenabled 4021 * Revert "Reenabled 4021" This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64. * Revert "Updated yamato with new render graph configurations" This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9. * Revert "Disabled for render graph tests that are currently broken." This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026. * Reverted HDRP test framework files (will go to another PR) * Revert "Fixed HDRP asset for test 5009" This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fix and improvements for ray traced effects (#597) * Adding a minimal lit used for RTGI in peformance mode Dispatch binned rays in 1D instead of 2D Fix an issue with the half resolution Mode for RTGI Only read the geometric attributes that are required using the share pass info and shader graph defines Fix an issue with the color intensity of emissive for performance rtgi * Correct bug with shadow history rejection * reduce the exponential accumulation value a bit Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Procedural metering mask that follows target (#723) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * start of procedural mask * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * Some basic version of procedural working * need to switch branch * Exposure target and threshold. * fix merge mess * Fixes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Added presets quality settings for RTAO and RTGI. (#724) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue in HDRaytracingIndirectDiffuse * fix shader warning in exposure * Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648) * - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). * Simplifying the culling override. * Update 708_ShadowExtendedCulling.png Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Removed reference image for player (unused) in HDRP Test * Update preview naming (#753) * Cloud layer volume override (#461) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * CloudLayer HDRI * CloudLayer Gradient * CloudLayer Physically Based * Documentation * Add clouds to Static Lighting Sky * Fix spherical conversion * Fix procedural flow * Fix lat long and procedural flow * replace trig functions. Correct wind dir * sync with hdri flow * Renamed variables * Allow full sphere coverage for procedural flowmap * Added missing doc * Fix cloud reset and unrelated warnings in hdri sky shader * Try different blending method * Fixes + test another blending * Tint and intensity parameters. Fix static sky used by lightmapper * Added graphic test. Updated doc * Updated tests using a disabled static sky If a sky override is used for static lighting and is disabled in the volume, it is not used anymore * Update LocalAmbientOcclusionNoisy.asset * update linux screenshots * Update CloudLayer.cs * update OSX screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Introduce LightLoop output structure (#754) * Add concept of LightLoop Output * update upgrade guide * Update Upgrading-from-2020.1-to-2020.2.md * update upgrade guide * Fix lightloop-output (#755) * Fix rendering when XrMaxViews is different than 2 (#733) * Use a fixed size for xr related fields in cbuffers * changelog * Update local shader config * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Improve transition between LOD for lit and layeredLit tessellation (#517) * Forest scale for tessellation change * Forest scale for tessellation change * Update Upgrading-from-2019.3-to-2020.1.md * Update Upgrading-from-2019.3-to-2020.1.md * fix ray tracing with XR single-pass (#769) * Revert "fix ray tracing with XR single-pass (#769)" This reverts commit 3e366334444febf450568b47ada2c00e4164ba12. * reviewed new additions to 2019.3 - 2020.1 and 2020.1 - 2020.2 upgrade guides (#766) * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Initial implementation for the new planar reflection filtering (#337) * Initial implementation for the new planar reflection filtering * Small improvement and "proper" support of oblique projection * quality improvement to the filtering. * Update PlanarReflectionFiltering.compute * review corrections * Update planar filter for all material (was not replaced) + update screenshots * Update IBLFilterGGX.cs * fix shader warning on vulkan * update references screenshots * Fixes for the plane normal and number of mips to be computed * Fix shift that was to the right in the blurred version * update references screenshots * fix shader warning * Some cleanup * change to fast Atan Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fast memory support (#772) * temp, gonna revert this, but have to merge staging. * again, need to switch branch, nothing functional * ESRAM support * changelog * Add guards * Standard terrain upgrader (#762) * Add render graph specific pipeline to HDRP tests. (#728) * Added an option to ignore tests when render graph is enabled. * Disabled for render graph tests that are currently broken. * Reenabled 4021 * Updated yamato script to add the RenderGraph pipeline. * Fixed HDRP asset for test 5009 * Revert unrelated yml files changes due to old configuration (#714) * Fixed an issue with not unregistering render graph debug. Disabled test 9401 for render graph after merge conflict. * Disabled 9800 for render graph * Revert hdrp asset for 5009 Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> * Added CPU and GPU timings for ray tracing effects. (#774) * Added CPU and GPU timings for ray tracing effects. * Only displaying the counters if ray tracing is supported on the asset. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Workaround for GetKernelThreadGroupSizes returning wrong data (#760) * Hard code group size * changelog * Add comment * Fixed the distanced based denoising being exposed for area lights (1251558). (#782) * Fix test project * Fix an issue with Fast memory code trying to access deleted resources when rendergraph is enabled (#791) * Fix issue accessing already released targets for rendergraph * changelog * Sanitize transparent motion vectors setting (#761) * Sanitize transparent motion vectors setting * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Revert "Add render graph specific pipeline to HDRP tests. (#728)" This reverts commit 4bcb4364fdd24a7d3205b46a5ce0ed63fe63cb5e. * Increased path tracing roughness range. (#763) * Increased path tracing roughness range. * Updated failing tests reference images. * Update Upgrading-from-2020.1-to-2020.2.md (#798) * Force post process parent setting to be before child settings (#799) * Force post process parent setting to be before child * changelog * Fix exposure white flash when enabling SSGI or SSR (#801) * Inform post process that history have been nuked * changelog * Various fixes related to SSGI and RTGI (#803) * Added support to combine RTSSS and RTGI The ray traced indrect diffuse and RTGI were combined wrongly with the rest of the lighting. Fixed an exception happening when using RTSSS without using RTShadows Changing the default SSGI radius for the all configurations Update screenshots for GI scenes * changelog update * [Draft] Lighting/probevolumes cleanup (#756) * Simplify EvaluateProbeVolumes interface and builtin SampleBakedGI code * Fix clearing of uninitialized GI * Added ProbeVolumesEncodingMode to ShaderOptions in ShaderConfig to allow users to configure their project to store and sample probe volumes as SH0 terms, SH1 terms, or SH2 terms, for different performance / quality tradeoffs. Data pipeline for this seems to be working now (though only properly verified with SH1 at the moment). Next step is to update sampling / evaluation code to handle SH0, and SH2 variants. * Probe Volumes: SH0, SH1, and SH2 evaluation based on ShaderConfig fully working now. Lots of additional cleanup tasks as well. * Probe Volumes: Instead of specifying AtlasWidth, AtlasHeight and AtlasDepth for probe volume atlas on HDRenderPipelineAsset, have user simply specify AtlasResolution and use for all axes. Same treatment for AtlasOctahedralDepth. * Probe Volumes: HDRenderPipelineAsset: Add memory usage information to UI and ensure we never allocate the ProbeVolumeAtlas or OctahedralDepthAtlas to be larger than k_MaxCacheSize * Probe Volumes: Bugfix for Probe Volume UI: Only display Additive blendmode warning if additive blend support is disabled in ShaderConfig * Probe Volumes: Bugfix: DataIsAssigned function needed in build as well. * Probe Volumes: Accumulate SH coefficients, and evaluate SH at normal after accumulation. This allows us to avoid 2x accumulations, 1 for forward normal, and 1 for backward (transmission) normal. Light loop mode is tooled up to do single evaluation. Material Pass mode still accumulates twice, because SampleBakedGI() is called twice. Need to modify SampleBakedGI() signature to take both normals and internally accumulate front and back lighting. * Probe Volumes: Rename EvaluateProbeVolumes() to AccumulateProbeVolumes() to make it clear that evaluation happens in a following EvaluateProbeVolumeCoefficients() function. * Probe Volumes: Major cleanup to AccumulateProbeVolumes(), pulling out the majority of the logic into self contained supporting functions. * Probe Volumes: Add ShaderConfig.s_ProbeVolumesBilaterialFilteringMode and strip out octahedral depth logic and memory allocations when not in use. * Probe Volumes: Do not allocate or bake octahedral depth data in ProbeVolumeAsset if ShaderConfig does not enable octahedral depth bilateral filtering. * Probe Volumes: Always allocate and pass octahedralDepth array into GetAdditionalBakedProbes() because the API call without the octahedralDepth argument has been flagged as obsolete. In the future, we should remove this unnecessary allocation. * Probe Volumes: Explicit ProbeVolumeAccumulateSphericalHarmonicsL0, L1, and L2 variants exist so we can choose to sample any order we want in any atlas configuration. i.e: sample L0 for vfx with L2 atlas. Upsampling is lossy, but supported, i.e: sample L2 in L0 atlas. Atlas coefficient layout was changed to accomodate this, and ProbeVolumeAccumulate function was moved to its own include so that each order variant can be generated with the preprocessor. * Probe Volumes: Add simple method for configuring what order of SH Probe Volumes is sampled at per shader (via a define before include). * Probe Volumes: Fix to ProbeVolumeUI string names * Probe Volumes: Move LightLoop::CreateBoxVolumeDataAndBound out parameters to end of args to match HDRP convention. * Probe Volumes: Remove redundant include from DebugDisplayProbeVolume.shader * Probe Volumes: Only support SH1 and SH2 atlas (SH0 was not needed). Change / cleanup payload data layout. Now SH0 and SH1 terms are stored in one float array, and SH2 quadratic terms are stored in seperate float array. This allows us to always bake and serialize SH2, but conditionally upload only SH0 and SH1 terms if user only requests SH1 atlas. This will also make it easier for SH2 terms to be stripped from the build in the future. * Probe Volumes: Wrap supporting accumulation, evaluation, and fallback function calls into ProbeVolumeEvaluateSphericalHarmonics() function to hide static branches around SH order from LightLoop and SampleBakedGI. * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Probe Volumes: Fix DebugViewTiles shader after updates to ProbeVolumeGetCountAndStart() * Probe Volumes: Set ShaderConfig evaluation mode to be disabled by default. * Probe Volumes: Update EvaluateOctahedralDepth function name to match surrounding code convention. * Probe Volumes: Fix up ShaderVariablesGlobal after naming conflict from pulling in lastest. Co-authored-by: Tobias Alexander Franke <tobias@unity3d.com> Co-authored-by: pastasfuture <pastasfuture@gmail.com> * update DXR Test project * Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#788) * Allow camera only transparent motion vectors * Changelog * revert old way of doing it. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Made VT settings classes internal rather than private/public (#805) Co-authored-by: Nico Leyman <Nicolas@GraphineSoftware.com> * update test filter * fix shad variables globals after merge * Update ShaderVariablesGlobal.cs.hlsl * Update LightingDebug.cs.hlsl * Fix reflection probe framesettings override (#796) * Fix reflection probe framsettings override * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix artifacts in volumetric lighting near opaque geometry (#493) * Add view bias to volumetrics * Implement geometry-distance-aware volume rendering * Comment * Fix the flickering issue * Clean * Fix * Changelog * Implement lookup bias for volumetrics * Update CHANGELOG.md * update test filter * fix refernce screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed WRITE_NORMAL_BUFFER macro redefinition and generated interpolators in ShadowCaster and META pass (#816) * update reference screenshots * Hdrp/fix/cookie area light update (#828) * Fixed area light cookie not used when a spot cookie is assigned * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with dynamic resolution and CAS + issue with dynamic resolution updating while not in playmode (#827) * Make sure update of dynamic res happens only in game view and not when playing. * changelog * Allow forced res to still be valid while not playing Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Fix raytracing keyword & static render state leak (#829) * Fix raytracing keyword value * Fix static render state being modified and causing side effects * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow (#823) * specular color needs to be weighted back with the blend factor. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update HDShaderPasses.cs * Add custom post process before TAA injection point (#817) * Added custom post process before TAA injection point * Updated custom pp graphic test * Added before TAA post process in HDRP default settings * Re-enabling the bloom test (#809) * Re-enabling the bloom test * Moving the test at the proper position Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fix depth pyramid issues with dynamic resolution (#806) * Recompute the mip info before generating the mipchain * changelog * avoid compute mipchain if not needed Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix decal being duplicated in prefab isolation mode. (#789) * Fixed decals being duplicated in prefab isolation mode. * Update changelog. * Fix decals in the player. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed an issue where rendering preview with MSAA might generate render graph errors. (#800) * Fixed an issue where rendering preview with MSAA might generate render graph errors. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile issue on PS4 for PlanarReflectionFiltering.compute (#830) * Fix compile issue for PS4. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue * IES Light Support (Point, Spot & Rectangular Lights) (#459) * IES Importe & Generate 2D/Cube/Equirectangular Textues * Enable PreviewGUI for IES Light, Split Core & HDRP * IES Point sampling enable Octahedral * missing file * spaces * for test * Cut of push Yamato generation * Wrong merge: Missing file * Missing file * wip * Octahedral Tilling * Cleaner & introduce IESObject * missing dead code * Allow only Power of 2 textures, update when resize * Clean code, + change log + Area Light * remove useless code * minor update * Merge * Cleanup * Remove useless log * Unify code + cleanup * Update documentation * Disable IES for Directionnal Lights * Fix when we update the spot angle baked * Update documentation & rename UI * com * Fix error for Area/Rectangular lights * Minor typo + move internal (WIP) * minor * minor * fix Pyramid + Box light & Add support of IES for them * Unreachable code fix * fix HDRPTest for Box lights * Add missing public doc * Last missing doc issues - fix * Remove all CGAlloc; Remove IES + Cookie for emissive mesh of area light(+Update doc) * Remove useless code, typo * Update versions in manifests (#647) * update manifests * Update manifest.json * update hdrp runtime [skip ci] * update testing packages [skip ci] * remove unused references * Update reference to support octahedral for animated texture * Update GI Support (HDRP Test valid) * Update image reference * Add migration message for Cookies * Fix message * Typo in light-component.md * Forgot an "and" * Typo in display emissive mesh property * Update documentation to clarify the case for light baking + IES cases * Switch from slider to ComboBox for IES Resolution * Rewording sentence on cookie/ies baking tooltip * Used same sentence from elsewhere for coherence * Fix compilation issue after merge * Update Vulkan reference images * Update OSX Metal reference image for CubeCookie * Formating, type & convention * Formating & code convention * Fix warning message * Update upgrading 2020.1 to 2020.2 doc * Update light loop for fetching * Update Upgrading-from-2020.1-to-2020.2.md * Update Upgrading-from-2020.1-to-2020.2.md * Update LightCookieManager.cs * Update HDRenderPipelineAsset.Migration.cs * Fix DXR Text * Fix Yamato XR * update reference screenshots * update reference screenshots * fix for Yamato OSXEditor/Metal Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> * Revert "Re-enabling the bloom test (#809)" This reverts commit cc9a6498c9213174f27b14d5aa5f081667346d99. * Update reference screenshots for IES * fix shader warning in DepthTAA.shader * Update 2313_Shadow_Mask_Spotlight_Shapes.unity * Update VFX reference screenshots * Update 4060_CustomPostProcess.unity * Update HDSRP_ Test reference screenshots * Update TestCaseFilters.asset * Adding missing references image for HDRP 4038 (#856) * Adding Linux Vulkan, OSX Metal, Win D12, Win Vulkan ref image for 4038 bloom * Win D11 * Fix message for metal and ao (#859) * Add texture import preset to automatically apply to "ActualImages" (#861) * Fix issue with the blue line of prefab modifications for Volume mode (#860) * Fix blueline in prefab mode * changelog * Fixing the internsity being applied to RTAO too early leading to unexpected results (1254626). (#825) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * add color clear pass while rendering XR occlusion mesh to avoid leaks (#688) * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix (#865) * test manual fov computation * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix/shader stack normals (#852) * Fixed normal space in templates * Fix nullref in material inspector * Updated changelog * Added iris and coat normal spaces Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: TomasKiniulis <50582134+TomasKiniulis@users.noreply.github.com> Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Evgenii <evgenii@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: pastasfuture <pastasfuture@gmail.com> Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> Co-authored-by: Tobias Alexander Franke <tobias@unity3d.com> Co-authored-by: NicoLeyman <49522355+NicoLeyman@users.noreply.github.com> Co-authored-by: Nico Leyman <Nicolas@GraphineSoftware.com> Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com> Co-authored-by: RemyUnity <32760367+RemyUnity@users.noreply.github.com>

* Update 2002_Light_DynamicMix.unity (#292) * Update HDCubemapInspector.cs (#296) * increase tolerance for test 5008 in VR due to recent changes (#311) * Upate screenshot for HDRP DXR Test (#312) * Fix SSS code doc (#319) * Fix issue with screen-space shadows not enabled with RT off (#139) * Fix issue with screen_space shadows not enabled with RT off * Proper fix: only keep directional screen space shadows with RT off * Fix shadow debug mode * cosmetic changes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed a performance issue with stochastic ray traced area shadows. (#300) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix bad merge of the light loop optimization PR (an optimization was undone) (#321) * Don't compute light type * Typo * Camera override API (#170) * Added the API to override camera rendering * Updated changelog * Fixed compilation issue * Factorized protection function * Fixed camera override in scene view * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fixed camera override with dynamic resolution and moved it to internal Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix cookie srgb (#297) * Fixed srgb flag not updating the cookie atlas * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix flickering lighting in the scene and game view when lookdev is open. (#290) * Fixed flickering of the game/scene view when lookdev is running. * Update changelog. * Added a function to reset the reference size of RTHandle systems. (#299) * Added a function (HDRenderPipeline.ResetRTHandleReferenceSize) to reset the reference size of RTHandle systems. * Update changelog * Fix issue with ambient probe not being correct with OnEnable/OnDemand probes (#291) * render until ambient probe is ready * changelog * remove comment Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix Motion Vectors written by transparent when rendering with MSAA (#315) * Add resolve if needed of transparent movec * rename * rendergraph * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/reflection probe scale perf (#252) * Use IEnumerable as interface for HDProbeSystem * Added a perf test for probe registration * Use HashSet instead of List to store HDProbes * Updated planar reflection to use a HashSet * Updated changelog * Fix invalid length check * Fixed build of planar probe array * Fixed GC alloc issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [9.x.x] Axf measurements into tilings (#289) * AxF: Add support for physical material measurements import into tiling values (new importer feature) per texture resource. Also add offset support. On the importer side, an assumption of a unit of tangent space embedded in world space being 1 meter is used. For easier adjustments, all values are relative to a "Main Tiling" for the material. This removes old materialU/V tiling and flakes tiling (AxF is still in preview though). Update test scene to move old tiling property values into new properties so results don't change. Update documentation. * AxF measurements into tilings: Add changelog entry. * AxF tilings - Fix typo that could set wrong specular lobe and coat normal tilings. * Update the AlphaToMask test for AxF. * Update all other editor and player platform references to match. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * fix 9402screenshots on vulkan * Update HDRP graphic test framework with Test Broken / TestFilter script (#393) * Update hdrp testing framework * Update hdrp testing framework 2 * Update TestFilterGenerator.cs * revert change on shader graph * Hd/add layer modification on generated emissive mesh for area light (#364) * Add Layer modification of EmissiveMesh generated by area light Add Layer handling on Generated Emissive Mesh * Update CHANGELOG.md * Add "same as Light" hability for layer and make it default * Add destruction on move in hierarchy and retrieve existing to secure the NotEditable * Add sync on Static too * Also the copy the static drop down Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Disable async compute for D3D12 [Hold] (#301) * disable async on d3d12 * Change doc * Hd/fix nullref while removing decal component (#416) * fix nullref on DecalComponent removed from contextual menu * Update CHANGELOG.md * Added a flow map parameter to HDRI Sky (#44) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * Fix lat long and procedural flow * replace trig functions. Correct wind dir * Dropdown and upper hemisphere fix * Updated doc Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with Uber Post process shader when alpha is enabled (#422) * Fix issue with alpha being over 1 hence, leading to the final color being boosted due to alpha handling * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * replace fbx by the one from URP with no import errors (#427) * Fix the bug (#430) * Fix issue with corrupted values with Layer Lit when using multiply mode for vertex color (#418) * Saturate vertex color to avoid negative values. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Renamed variables (#436) * Fix issue with the resolve of motion vectors (#421) * Hd/fix targets used in ongui in decalcomponent (#413) * Fix Reset not resetting to default * Delay MaterialEditor recreation to when possible * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implemented ray traced reflections for transparent objects. (#47) * Implementation of ray traced reflections for transparent objects * fix issue with ShowPrePassAndPostPass * Change label for transparent SSR + change default value to false * fix material not setup properly Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix custom pass graphic tests (#359) * FIxed fullscreen custom pass test and re-enabled draw-renderers custom pass test * Replaced canvas by a quad (more stable for graphic test) * disable vulkan test as it is failing, need investigation Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Save scene-view camera settings in Editor prefs (#440) * Sceneview camera settings are now saved in Editor prefs * cosmetic changes * add comment * Small refactor to allow easily adding more prefs in the future * fix comment * fix comment 2 Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue when switching back to custom sensor type in physical camera (#417) * Fix issue when switching back to custom sensor type in physical camera * make if comparison more explicit * make if comparison more safe * Per-camera history for the custom settings using a static dictionary * Use ConditionalWeakTable instead of a Dictionary to avoid keeping alive deleted cameras Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix a null ref exception when running playmode tests (#360) * fix a null ref exception when running playmode tests with the render pipeline debug window opened * use empty array Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed some gcalloc in the debug window (#445) * Fixed some GCAlloc in the debug window * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update reference screenshot dx12 * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) (#443) * Fixed shader graphs not casting semi-transparent and color shadows (case 1242617) * Fix an issue with thin refraction SG and updating screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Create Shaders.meta * Hdrp/small ui update (#423) * Removed logic in the UI to disable parameters for contact shadows and fog volume components as it was going against the concept of the volume system. * Update changelog. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update settings for DXR * Update SetToCameraNearPlane.cs * Add an option to disable shadow bias * Don't query cull results if we don't have them (#449) * test with a guard * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update screenshot (#463) * Disable test HDRP_GraphicTestRunner.8105_BlendStates_b on DX12 * Update TestCaseFilters.asset * Revert "Disable async compute for D3D12 [Hold] (#301)" (#469) This reverts commit dc35b61d1d19ad1b363b8fbb582a076014e84b16. * Revert "Add an option to disable shadow bias" This reverts commit 2dfeab269baab914fd541f8fa358463d38334f6c. * PBR Sky renderer now shares its internal precomputation table between different instances. (#250) * PBR Sky renderer now shares its internal precomputation table between different instances. * Update changelog * Doc update Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Makes sure quaternion is normalized and valid before converting to ma… (#331) * Makes sure quaternion is normalized and valid before converting to matrix. * Updated Changelo. * Revert "Updated Changelo." This reverts commit 60e65b50f3ab7fc241556e1c8f46b680defe36e2. * Update CHANGELOG.md Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * New tooltip for camera background and fixed exposure when switching the background mode. (#415) * Put more information in Camera background type tooltip and fixed inconsistent exposure behavior when changing bg type. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue causing not all baked reflection probes to be deleted (#441) * Clear the queue once filled up and push elements that failed to be pushed. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed asset preview being rendered white because of static lighting sky. (#462) * Fixed an issue where asset preview could be rendered white because of static lighting sky. Also fixed an issue where static lighting was not updated when removing the static lighting sky profile. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed null reference exception in LookDev when setting the SRP to None (#447) * Fixed null reference exception in LookDev when setting the SRP to None * Review feedback * Review feedback 2 * Fix show cookie atlas debug mode (#475) * Fix the show cookie atlas debug mode not displaying correctly * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Enable DXR playmode test (#472) * Update upm-ci-hdrp_dxr.yml * add hdrp dxr playmode test to all hdrp ci * Update upm-ci-hdrp.yml * Update upm-ci-hdrp.yml * change planar atlas size to 1024 * Update upm-ci-hdrp.yml * Update 802_SubSurfaceScatteringForward.png * update scene * update 5001 lighting * fix exposure for 5001 path tracing test * update player screenshots * disable 5001 path tracing as it fail on yamato * Fix few multi-editing issues with Emission UI (#473) * Working but not nice * Remove unecessary cruft * tiny changes * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Re-enable cubemap thumbnail gen only for d3d11 (#487) * re-enable thumbnail gen only for d3d11 * Update changelog * try enable metal * Update changelog and comment * Check reflection probe null pointer before use. (case 1244047) (#456) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Remove max atlas probe alloc size in HDRP asset (#458) * Fixed max alloc planar size not taking in account the max cache size * Removed the max cache clamp on texture atlases * Hd/fix undo environmentlibrary lookdev (#490) * fix undo redo for environment library * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix vulkan test * SSGI Implementation (#95) Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Change Sky in 5001 PT Test to HDRI Sky + update image (#502) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 802_SubSurfaceScatteringForward.unity * fix vulkan warring and wrong meta * Update upm-ci-hdrp.yml * Fix merge issue with Test filter * Use path relative to package for depth of field (#523) * Use absolute paths for dof include * changelog * Fix Light overlap (#444) * Added the light overlap volume code * Updated changelog * Made outline thinner and removed the semi-transparent color of the light shape in light overlap debug mode * Fixed documentation Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed API breakage. (#524) * [Docs] Add missing documentation for Accumulation, AOVs, path-traced DoF (#532) * AOV documentation * minor change in the comments * Accumulation documentation * minor improvements * Rewrite the AOV script. Now it is stand-alone. * Typo * Add path traced DoF documentation * Reviewed AOV doc * Reviewed accumulation doc * Reviewed path-traced dof doc * Add missing OnDestroy in example script Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> * Restore some XR HDRP tests (#382) * restored XR tests * revert and split changes for temporal effects in another branch * fix XR tests using volumetrics * 8103 is still acting randomly * try to set timeout to 30s to confirm it's working * set timeout to 5 min per test for HDRP instead of default 3 min Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix taaFrameIndex and restore TAA tests for XR (#534) * fix taaFrameIndex and temporal effects with the test suite * increase waitFrames to 64 on the TemporalAA test scenes and enable XR compatibilty * update ref images * set waitFrames for HDRP runtime test scene * reset camera before waiting * update reference images from Yamato * revert change to 001-HDTemplate * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) (#488) * Fixed the sub surface mask not being taken into account when computing ray traced sub surface scattering (1247255) * Add missing inverse exposure multiplier * Add support for batchmode (#542) * Update 9301_MotionVectorsOff-Forward-Dynamic.png * Fix custom pass prefabs (#419) * Fix custom pass integration with prefabs * Updated changelog * Fixed prefab highlight not updated when adding/removing custom passes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Correctly dealloc/realloc resources when switching RenderGraph on and off. (#328) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * Reverted volumetric lighting changes and now render graph version uses the shared textures. * Clone in the Asset folder when the original volume profile is in a re… (#508) * Clone in the Asset folder when the original volume profile is in a read only package. (case 1154961) * Added changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Adding code for history rejection for SSGI and adding a disabled test that should be used (test framework doesn't support) (#529) * Custom Pass API (part 1) (#155) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Updated changelog * Added custom pass API test scene * Fixed custom pass API doc * Moved obsolete execute function into the new one * Updated custom clear pass to use the new API * Updated custom pass API test reference image * update reference screenshots * Fixed various scale issues in the blur custom pass API and updated reference screenshot * Disable custom pass API test because it's unstable Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Implement Constant Buffers for HDRP (part 3) (#98) * Fixed execution error without raytracing * Prepare Prepass refacto * Another round of preparation * Renamed XRPassScope to XRSinglePassScope * RenderAfterPostProcess is now static * Add AfterPostProcess to RenderGraph (WIP) * AfterPostProcess implementation * Fixed wrong RTHandle allocation * Fixed light layers texture binding during deferred lighting pass * Implemented Post Process Final Pass with RenderGraph * Post merge fixes * Fixed some issues with missing buffers in SSS and deferred lighting compute shaders. * Fixed alpha in post processes * Removed RenderGraphResource and RenderGraphMutableResource in favor of more explicit RendererListHandle and TextureHandle * Fixed decal normal patch pass * Fixed stencil resolve render pass * Fixed RenderDBuffer render pass function capturing variables. * Fixed wrong variable capture and restored ClearLightList to the render graph implementation of BuildGPULightList * Various fixes of things that diverged compared to regular path. * Unified renderer list and texture invalid handle error. * Revert wrong change * Added constant buffer hlsl generation * Changed UnityGlobal constant buffers to ShaderVariablesGlobals and generate it from C# * post merge fix * Removed useless comment. * Missing doc * Started moving cmd.SetGlobalXXX to update the global CB (WIP) * Implemented Volumetrics global CB and various fixes. * Implemented shadow global CB update. * Finished up Global Constant Buffer setup * Fix null ref * Fixed global constant buffer alignment issues. * Fixed shadows and SSS * Small ConstantBuffer API refacto * Small fix * Volumetric Constant Buffer implementation + Fix * Fix ambient occlusion * Removed redundant SetGlobalXXX * Light list build global CB implementation * Fixed path tracing frame index constant * Fixed ao constant w/ raytracing * Better path tracing fix. * Refactored CB API to comply with Render Graph specificities * Update test screenshot * Fixed constant buffer generation to use macros. * Implemented XR global constant buffer. * Removed useless global constant * Fixed XR global constant name * Converted SSR to constant buffer. * Converted AO to constant buffers. * Fixed warning * Removed some useless SetGlobalXXX in Light Cookie Manager * Converted debug display to use constant buffer. * Fixed color/depth pyramid debug * Cleanup * Implemented constant buffer for PBR sky global variables. * Warning fix * Small fix * Cleanup of global setup happening before rendering (render graph path or not). * Post merge fix * Added global constant buffer hlsl generation. * Post merge fix * Converted raytracing lightloop variables to constant buffer. * Converted RayTracing global variables to constant buffer. * Removed obsolete comment * Post merge fix * Post merge fix * Post merge fix 2 * Double inclusion fix. * Fixed CB visibility * Fixed compilation after the merge * Indentation fix * Removed temporary comments. * Moved some constants around. * Post merge fix + Port ProbeVolume global variables to constant buffers. * Fixed deallocation of constant buffers * Properly release Volumetric constant buffers. * Another update to CB API * Updated documentation. * Missing generated file * Post merge fix * Fixed various issues with light probe volumes. * Fixed light list build parameters and a nullref exception when probe volumes aren't enable and there are volumes in the scene. * Final fix for probe volumes * Fixed a warning in shader compilation * Changes from review feedback * Compilation fix. * Post merge fix * Removed useless constant * Crash fix * Post merge fix * Update 501_RecursiveRendering.png Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Hd/fix wizard defaultvolumeprofile creation (#565) * Fix Wizard check on default volume profile * Update CHANGELOG.md * Small TAA Anti-flicker changes (#555) * tweaks * Change default so that is just high quality. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix central depth sampling in TAA (#564) * Fix sampling of central depth * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Render Graph Async Compute (#552) * Handle deallocation/reallocation of resources when switching rendergraph on/off (WIP) * AO and Post Processes. * Prefixed all history buffers with camera name for readability in the memory profiler. * LIght volume debug and Volumetric (WIP) * Fixed volumetric * Fixed deallocation of SSS buffers * Review feedback fixes. * Init order fix for post process * WIP: refactoring of render graph compilation and resource allocation to prepare for async dependencies. * Implementation of async resource synchronization. * Fixed synchronization (only partial fix) * Added default profiling sampler for render graph passes not providing one. * Async WIP * Fixed async synchronization by extending lifetime of resources freed during async pass to the first graphics task that wait for async. * Post merge fix * Cleanup * Removed comment. * Disabled async contact shadows again. * Small cleanup * Change exposure compensation in the default volume profile to 0. (#388) * Change profile (And add missing setting) * changelog * Upgrade guide Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram guided auto-exposure + debug modes (#372) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * Review feedback * Bad merge fixup Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Refactor shadow caching system (#554) * Very debuggy code just start nothing functional or usable yet. * remove old cached stuff (not finished, need switch branch) * revert wrongful commit * A bit of restructuring * A good point as any to sync up * sync * Move from old repo... * fix regression * Handle case in which shadow doesn't fit * leftover not committed * Fix some issues with culling of point lights from the * preliminary support for cascaded shadows * Fix some issue with the directional * Subshadow update * Add some guards, some debug and the new C++ api for infinite bounds * Some UI for the resolution * Fix merge issues * Update debug cs.hlsl * Render graph stuff and some leftover removal * micro cleanup * Fix behaviour when defragging and excess lights are there * Public API * Remove dbg names * Bug on debug view of area atlas * Missing field on new PCSS signature for directional * More public API * Refresh cached shadows on resolution changes. * merge conflicts patchup * Fix missing shadows on normal shadows * Small cleanup and turning positive the doesn'tHavePlacement * Fix case on switching light type and issue with non-rectangle area lights * tentative fix for error on build * Debug logging * update naming of debug * Fix issue with double inclusion * DOCS * upgrade guide * post merge fixups * leftover comment * changelog * Doc changes in upgrade guide * have print debug info only in editor Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * update reference screenshots * VFX test: Replace auto exposure by fix exposure in ParticleRibbonTest * Fixed light layers not correctly disabled when the lightlayers is set to Nothing and Lightlayers isn't enabled in HDRP Asset (#584) * remove useless code for cookie * Hdrp/fix camera switcher (#591) * Fixed a wrong condition in camera switcher, potentially causing out of bound exceptions. * update changelog. * fix issue that prevents PS4 from building (#596) * Removed experimental namespace for ray tracing code. (#612) * Hdrp/multi view pt (#518) * Multiview (scene + game) path tracing accumulation. * Cosmetic. * Modifications to address comments in PR. * Updated PT fog test. * Updated Changelog. * Fixed issue with unlit shader graphs in path-traced mode. * Update CHANGELOG.md * Update HDUnlitSubTarget.cs Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix Look Dev default profile not updating correctly (#630) * Fixed an issue where editing the lookdev default profile would not reflect directly in the lookdev window. * Update changelog * Fix Unlit.template in shadergraph (#637) * Remove unused unlitpass.template * Update Lit.hlsl * re-add unlit pass * Fixed a bug where the light list is not cleared but still used when resizing the RT (case 1250630) (#609) * - Fixed a bug where the light list is not cleared but still used when resizing the RT. * add changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Histogram view improvements (#589) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * review fixups * print exposure values in debug view * commit but it is nothing, need to switch branch * Add option to center histogram around exposure (fixed tonemap curve) * change color of text * fixup debug display merge issue * fixup merge issues * fixup issue with tonemap curve Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update 9702_CustomPass_API.png.meta * Fix warning (#663) * add shader macros for XR single-pass (#687) * Adding 2 SG Pathtracer test scenes (#624) * New unlit pt scene * Add scene for PT Lit * Removing collider from the meshes * Renaming * Adding screenshots for PT scenes * Changing threshold for SSS deferred tests for stability * updating screenshot after staging being merged * Slightly increasing threshold for 5007 and 902 unlit scenes Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Render Graph Unit Tests (#607) * Render Graph Unit test WIP Fixed pruning of passes with no output. * Render Graph tests WIP * Increase max limit in UX of lights (#702) * Raise the max for lights * Update CHANGELOG.md * Fix null reference in volume debug menu (#705) * Update reference image for "502_RecursiveRenderingDisabled" (#704) * Update screenshot for 502 recursive rendering disabled test scene * upgrade shader material * Fix transparent movec scene view (#698) * Disable transparent movec when object motion vectors are disabled * changelog * Port (#599) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Custom Pass API part 2 (#227) * Begin to write the new custom pass API * Begin to add custom pass utils shader * Begin to add custom pass API test scenes * Fixes for the Gaussian blur of the custom pass API * Fix blur release * Added custom pass copy test and fixed blur * Added more custom pass documentation * Added custom pass API graphic test reference image * Added more obsolete things * fix function visibility * Added the API to override camera rendering * Updated changelog * Updated changelog * Fixed compilation issue * Added custom pass API test scene * Begin to add custom pass override test * Factorized protection function * Update custom pass test scene * Fixed custom pass API doc * Begin to add camera override tests * Fixed camera override in scene view * Finished RenderFrom API fucntions * Fixed XR disable class * Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update * Fix MSAA for before pre refraction and added errors for fullscreen MSAA operations * Finished to fix the RenderFrom* functions * Moved obsolete execute function into the new one * Update reference images * Added all the API doc * Updated changelog * revert mats * Updated custom clear pass to use the new API * Fixed depth buffer random read/write error * Disable custom pass blur test part * Revert camera pixel rect changes * Rename multi-pass to single pass * Disable custom pass test on vulkan and XR Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fix line that got lost in merge (#729) * Porting console fixes to staging (#699) * Path tracer: added support for transparency on the Unlit shader. (#717) * Added support for transparency in Unlit. * Updated Changelog. * Update capture for 5007_PathTracing Unlit Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * HDRP Compositor related fixes (#730) * Fixes for the compositor test * Enable the compoositor test in build settings * Avoid gc alloc, hide internal components from vomume menu * Vulkan and DX12 screens, adjust compositor UI refresh * Fixed a vulkan and metal warning in the SSGI compute shader. (#715) * - Fixed a vulkan and metal warning in the SSGI compute shader. * - Fixed an exception due to the color pyramid not allocated when SSGI is enabled. - Fixed an issue with the first depth history mip was incorrectly copied. * Fix path traced DoF focusing issue (#732) * Remove mip padding from PlanarReflectionProbeCache.cs * Disable 9702 test nor working + 9041 XR (instable) * Hdrp/pt pass no bsdf data (#710) * Removed direct use of BSDFData in path tracing pass. * Updated changelog. * Fixed float3 typo... * fix metal 9800 reference screnshots * update meta file and testcasefilter * Pre warm RT Handle system so that reallocations are reduced. (#713) * Pre warm rt handle system and initialize to screen width/height * changelog * not all was pushed Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fixes for Graphics tests with Render Graph (#725) * WIP for enabling valid graphics tests with Render Graph. Fixed a lot of gcalloc. * Fixed more GCAlloc and added an option for a test to not be run if render graph is enabled. * First batch of disabled tests. * Fixed decal rendering * Implemented ColorGrading and Uber Post (fixes a lot of small diff due to Color Grading not being 100% neutral) * Revert "First batch of disabled tests." This reverts commit 505924b6967041787c0698b4ede1d158686f990e. * Temp "texture not bound" error fix until bloom is implemented. * Fixed an error when using a stale invalid renderer list handle. Reduced error message spam when encountering an execution error. * Add some debug info to compiled passes and removed wrong refCount++ on passes. * Added possibility to disallow pass pruning Fixed a number of pass pruning issues. * Small fixes * temporarily removed pruning of passes without product * Fixed HDRP asset for test 5009 * Implement alpha copy for post processes * Small render graph error fix for motion vector pass. * Disabled for render graph tests that are currently broken. * Updated yamato with new render graph configurations * Fixed lens distortion * Reenabled 4021 * Revert "Reenabled 4021" This reverts commit 76a7c003456f40c5e84dd454a9c291b2b57ade64. * Revert "Updated yamato with new render graph configurations" This reverts commit 7b8acc08944df4b11244ee97a1877cee91d55be9. * Revert "Disabled for render graph tests that are currently broken." This reverts commit 84467f6956c1f14d0d0d302bdf6f8d220c5f9026. * Reverted HDRP test framework files (will go to another PR) * Revert "Fixed HDRP asset for test 5009" This reverts commit 95952b08e785daef2bbf7788849c5f661b9eb1fc. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Various fix and improvements for ray traced effects (#597) * Adding a minimal lit used for RTGI in peformance mode Dispatch binned rays in 1D instead of 2D Fix an issue with the half resolution Mode for RTGI Only read the geometric attributes that are required using the share pass info and shader graph defines Fix an issue with the color intensity of emissive for performance rtgi * Correct bug with shadow history rejection * reduce the exponential accumulation value a bit Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Procedural metering mask that follows target (#723) * some very incomplete stuff... * sync point, rough working version * Mostly working for now, moving onto debug vis and maybe revisit. * Commit as I need branch switching - Start debug modes * Add a bunch of debug mode and start of histogram * Delimiters indicator with bars * Add another option for percentile exttremes * fix warning * Moving debug modes * Label bar separate (invisible otherwise) * Push change to bar indicator * remove fancy background of histogram frame * start of procedural mask * Small triangle instead of indicator bars * Target exposure indicator * add some margin * Add an X at center * Metering PiP * Draw tonemap curve and use tonemapped texture for view * Share some code * Curve remapping for histogram and fix some warning * Some comments fixup * Simple comment changes * Revert debug symbol in shader * Changelog * Some basic version of procedural working * need to switch branch * Exposure target and threshold. * fix merge mess * Fixes Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * - Added presets quality settings for RTAO and RTGI. (#724) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue in HDRaytracingIndirectDiffuse * fix shader warning in exposure * Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). (#648) * - Added an override for the shadow culling that allows better directional shadow maps in ray tracing effects (RTR, RTGI, RTSSS and RR). * Simplifying the culling override. * Update 708_ShadowExtendedCulling.png Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Removed reference image for player (unused) in HDRP Test * Update preview naming (#753) * Cloud layer volume override (#461) * Added uv distorsion for HDRISky cubemap * Editable flow strength * Better parameter name. Smooth flow on cube edges * Added a graphic test. Updated Changelog * Updated documentation * Added screenshots * Wait frames for test * Wait more * Update screenshots again... * Static test * Static screenshots * use multi_compile * Renamed all parameters * Procedural distortion * Update doc * Set all keywords * Revert to old behaviour * doc * update test * remove useless variable * doc * CloudLayer HDRI * CloudLayer Gradient * CloudLayer Physically Based * Documentation * Add clouds to Static Lighting Sky * Fix spherical conversion * Fix procedural flow * Fix lat long and procedural flow * replace trig functions. Correct wind dir * sync with hdri flow * Renamed variables * Allow full sphere coverage for procedural flowmap * Added missing doc * Fix cloud reset and unrelated warnings in hdri sky shader * Try different blending method * Fixes + test another blending * Tint and intensity parameters. Fix static sky used by lightmapper * Added graphic test. Updated doc * Updated tests using a disabled static sky If a sky override is used for static lighting and is disabled in the volume, it is not used anymore * Update LocalAmbientOcclusionNoisy.asset * update linux screenshots * Update CloudLayer.cs * update OSX screenshots Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Introduce LightLoop output structure (#754) * Add concept of LightLoop Output * update upgrade guide * Update Upgrading-from-2020.1-to-2020.2.md * update upgrade guide * Fix lightloop-output (#755) * Fix rendering when XrMaxViews is different than 2 (#733) * Use a fixed size for xr related fields in cbuffers * changelog * Update local shader config * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Improve transition between LOD for lit and layeredLit tessellation (#517) * Forest scale for tessellation change * Forest scale for tessellation change * Update Upgrading-from-2019.3-to-2020.1.md * Update Upgrading-from-2019.3-to-2020.1.md * fix ray tracing with XR single-pass (#769) * Revert "fix ray tracing with XR single-pass (#769)" This reverts commit 3e366334444febf450568b47ada2c00e4164ba12. * reviewed new additions to 2019.3 - 2020.1 and 2020.1 - 2020.2 upgrade guides (#766) * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Initial implementation for the new planar reflection filtering (#337) * Initial implementation for the new planar reflection filtering * Small improvement and "proper" support of oblique projection * quality improvement to the filtering. * Update PlanarReflectionFiltering.compute * review corrections * Update planar filter for all material (was not replaced) + update screenshots * Update IBLFilterGGX.cs * fix shader warning on vulkan * update references screenshots * Fixes for the plane normal and number of mips to be computed * Fix shift that was to the right in the blurred version * update references screenshots * fix shader warning * Some cleanup * change to fast Atan Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fast memory support (#772) * temp, gonna revert this, but have to merge staging. * again, need to switch branch, nothing functional * ESRAM support * changelog * Add guards * Standard terrain upgrader (#762) * Add render graph specific pipeline to HDRP tests. (#728) * Added an option to ignore tests when render graph is enabled. * Disabled for render graph tests that are currently broken. * Reenabled 4021 * Updated yamato script to add the RenderGraph pipeline. * Fixed HDRP asset for test 5009 * Revert unrelated yml files changes due to old configuration (#714) * Fixed an issue with not unregistering render graph debug. Disabled test 9401 for render graph after merge conflict. * Disabled 9800 for render graph * Revert hdrp asset for 5009 Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> * Added CPU and GPU timings for ray tracing effects. (#774) * Added CPU and GPU timings for ray tracing effects. * Only displaying the counters if ray tracing is supported on the asset. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Workaround for GetKernelThreadGroupSizes returning wrong data (#760) * Hard code group size * changelog * Add comment * Fixed the distanced based denoising being exposed for area lights (1251558). (#782) * Fix test project * Fix an issue with Fast memory code trying to access deleted resources when rendergraph is enabled (#791) * Fix issue accessing already released targets for rendergraph * changelog * Sanitize transparent motion vectors setting (#761) * Sanitize transparent motion vectors setting * Update CHANGELOG.md Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Revert "Add render graph specific pipeline to HDRP tests. (#728)" This reverts commit 4bcb4364fdd24a7d3205b46a5ce0ed63fe63cb5e. * Increased path tracing roughness range. (#763) * Increased path tracing roughness range. * Updated failing tests reference images. * Update Upgrading-from-2020.1-to-2020.2.md (#798) * Force post process parent setting to be before child settings (#799) * Force post process parent setting to be before child * changelog * Fix exposure white flash when enabling SSGI or SSR (#801) * Inform post process that history have been nuked * changelog * Various fixes related to SSGI and RTGI (#803) * Added support to combine RTSSS and RTGI The ray traced indrect diffuse and RTGI were combined wrongly with the rest of the lighting. Fixed an exception happening when using RTSSS without using RTShadows Changing the default SSGI radius for the all configurations Update screenshots for GI scenes * changelog update * [Draft] Lighting/probevolumes cleanup (#756) * Simplify EvaluateProbeVolumes interface and builtin SampleBakedGI code * Fix clearing of uninitialized GI * Added ProbeVolumesEncodingMode to ShaderOptions in ShaderConfig to allow users to configure their project to store and sample probe volumes as SH0 terms, SH1 terms, or SH2 terms, for different performance / quality tradeoffs. Data pipeline for this seems to be working now (though only properly verified with SH1 at the moment). Next step is to update sampling / evaluation code to handle SH0, and SH2 variants. * Probe Volumes: SH0, SH1, and SH2 evaluation based on ShaderConfig fully working now. Lots of additional cleanup tasks as well. * Probe Volumes: Instead of specifying AtlasWidth, AtlasHeight and AtlasDepth for probe volume atlas on HDRenderPipelineAsset, have user simply specify AtlasResolution and use for all axes. Same treatment for AtlasOctahedralDepth. * Probe Volumes: HDRenderPipelineAsset: Add memory usage information to UI and ensure we never allocate the ProbeVolumeAtlas or OctahedralDepthAtlas to be larger than k_MaxCacheSize * Probe Volumes: Bugfix for Probe Volume UI: Only display Additive blendmode warning if additive blend support is disabled in ShaderConfig * Probe Volumes: Bugfix: DataIsAssigned function needed in build as well. * Probe Volumes: Accumulate SH coefficients, and evaluate SH at normal after accumulation. This allows us to avoid 2x accumulations, 1 for forward normal, and 1 for backward (transmission) normal. Light loop mode is tooled up to do single evaluation. Material Pass mode still accumulates twice, because SampleBakedGI() is called twice. Need to modify SampleBakedGI() signature to take both normals and internally accumulate front and back lighting. * Probe Volumes: Rename EvaluateProbeVolumes() to AccumulateProbeVolumes() to make it clear that evaluation happens in a following EvaluateProbeVolumeCoefficients() function. * Probe Volumes: Major cleanup to AccumulateProbeVolumes(), pulling out the majority of the logic into self contained supporting functions. * Probe Volumes: Add ShaderConfig.s_ProbeVolumesBilaterialFilteringMode and strip out octahedral depth logic and memory allocations when not in use. * Probe Volumes: Do not allocate or bake octahedral depth data in ProbeVolumeAsset if ShaderConfig does not enable octahedral depth bilateral filtering. * Probe Volumes: Always allocate and pass octahedralDepth array into GetAdditionalBakedProbes() because the API call without the octahedralDepth argument has been flagged as obsolete. In the future, we should remove this unnecessary allocation. * Probe Volumes: Explicit ProbeVolumeAccumulateSphericalHarmonicsL0, L1, and L2 variants exist so we can choose to sample any order we want in any atlas configuration. i.e: sample L0 for vfx with L2 atlas. Upsampling is lossy, but supported, i.e: sample L2 in L0 atlas. Atlas coefficient layout was changed to accomodate this, and ProbeVolumeAccumulate function was moved to its own include so that each order variant can be generated with the preprocessor. * Probe Volumes: Add simple method for configuring what order of SH Probe Volumes is sampled at per shader (via a define before include). * Probe Volumes: Fix to ProbeVolumeUI string names * Probe Volumes: Move LightLoop::CreateBoxVolumeDataAndBound out parameters to end of args to match HDRP convention. * Probe Volumes: Remove redundant include from DebugDisplayProbeVolume.shader * Probe Volumes: Only support SH1 and SH2 atlas (SH0 was not needed). Change / cleanup payload data layout. Now SH0 and SH1 terms are stored in one float array, and SH2 quadratic terms are stored in seperate float array. This allows us to always bake and serialize SH2, but conditionally upload only SH0 and SH1 terms if user only requests SH1 atlas. This will also make it easier for SH2 terms to be stripped from the build in the future. * Probe Volumes: Wrap supporting accumulation, evaluation, and fallback function calls into ProbeVolumeEvaluateSphericalHarmonics() function to hide static branches around SH order from LightLoop and SampleBakedGI. * Probe Volumes: Update SampleBakedGI() API (#759) * Probe Volumes: Update SampleBakedGI() and supporting internal functions signature in order to evaluate lighting along front and back facing normals at the same time. * Add some comment Co-authored-by: pastasfuture <pastasfuture@gmail.com> * Probe Volumes: Fix DebugViewTiles shader after updates to ProbeVolumeGetCountAndStart() * Probe Volumes: Set ShaderConfig evaluation mode to be disabled by default. * Probe Volumes: Update EvaluateOctahedralDepth function name to match surrounding code convention. * Probe Volumes: Fix up ShaderVariablesGlobal after naming conflict from pulling in lastest. Co-authored-by: Tobias Alexander Franke <tobias@unity3d.com> Co-authored-by: pastasfuture <pastasfuture@gmail.com> * update DXR Test project * Fix transparent/opaque motion vector inconsistencies by allowing camera-only transparent motion vectors (#788) * Allow camera only transparent motion vectors * Changelog * revert old way of doing it. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Made VT settings classes internal rather than private/public (#805) Co-authored-by: Nico Leyman <Nicolas@GraphineSoftware.com> * update test filter * fix shad variables globals after merge * Update ShaderVariablesGlobal.cs.hlsl * Update LightingDebug.cs.hlsl * Fix reflection probe framesettings override (#796) * Fix reflection probe framsettings override * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix artifacts in volumetric lighting near opaque geometry (#493) * Add view bias to volumetrics * Implement geometry-distance-aware volume rendering * Comment * Fix the flickering issue * Clean * Fix * Changelog * Implement lookup bias for volumetrics * Update CHANGELOG.md * update test filter * fix refernce screenshots Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed WRITE_NORMAL_BUFFER macro redefinition and generated interpolators in ShadowCaster and META pass (#816) * update reference screenshots * Hdrp/fix/cookie area light update (#828) * Fixed area light cookie not used when a spot cookie is assigned * Updated changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix issue with dynamic resolution and CAS + issue with dynamic resolution updating while not in playmode (#827) * Make sure update of dynamic res happens only in game view and not when playing. * changelog * Allow forced res to still be valid while not playing Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed logic of test on presence of HDRP asset that would wrongly trigger (#824) a warning message when not in batch mode. * Fix raytracing keyword & static render state leak (#829) * Fix raytracing keyword value * Fix static render state being modified and causing side effects * Fix issue with blocky artifacts when decals affecting metallic are applied on specular color workflow (#823) * specular color needs to be weighted back with the blend factor. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Update HDShaderPasses.cs * Add custom post process before TAA injection point (#817) * Added custom post process before TAA injection point * Updated custom pp graphic test * Added before TAA post process in HDRP default settings * Re-enabling the bloom test (#809) * Re-enabling the bloom test * Moving the test at the proper position Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> * Fix depth pyramid issues with dynamic resolution (#806) * Recompute the mip info before generating the mipchain * changelog * avoid compute mipchain if not needed Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix decal being duplicated in prefab isolation mode. (#789) * Fixed decals being duplicated in prefab isolation mode. * Update changelog. * Fix decals in the player. Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fixed an issue where rendering preview with MSAA might generate render graph errors. (#800) * Fixed an issue where rendering preview with MSAA might generate render graph errors. * Update changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compile issue on PS4 for PlanarReflectionFiltering.compute (#830) * Fix compile issue for PS4. * changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Fix compilation issue * IES Light Support (Point, Spot & Rectangular Lights) (#459) * IES Importe & Generate 2D/Cube/Equirectangular Textues * Enable PreviewGUI for IES Light, Split Core & HDRP * IES Point sampling enable Octahedral * missing file * spaces * for test * Cut of push Yamato generation * Wrong merge: Missing file * Missing file * wip * Octahedral Tilling * Cleaner & introduce IESObject * missing dead code * Allow only Power of 2 textures, update when resize * Clean code, + change log + Area Light * remove useless code * minor update * Merge * Cleanup * Remove useless log * Unify code + cleanup * Update documentation * Disable IES for Directionnal Lights * Fix when we update the spot angle baked * Update documentation & rename UI * com * Fix error for Area/Rectangular lights * Minor typo + move internal (WIP) * minor * minor * fix Pyramid + Box light & Add support of IES for them * Unreachable code fix * fix HDRPTest for Box lights * Add missing public doc * Last missing doc issues - fix * Remove all CGAlloc; Remove IES + Cookie for emissive mesh of area light(+Update doc) * Remove useless code, typo * Update versions in manifests (#647) * update manifests * Update manifest.json * update hdrp runtime [skip ci] * update testing packages [skip ci] * remove unused references * Update reference to support octahedral for animated texture * Update GI Support (HDRP Test valid) * Update image reference * Add migration message for Cookies * Fix message * Typo in light-component.md * Forgot an "and" * Typo in display emissive mesh property * Update documentation to clarify the case for light baking + IES cases * Switch from slider to ComboBox for IES Resolution * Rewording sentence on cookie/ies baking tooltip * Used same sentence from elsewhere for coherence * Fix compilation issue after merge * Update Vulkan reference images * Update OSX Metal reference image for CubeCookie * Formating, type & convention * Formating & code convention * Fix warning message * Update upgrading 2020.1 to 2020.2 doc * Update light loop for fetching * Update Upgrading-from-2020.1-to-2020.2.md * Update Upgrading-from-2020.1-to-2020.2.md * Update LightCookieManager.cs * Update HDRenderPipelineAsset.Migration.cs * Fix DXR Text * Fix Yamato XR * update reference screenshots * update reference screenshots * fix for Yamato OSXEditor/Metal Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> * Revert "Re-enabling the bloom test (#809)" This reverts commit cc9a6498c9213174f27b14d5aa5f081667346d99. * Update reference screenshots for IES * fix shader warning in DepthTAA.shader * Update 2313_Shadow_Mask_Spotlight_Shapes.unity * Update VFX reference screenshots * Update 4060_CustomPostProcess.unity * Update HDSRP_ Test reference screenshots * Update TestCaseFilters.asset * Adding missing references image for HDRP 4038 (#856) * Adding Linux Vulkan, OSX Metal, Win D12, Win Vulkan ref image for 4038 bloom * Win D11 * Fix message for metal and ao (#859) * Add texture import preset to automatically apply to "ActualImages" (#861) * Fix issue with the blue line of prefab modifications for Volume mode (#860) * Fix blueline in prefab mode * changelog * Fixing the internsity being applied to RTAO too early leading to unexpected results (1254626). (#825) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * add color clear pass while rendering XR occlusion mesh to avoid leaks (#688) * Recompute FOV when generating PixelCoord To WorldSpace View Direction Matrix (#865) * test manual fov computation * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Hdrp/fix/shader stack normals (#852) * Fixed normal space in templates * Fix nullref in material inspector * Updated changelog * Added iris and coat normal spaces Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * [10.x.x] Axf: add normal gradients and all mapping modes (uv, planar, triplanar) (#583) * AxF: Add support for surface gradients and uv0 to uv3, planar ZY, XZ, XY and triplanar mapping modes. * AxF: Internally, add extended texture sampling options in macros, screen gradients caching and their usage in flakes (better than calculate LOD intrinsic when anisotropic filtering is enabled) * AxF: Sample only 2 channels of the normal maps. * AxF: Update test reference (minute differences were already present before these updates) * AxF: Remove test code. * AxF: Update documentation and changelog. * AxF: Add some comments for the alternate sampling path for flakes, and remove a bit of deadwood. * AxF: Add a documentation note about UV1 set. * AxF: Update minute differences in WindowsEditor Vulkan test result. Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Fixed blend distance editing (1248931) (#838) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [10.x.x] Axf fix shininess exp to roughness, ssr transparent and alpha test (#587) * AxF: Add support for surface gradients and uv0 to uv3, planar ZY, XZ, XY and triplanar mapping modes. * AxF: Internally, add extended texture sampling options in macros, screen gradients caching and their usage in flakes (better than calculate LOD intrinsic when anisotropic filtering is enabled) * AxF: Sample only 2 channels of the normal maps. * AxF: Update test reference (minute differences were already present before these updates) * AxF: Remove test code. * AxF: Update documentation and changelog. * AxF: Fix Blinn-Phong roughness/exponents handling. Move alpha test earlier. * AxF: Add ssr transparent enable, mainly so that changing surface type to transparent doesn't crash the generic surface option block because of the missing receives ssr transparent property. * fix merge issue Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com> * Upgrade default legacy terrain to HDRP default TerrainLit (#883) * Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. (#841) * Fixed a serialization issue, preventing quality level parameters to undo/redo and update scene view on change. * Update changelog * Fixed issue when using Custom Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Updated asmdefs according to the new doc (#886) Co-authored-by: Fabien Houlmann <44069206+fabien-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Evgenii Golubev <EvgeniiG@users.noreply.github.com> Co-authored-by: Pavlos Mavridis <pavlos.mavridis@unity3d.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: fredericv-unity3d <55485372+fredericv-unity3d@users.noreply.github.com> Co-authored-by: slunity <37302815+slunity@users.noreply.github.com> Co-authored-by: Remi Slysz <40034005+RSlysz@users.noreply.github.com> Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com> Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com> Co-authored-by: Evgenii <evgenii@unity3d.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com> Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk> Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com> Co-authored-by: pastasfuture <pastasfuture@gmail.com> Co-authored-by: Theo Penavaire <theo.penavaire@gmail.com> Co-authored-by: Tobias Alexander Franke <tobias@unity3d.com> Co-authored-by: NicoLeyman <49522355+NicoLeyman@users.noreply.github.com> Co-authored-by: Nico Leyman <Nicolas@GraphineSoftware.com> Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com> Co-authored-by: RemyUnity <32760367+RemyUnity@users.noreply.github.com>

Fix path traced DoF focusing issue

22a6463

pmavridis added the HDRP label Jun 5, 2020

pmavridis requested review from eturquin, sebastienlagarde and remi-chapelain June 5, 2020 08:31

github-actions bot added the testing label Jun 5, 2020

sebastienlagarde approved these changes Jun 5, 2020

View reviewed changes

sebastienlagarde merged commit 37e93e7 into HDRP/staging Jun 5, 2020

sebastienlagarde deleted the HDRP/pathtraced_dof_fix branch June 5, 2020 10:51

sebastienlagarde mentioned this pull request Jun 6, 2020

[10.x.x] Merge Hdrp/staging [Skip CI] #740

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix path traced DoF focusing issue #732

Fix path traced DoF focusing issue #732

pmavridis commented Jun 5, 2020 •

edited

sebastienlagarde left a comment

Fix path traced DoF focusing issue #732

Fix path traced DoF focusing issue #732

Conversation

pmavridis commented Jun 5, 2020 • edited

Testing status

sebastienlagarde left a comment

Choose a reason for hiding this comment

pmavridis commented Jun 5, 2020 •

edited