Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x.x] Merge Hdrp/staging [Skip CI] #831

Merged
merged 1,792 commits into from Jun 11, 2020
Merged

[10.x.x] Merge Hdrp/staging [Skip CI] #831

merged 1,792 commits into from Jun 11, 2020

Conversation

sebastienlagarde
Copy link
Collaborator

@sebastienlagarde sebastienlagarde commented Jun 10, 2020

Purpose of this PR


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

sebastienlagarde and others added 30 commits April 22, 2020 16:12
… error (case 1238155) (#215)

* fix bug 1238155

* Update CHANGELOG.md

* Update HDRenderPipeline.cs

* Update HDRenderPipelineAsset.cs
* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Fix decal shader

* Fixed HDRP cookie

* Update HDLightUI.cs

* correctly fix decal

* Update CHANGELOG.md

* Update ColorAdjustments.cs

* Update ShaderVariablesDecal.hlsl

* fix compil on 2020.1

* Update HDRP_Test_Def.asset

* add test for 3RT decal

* update decal test
…244)

* Do code cleanup + bugfix shadow

* Update Upgrading-from-2020.1-to-2020.2.md

* Update LightLoopDef.hlsl
* Made the static lighting sky public so that users can change it by script for baking purpose.

* Update changelog
* Fixed an error about procedural sky being logged by mistake.

* Update changelog
* Update HDRenderPipeline.cs

* Update HDRenderPipeline.cs

* Update CHANGELOG.md

* Update HDRenderPipeline.cs

* fix typo

* fix typo 2
* Made more explicit the warning about raytracing and asynchronous compute. Also fixed the condition in which it appears.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…ile is invalid. (#278)

* Fixed a null ref exception in static sky when the default volume profile is invalid.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix issue with screen_space shadows not enabled with RT off

* Proper fix: only keep directional screen space shadows with RT off

* Fix shadow debug mode

* cosmetic changes

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
)

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added the API to override camera rendering

* Updated changelog

* Fixed compilation issue

* Factorized protection function

* Fixed camera override in scene view

* Added isPersistant bool in HDCamera and allocateHistoryBuffers param in Update

* Fixed camera override with dynamic resolution and moved it to internal

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
alelievr and others added 14 commits June 10, 2020 19:04
* Fixed area light cookie not used when a spot cookie is assigned

* Updated changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…tion updating while not in playmode (#827)

* Make sure update of dynamic res happens only in game view and not when playing.

* changelog

* Allow forced res to still be valid while not playing

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…ger (#824)

a warning message when not in batch mode.
* Fix raytracing keyword value

* Fix static render state being modified and causing side effects
…plied on specular color workflow (#823)

* specular color needs to be weighted back with the blend factor.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Added custom post process before TAA injection point

* Updated custom pp graphic test

* Added before TAA post process in HDRP default settings
* Re-enabling the bloom test

* Moving the test at the proper position

Co-authored-by: Remi Chapelain <remi.chapelain@unity3d.com>
* Recompute the mip info before generating the mipchain

* changelog

* avoid compute mipchain if not needed

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fixed decals being duplicated in prefab isolation mode.

* Update changelog.

* Fix decals in the player.

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
…r graph errors. (#800)

* Fixed an issue where rendering preview with MSAA might generate render graph errors.

* Update changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
* Fix compile issue for PS4.

* changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
sebastienlagarde and others added 12 commits June 10, 2020 23:03
* IES Importe & Generate 2D/Cube/Equirectangular Textues

* Enable PreviewGUI for IES Light, Split Core & HDRP

* IES Point sampling enable Octahedral

* missing file

* spaces

* for test

* Cut of push Yamato generation

* Wrong merge: Missing file

* Missing file

* wip

* Octahedral Tilling

* Cleaner & introduce IESObject

* missing dead code

* Allow only Power of 2 textures, update when resize

* Clean code, + change log + Area Light

* remove useless code

* minor update

* Merge

* Cleanup

* Remove useless log

* Unify code + cleanup

* Update documentation

* Disable IES for Directionnal Lights

* Fix when we update the spot angle baked

* Update documentation & rename UI

* com

* Fix error for Area/Rectangular lights

* Minor typo + move internal (WIP)

* minor

* minor

* fix Pyramid + Box light & Add support of IES for them

* Unreachable code fix

* fix HDRPTest for Box lights

* Add missing public doc

* Last missing doc issues - fix

* Remove all CGAlloc; Remove IES + Cookie for emissive mesh of area light(+Update doc)

* Remove useless code, typo

* Update versions in manifests (#647)

* update manifests

* Update manifest.json

* update hdrp runtime [skip ci]

* update testing packages [skip ci]

* remove unused references

* Update reference to support octahedral for animated texture

* Update GI Support (HDRP Test valid)

* Update image reference

* Add migration message for Cookies

* Fix message

* Typo in light-component.md

* Forgot an "and"

* Typo in display emissive mesh property

* Update documentation to clarify the case for light baking + IES cases

* Switch from slider to ComboBox for IES Resolution

* Rewording sentence on cookie/ies baking tooltip

* Used same sentence from elsewhere for coherence

* Fix compilation issue after merge

* Update Vulkan reference images

* Update OSX Metal reference image for CubeCookie

* Formating, type & convention

* Formating & code convention

* Fix warning message

* Update upgrading 2020.1 to 2020.2 doc

* Update light loop for fetching

* Update Upgrading-from-2020.1-to-2020.2.md

* Update Upgrading-from-2020.1-to-2020.2.md

* Update LightCookieManager.cs

* Update HDRenderPipelineAsset.Migration.cs

* Fix DXR Text

* Fix Yamato XR

* update reference screenshots

* update reference screenshots

* fix for Yamato OSXEditor/Metal

Co-authored-by: Sebastien Lagarde <sebastien@unity3d.com>
Co-authored-by: Sophia <16596228+sophiaaar@users.noreply.github.com>
Co-authored-by: remi-chapelain <57442369+remi-chapelain@users.noreply.github.com>
@sebastienlagarde sebastienlagarde merged commit 945c8d8 into master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet