Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate HDRI #88

Closed
wants to merge 39 commits into from
Closed

Integrate HDRI #88

wants to merge 39 commits into from

Conversation

skhiat
Copy link
Contributor

@skhiat skhiat commented Apr 9, 2020

Update HDRI Sky Integration Upper Hemisphere for the Lux Intensity

ref PR:
https://github.com/Unity-Technologies/ScriptableRenderPipeline/pull/6030

Please read

PR workflow guidelines

  • SRP ABV will start automatically on Yamato when you open your PR
  • Changes to docs and md files will not trigger ABV jobs
  • Consider making use of draft PRs if you are not 100% sure that your PR is ready for review
  • ABV will restart if you add a new commit to a branch with an open PR (hence why you should consider using draft PRs)
  • Adding [skip ci] (case insensitive) to the title of PRs will stop any jobs being trigger automatically - you will need to open Yamato and find your branch to run ABV
  • You can also add [skip ci] to commit messages to prevent CI from running on that push
  • Add [cancel old ci] to your commit message if you've made changes you want to test and no longer need the previous jobs

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/78-ScriptableRenderPipeline

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

* Add RTHandleDeleter (delay in K frame the Release of a RTHandle)
* Fix GPU Operation when texture are too small
* Helper to manager Mariginal Texture in general (Tex2D, Tex2DArray, CubeMap, CubemapArray), ...
* Helper manager to generate one marginal per slice mip (one per frame)
…ScriptableRenderPipeline into HDRP/multiple_importance_sampling_hdrisky

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Raytracing/Shaders/Reflections/RaytracingReflections.compute
#	com.unity.render-pipelines.high-definition/Runtime/Sky/SkyManager.cs
…ScriptableRenderPipeline into HDRP/integrate_hdri

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/Sky/SkyManager.cs
…Graphics into HDRP/integrate_hdri

# Conflicts:
#	com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/HDStringConstants.cs
@skhiat skhiat closed this Apr 17, 2020
PaulDemeulenaere pushed a commit that referenced this pull request Sep 2, 2020
* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output
PaulDemeulenaere pushed a commit that referenced this pull request Sep 16, 2020
* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU
sebastienlagarde pushed a commit that referenced this pull request Oct 5, 2020
* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* update asset and scripts

* Remove u…
sebastienlagarde added a commit that referenced this pull request Oct 14, 2020
* Add alembic test to HDRP_DXR_Tests

* Update alembic reference images

* Use Yamato reference images

* XR test updated reference image

* Revert reference image for WindowsEditor. It looks like playmode_XR has
a different result than playmode and playmode_Rendergraph

* Modify alembic test to confirm alembic works with ray tracing by viewing
alembic mesh via ray traced reflection

* Set XR threshold multiplier to 1.5, based on other tests that have to
wait for frame

* Update WindowsEditor reference image

* updated most prefabs to not be prefab variants unecesssarily, updated diffusion profile for bamboo leaves, fixed wood normal map, rebaked, added new "medium" bake settings

* [CI] Updated .ymls to new revision

* Expose PointCacheAsset textures (#2030)

Currently there's no pCache property in vfx graph, this change exposes textures to make them usable instead of pCache.

More: https://forum.unity.com/threads/expose-point-cache-as-blackboard-attribute.856603/#post-6355635

* Fixed links and images

Fixed issues in the ToC, links in all docs and images in all docs.

* Fix Static-shader-analysis.md links.

Changed file name of Static-shader-analysis.md and fixed links.

* removed useless -preview.1

* Toc name change

Also amended links.

* TableOfContents name change.

* Universal/fixing changelog (#2090)

* removing duplicate Added sections

* removed accidental added text

* Fixed the dates issue

* Moved fixed to the right section

* Updated fontainbleau compatability and added relevant links

* Fix clear coat chagelog issues. (#2095)

* Renamed UI `Vector1` to `Float` / Renamed enum `Float` precision to `Single`  (V2) (#1979)

* rename precision from float to single

* rename vector 1 to float

* rename vector1 in the documentation

* Update Compositor-User-Guide.md

* Update Upgrade-Guide-10-0-x.md

* fix precision test

* add search synonym to upgraded node

* update precision test graph

* Fixed extra whitespaces and minor rewording

* Rename also all enum which a Vector1 inside to get correct string conversion as float

* Renamed Float.md and updated links to it

* Revert "Rename also all enum which a Vector1 inside to get correct string conversion as float"

This reverts commit 3d5fe9b48a1c2b7642b40327c5fea7a259016638.

* rename property type to have correct type display

* Update DiffusionProfileShaderProperty.cs

* Fix blackboard info name after merge of Antoie PR

* rename the uss color mode to keep correct banding color

Co-authored-by: Alex Lindman <alexandral@unity3d.com>
Co-authored-by: Sharlene Tan <sharlenet@unity3d.com>

* VFX Staging to Master for 10.1 (#1945)

* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick di…
julienf-unity added a commit that referenced this pull request Oct 23, 2020
* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* update asset and scripts

* Remove unwanted files
…
julienf-unity added a commit that referenced this pull request Oct 25, 2020
* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* update asset and script…
julienf-unity added a commit that referenced this pull request Oct 25, 2020
* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* update asset and script…
sebastienlagarde pushed a commit that referenced this pull request Oct 25, 2020
* 10.2 fixes

* [VFX] harmonize position + fix API validation (#2365)

* property attributes not serialized (#253)

* Initial tests

* Fix typo

* Change the VFXPropertyAttribute class

* Use VFXPropertyAttributes in VFXProperty

* Refactor interface

* Remove old VFXPropertyAttribute class

* More fixes

* Fix bug in DataAnchorController

* Fix invalid cast typo

* Remove shader warnings (#261)

* Fix shader warnings in test projects

* Update changelog

* Vfx/feature/filter enum (#243)

* Allow filtering enums values in VFXModels.

* Add an explicit GetHashCode() to default NameNType.

* Update CHANGELOG.md

* Update VFXHDRPSubOutput.cs

* fix based on review

* Remove raytracing enumerator filter as it was removed from HDRP enum

* Remove irrelevant render queues from some HDRP outputs (#263)

* Remove AfterPostProcessing render queue for lit outputs

* Remove render queue field from distortion outputs

* Update changelog

* Update HDRP changelog instead of VFX

* Fix issue when converting outputs with invalid render queue

# Conflicts:
#	com.unity.render-pipelines.high-definition/CHANGELOG.md

* Fixed Flipbook Texture Names

* Update CHANGELOG.md

* Fix exception when creating new category on new visual effect asset.

* Forward port - Dont remove suboutputs objects if it cannot be deserialized (#205)

* Fix to graft : support for flag enum in inspector

* *Update changelog

* Revert "Fix Enum Flag" (#15)

* "Fix Enum Flag" (#16)

This reverts commit f26a487b09e7f4941b833479b335f179b7dcc241.

* Fix for Initial Event field height, (#17)

* Fix for Initial Event field height, that were clipping the bottom of legged letters

* Update CHANGELOG.md

* Vfx/fix colorfield height (#19)

* Fix color field height

* changelog

* Mesh Sampling (revival) (#1)

* Squashed commit of the following:

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

commit b0ab2685f7bdbd0b859a010422e8074bc95bfbc3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:36:49 2019 +0100

    Fix PositionMesh

commit 05aec35f9a430497583f5b952fa97ce6784c676d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 17:01:52 2019 +0100

    *Update graphicTest

commit 052cb87133878404390365f0403b6faa44821133
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 15:30:46 2019 +0100

    Fix mesh color sampling

commit c2db4d2ebe41d1ba0648b439bb167e486fd318ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 14 11:41:59 2019 +0100

    Use explicit VFXExpressionMesh.GetVertexCount which handle in unified way to mesh nullity

commit 2ecdcc54480aa17665db6b980a5ba797539931e9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:28:19 2019 +0100

    Add MeshVertexCount operator

commit c5b144214270c741bc61a6bc0994c0c5098ba39a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Nov 13 10:08:14 2019 +0100

    Add a true embedded random in SampleMesh

commit d4e9dcf5a9abbc6ad79315cc1c60afe79f94af87
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 12 18:35:35 2019 +0100

    Fix unexpected cast int to uint

commit 0fc7ed15c61435dbe917a56da4c939de35b57f2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 14:39:06 2019 +0100

    Add WIP TODOPAUL

commit 6ff729e50e85204a597c0628be601a2b8064cc3e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 8 13:55:20 2019 +0100

    Use uint instead of int & remove RandInt

commit 22770d8cfef4135a054e0ed7194ee4a45b1497b4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:09:22 2019 +0100

    *Update Shape.vfx

commit 5d17343ddd478986d867e6d0f499cb5bd6c93d52
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 15:07:11 2019 +0100

    Fix build

commit 3a2729fb19b09fda873eff06ebad83b38b84ceb6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:46:47 2019 +0100

    Report changes from https://github.cds.internal.unity3d.com/unity/vfx-graph/blob/bd366e5cf8dc25b725a4f064ad65577d26d1f51f/com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit cc0a36b42965c6e04f9b088d363f68ec8b2d41ae
Merge: bd366e5cf8 d2bacd6482
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 4 14:43:23 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXCodeGenerator.cs
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs
    #	com.unity.visualeffectgraph/Shaders/VFXCommon.cginc

commit bd366e5cf8dc25b725a4f064ad65577d26d1f51f
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Wed Dec 12 12:53:50 2018 +0000

    Fix mesh sampling stride and remove fmod when not needed

commit 706aa48a4a98b76f5f2a4d190b4df9250e0896dc
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:40:06 2018 +0000

    color space fix

commit 3df16fe0c60a235e3991249553ccf4167bd7d736
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 16:03:25 2018 +0000

    Shape gfx test

commit ceef2e0410503647eb1f997f217e9442fb50b823
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Tue Dec 11 12:32:36 2018 +0000

    Remove baking prototype and fix channel offsets

commit 39d518807d279fd328cc4408d5f85667f60e719b
Author: Richard Kettlewell <richardk@unity3d.com>
Date:   Mon Dec 10 15:26:55 2018 +0000

    Mesh sampling

* Commit data files as lfs

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47935

Rename IsTypeCanBeConstantFolded into IsTypeConstantFoldable

* Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r47933

Use simpler & explicit definition of propagated flags

* Fix several issue/comment

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50761
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50762
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50764
Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r50765

* Switch 007_SimpleMaterial from Lit to Unlit to avoid any change from shadergraph

* Fix tooltip issue from @lewisjordan

Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51380
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51381
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51382
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51383
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51384
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51385
Fix issue from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51386
Side note : use mode instead of "addressingMode" in PositionMesh as well.

* Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#discussion_r51553

* As suggested by @julienf default VFXOperatorUtility.SequentialAddressingMode to Clamp for performance in https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/1#issuecomment-20777

* Add composition for Position (Mesh) as suggested by @thomasi

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Update experimental disclaimers (#367)

* Updated experimental disclaimers

* Removed link and added description instead.

* [HDRP] MSAA & MotionVector (#12)

* Support WRITE_MSAA_DEPTH Unlit template

* Fix MSAA for lit output

* *Update changelog

* Fix SSAO (among other passes) integrating WRITE_MSAA_DEPTH

TODO : Fix Sphere output as well

* Fix typo in ParticlePoint

* Factorize common fragment Lit & unlit for depth alike passes.

* Fix particle hexadreon wrong depth with alpha clip

* Revert "Fix particle hexadreon wrong depth with alpha clip"

This reverts commit b16bd570440087984c2c8c48279bebb088f748e8.

* Allow an object slot to have null as its value (#25)

* Allow an object slot to have null as its value

* changelog

* Vfx/fix/prevent capacity change locked (#24)

* Prevent capacity change in the debug ui when editing a read only asset such as templates in package mode

* changelog

* *Update all vfx (had to do it manually...)

* Restore missing enty in hdrp changelog (bad resolve conflict from me)

* Fix 1233044 - capacity cannot be zero (#21)

* Prevent capacity from being 0

* Fix strip capacity as well

* Vfx/fix/param order (#22)

* Fix for dragged parameters order when there are categories

* changelog

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix minor issue with VFXPreviousPositionBinder.cs (#23)

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/fix/sgoperator create context drag (#28)

* Prevent from creating a context in VisualEffectSugraphOperator by draggingfrom an output slot.

* changelog

* Vfx/fix/context no blocks (#27)

* Don't show block windows when context cant have blocks (output mesh )

* changelog

* PropertyBinder : Minor Fixes (#29)

* Fix for binder when null asset & fix for binder while resetting

* Call ClearPropertyBinders while resetting

* Add Update Modes & Time Access (revival) (#4)

* Squashed commit of the following:

commit d77638ba4188bfb03c81130b82cacb2a719f03be
Merge: 49eaeadff7 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 09:46:59 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 49eaeadff7b22d48f26d3b1aa528a9c650ec1cc5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 14:53:09 2020 +0100

    Update UX for new time access (#260)

    https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256#issuecomment-18280
    See slack discussion : https://unity.slack.com/archives/G1BTWN88Z/p1584622775185300?thread_ts=1584523980.160500&cid=G1BTWN88Z

commit 78d5d9938d9896d517efa89662764afd44ef12fc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 16:03:26 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/256/files#r43060

commit bc7e715b0e41b55126fdf171b7459b680e3e3824
Merge: 9a82a52bfe ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 14:52:03 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 9a82a52bfe2384ef5f03344f8c68516f9fd57d88
Merge: f56986d415 66df0debfc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 13 09:17:53 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit f56986d4157f140ca84b039d97c8b7064a18214e
Merge: 047820690f 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:25:07 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 047820690fa496bd43d3a60df16dd0932502c7cb
Merge: d6d17dfbbc e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:56:39 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit d6d17dfbbc65aaa32712b5b16dfa1bf871b5c979
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:59:15 2020 +0100

    Squashed commit of the following:

    commit ec0f1a18fb986005c13e1147938cb5de7fa0f7f8
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Tue Jan 14 13:37:05 2020 +0100

        Use implicit block for old position backup

    commit e786cf3ade7d7515da4569dde9455881af02f282
    Author: Paul Demeulenaere <pauld@unity3d.com>
    Date:   Sun Jan 12 15:05:03 2020 +0100

        WIP : Add option to skip zero delta per update context

commit e864fae742120fbfebabb26b605ddedfd184b02b
Merge: 4eecc0b90b fb12af4c28
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:47:57 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 4eecc0b90bbcf60eb7254c55f23a040ddd2a72a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 16:08:07 2020 +0100

    Rename ProcessEveryFrame in ExactFixedTimeStep

commit 9d3e36a36ad4e79b3f6e6315658e3735196b81ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 16:21:50 2020 +0100

    Fix ManagerMaxDeltaTime (was GameDeltaTime)

commit eaebe2649e93a5083fd62c91ac92185794b908e5
Merge: 98e7dcfcdc 276c02f29a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:42:08 2020 +0100

    Merge remote-tracking branch 'vfxgraph/vfx/staging' into vfx/feature/add-time-update-modes

commit 98e7dcfcdceb710c252e4d1a257815a724539e68
Merge: 248004d55a 0737eb535c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 10 13:26:54 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 248004d55a7b96c6532cd3c197e175b751d6f3fe
Merge: 2bbadae355 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 9 13:12:50 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit 2bbadae355bb3c4a308b8d4e020e96127fa94818
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:07:46 2019 +0100

    Add tooltip to VFXTime.cs

commit 9dc7ea790327b44ffde94bbf783d588e74c50174
Merge: bf48ba84eb 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:29:13 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/add-time-update-modes

commit bf48ba84ebfd1472d041966ba4be627e3a1ef427
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 17:26:30 2019 +0100

    *Update changelog.md

commit b5d76d5d5d65584fde771213d9a01adc6dd9b856
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 16:10:19 2019 +0100

    Add operator to enable time accesses

commit 1a2fe7b8dc5072dd49d985f045f276385e08287f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 11:25:52 2019 +0100

    Add built-in expression (but not listed)

commit b0d0e64ee04036adf48f4481bfd22eace649bac3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:37:50 2019 +0100

    Add some header

commit 490a441046a227bb1cc1b98418d0559da17d3771
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:36:57 2019 +0100

    Add tooltip & text content

commit 621c5b2b78545800b2e94921b9314ef860992059
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 19 10:09:32 2019 +0100

    *Add custom inspector to edit update flags efficiently

* Fix build (VFXPropertyAttribute.Create isn't needed anymore)

* Fix editor test

* Read Attribute in Spawn Context  (#6)

* Squashed commit of the following:

commit 9d42330b20431b0ff5c4a5e5a90bf293635ab4a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 11:14:14 2020 +0200

    *Update image reference (having issue with standalone, not sure of the result)

commit 275c22de35f08ada783c96c625b12475f0c42337
Merge: 85254f1ec4 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Apr 3 09:59:48 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 85254f1ec4ffb2c4d0014a2baa52f49f0b97d0f8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 16:21:39 2020 +0100

    *Update image reference due to fix with grapicTest update

commit e361ecfed65e61f07db4af32f4dd22a9d3cb9caf
Merge: d8db341bfb 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:51:43 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsEditor/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/Assets/ReferenceImages/Linear/WindowsPlayer/Direct3D11/20_SpawnerChainingAndLoop.png
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset

commit d8db341bfbd9257e1a5285d200e3eabe24857b01
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:57:38 2020 +0100

    *Apply Formatting

commit f80441dd6b30ef726d46ae2fe32bcf05d208b760
Merge: b3d858ffe1 01f176355a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 5 17:32:49 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit b3d858ffe13b19dc42e1874d8393cf9829a5e2c7
Merge: 0bce44dc9a 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 13:18:58 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	.yamato/upm-ci-vfx_lwrp.yml
    #	.yamato/upm-ci-vfxmain.yml
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 0bce44dc9a694bf36b849efb894e999fa9dc959e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 14:20:03 2020 +0100

    *Fix build

commit 03b0b05d4f86168f97d9e5e34757b79cae6c39df
Merge: 2130ea0ef2 e6fd39c7a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 24 09:47:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 2130ea0ef2186ecdc5692878940d5d6635dca31b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:09:13 2020 +0100

    *Update tooltips (thanks @vlad)

commit f8cdb95f5d2075848e530d997551b69de43f39e0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 14:01:44 2020 +0100

    Rename SpawnerState in SpawnState

commit 3e2b4fd67c4776907e96a8cfa1b9985ee3fab2fd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Jan 13 13:54:24 2020 +0100

    Improve ReadAttribute test to cover NewLoop state

commit 2c515bfde823bfbce87df8a1444e19e5c2327e32
Merge: a9efee24ff bff1b74b59
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 16:32:45 2019 +0100

    Merge branch 'vfx/staging' into vfx/fix/read-attribute-in-spawner

commit a9efee24ff84131c53dc2ba93f1985b02217e3d7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:54:25 2019 +0100

    *Update comment

commit 6b17879881555cd72b3af4463fd907423f92ad7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 14:53:11 2019 +0100

    Throws an exception while detecting unexpected expression flag

commit cbad9212075ec6776cf9d892185dd6ee64f8fab2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:43:33 2019 +0100

    Reorder spawner state operator

commit e2357ac0dee8d71fe9d4a1ad877aa5fe19a5222a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 16 09:35:30 2019 +0100

    Fix issue "Cannot plug in attribute-derived nodes into a spawner block."

commit b06d7f0708e5178cae51e9e8b96f547fc2f4c6b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:58:30 2019 +0100

    *Update changelog

commit 61bd2e5871f23002dd1add024858efdef5e09372
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 15:46:52 2019 +0100

    Update _CCCC test & Rename Spawner State library name

commit 4942912123d795023aacb0363c8e462a2da29943
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 16:58:17 2019 +0100

    Fix test & clean useless code in VFXExpression.Initialize

commit e6d6c593eb27c612a225340615dabe7692f76a00
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:22:31 2019 +0100

    Switch to graphics/vfx/fix/read-attribute-in-spawner for testing purpose

commit f00f740b775f67e9378072744513f3ff920f470d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 15:16:39 2019 +0100

    Update 20_SpawnerChainingAndLoop (this is the only test affected by compilation order change)

commit b7d8e238dd7e05bf99114a980c8584da7985dcf8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:45:56 2019 +0100

    Clean test data & add reference images

commit 6ddb3389f8e62da44ef50de621884b0526e1b8aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 14:17:51 2019 +0100

    Move graphicTest to common files

commit fa21846e7787fec9068c5a18a33dc568df3f7cc9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 11:53:18 2019 +0100

    Separate cleanly per event attribute expressions

commit 80e5259674a011e864e65f13c77ce06f92f33b7f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Dec 6 08:38:41 2019 +0100

    New test for chaining & read attributes

commit 97473daecd146b85eb3c232fffe8141bd0a7f3a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 18:47:20 2019 +0100

    Add read attribute for loop settings (context evaluation)

commit a41a4a6095e9d5791fdbf3e26baf1d871cfc0fab
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 15:30:56 2019 +0100

    Clean expression patching

commit 9af80d22f70443ef0eb1a8d29aef1d0b3bc64ca0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Dec 5 11:45:06 2019 +0100

    Clarify compatibility code for spawner order & random implication

commit 0dcf774f623fb93eb7bc19b06407b88669472443
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 18:42:30 2019 +0100

    Add tricky case in test vfx & fix compatibility code

    TODO : Optimize it & reserve cleaner solution when change graphicTest result is expected

commit 92b5328ab0ea225d0dd86d1443af0e64bae1963e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 16:49:42 2019 +0100

    *Up local test

commit 0984d8a89b5cc8e0daa79765b00392fa4dfff5d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Dec 4 15:22:03 2019 +0100

    Detect & Compute partial evaluation

commit 2d9e7a250a0437c13e5f180e4feb4cc97d47aa5b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:16:29 2019 +0100

    Add spawner State Operator & SpawnCount (even if it's actually an attribute)

commit 0b1c1982a8ed4bb61182aa070561b7f6036bc07d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 15:04:04 2019 +0100

    Add spawner state accessor

commit adb1d6d66172f2d187b577facaf7b2aea4677d13
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 3 11:24:20 2019 +0100

    Add VFXDataSpawner & Use this helper to retrieve read attribute per context while compiling

commit d43ad0e1395d0e51f3583ce9627a72006356e117
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 2 16:19:05 2019 +0100

    Store m_GlobalEventAttributes in VFXExpressionGraph : this data is used to patch VFXReadAttribute

commit 8a25b5fbed33569529d30379fce2acd4da7de88d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Nov 29 16:14:32 2019 +0100

    Backup test asset (temporarily)

commit dcb3efaf885dbbdec317f5a42ace9ace336fded9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 16:37:48 2019 +0100

    WIP : experimenting new concept of Read Attribute expression

* Merge with vfx/staging

* Update VFX

* Misc small fixes (#36)

* Fix strips outputs, spawnIndex and default metallic value

* Increase threshold in particle strip unlit test

* Test for Override resetted (#26)

* *WIP* add test

* Actually add a more legit "prefab" test

* Prepare fix later fix of 1206890 : can't change the C++ without updating this test

* Fix editor test (todo : graft this change to master to anticipate the C++ change)

* Add test to cover https://fogbugz.unity3d.com/f/cases/1232862/ (#20)

* New Test : total time is sum of delta time (#7)

* *WIP Skeletan of new test to check behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Effective test to cover fixing behavior of https://ono.unity3d.com/unity/unity/pull-request/104407/_/vfx/fix/total-time-is-sum-of-delta-time

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/7/files#r51249

* [Fix] Disable reset option (#41)

* Disable reset option

* Add repro case 1251533

* Fix minor issue with PreviousPropertyBinder (bis) (#31)

* Fix minor issue with VFXPreviousPositionBinder.cs

* Fix exception in OnEnable

Note : I didn't try it locally yet.

* Actual fix of VFXPreviousPositionBinder.cs

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix culture issues when generating attributes defines in shaders (#40)

* [PropertyBinder] Move Update to LateUpdate (#38)

* Fix issue with VFXPropertyBinder : we should use late update instead of Update

* *Update 23_ParameterBinder reference image

* Call resyncslots on shadergraph dependent models. (#10)

* Call resyncslots on shadergraph dependent models.

* missing call to checkgraphbeforeimport

* indentation

* fix slot not updated if only the attributes change

* Do the same for models having subgraphs than for models having shadergraphs.

* Fix based on PR review

* Update CHANGELOG.md

* update vfx and settings

* Renable 009_MultiCamera in URP project

* Easy Wins (Small Workflow / Cosmetic fixes) (#37)

* Properties now exposed by default in blackboard

* Dissociated Colors for bool/int/uint

* Added Degrees / Radians conversion subgraphs in samples

* De-nicified attribute name (conserve case) in Set Custom Attribute title

* Changed the default "No Asset" message when opening the visual effect graph window.

* Subgraphs are not in hardcoded categories anymore + Updated Serialization

* Added Documentation for setting Subgraph Menu Categories

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Vfx/docs/compatability disclaimer (#43)

* Added compatability disc

* Updated format.

* Save a specific vfx asset and its sugraphs only (#35)

* Save graph asset works

* Update CHANGELOG.md

* Update VisualEffectGraphWindow.md

* Update VisualEffectGraphWindow.md

* Fix for block copy not dirtying the scene.

* Remove some unecessary compilation (not all) (#46)

* New TransformVector4 and GetTextureDimensions operators (#18)

* Vfx/feature/new operators 2 (#266)

* Add TransformVector4 operator

* Remove unused code

* Fix warning

* Refactor dynamic type operator

* Samll fix to previous commit

* Add texture dimensions operator and expressions

* Add tooltips

* Add changelog entry

* Fix merge compilation

* Modify point cache test

* Prevent textures from being constant folded

* Move modified test to correct folder

* Output Event (#5)

* Squashed commit of the following:

commit 449a60793a4c5c91e1913c42632448eb07ebe5de
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:27:48 2020 +0200

    Fix stackoverflow with subgraph (but doesn't fix the internal workflow)

commit caf0df3af5f451f9576c2cc7f328b57a87479f30
Merge: bb1047c59a a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 10:22:47 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit bb1047c59a084551e7df3b93d7d5ad501145ecaf
Merge: 7b2890b76f 98ce4878d1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 17:17:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 7b2890b76ffcea3b701568f47b97d02e7d5cb6a3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:54:17 2020 +0100

    Add a check of outputEvent in SpawnerTest

commit 945992b2feff4b8f7a24740944c77a4a92f271dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 19 16:24:56 2020 +0100

    *Update OutputEventTest.cs to check Test_Output_Event

commit c48fda763e807503f27f98deeda4238b6628c264
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 18 10:17:21 2020 +0100

    *Update image reference & Test (stop using a undebuggeable random position)

commit 5a5ad49cb485907ee869445627821810589ab34a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 22:12:58 2020 +0100

    Fix newly integrated spawn test for output event

commit 1f978a4645eb211d6a797c2e30a6ced2dab3e50c
Merge: ef4837245e 47b17e444b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 17:53:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXGraphCompiledData.cs
    #	com.unity.visualeffectgraph/Editor/Models/Contexts/VFXContext.cs

commit ef4837245e1d88846f6d686e2803094d1d6cd04d
Merge: 2331c32fb4 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 08:30:00 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 2331c32fb4b0f33f7f9b5086ffd11917bd5e1cda
Merge: 5d225d6e19 0103971ce2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Feb 6 08:01:06 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 5d225d6e192b32394faf0964ad263cc33c5280cc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:01:51 2020 +0100

    Fix editor test

commit 7d941ea0375fcb27ac7b14cf4df4cf14fde71ff2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 4 15:00:35 2020 +0100

    Add distinct while retrieving virtual link

commit 725252869ac24d962490b4550821fbba2ab119b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Feb 3 14:38:52 2020 +0100

    *WIP* Output test

commit 96098fa11f4781837543fba099936b15a8c7158d
Merge: 02178104a3 bb04ca28fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 31 14:07:02 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 02178104a301fb434d5e6821cd369884bbc01006
Merge: 1443b66691 db8325ba2b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 18:06:20 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 1443b66691d46ed9598ccc26b0b9425d373b61e1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:37:08 2020 +0100

    *Reduce unexpected changes

commit aa1afcafa9c95d042db146043c60015d3f5c96f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 28 17:31:13 2020 +0100

    New UX for output event (use data instead of system name) (#229)

    * *WIP* Experiment for UX using eventName

    * Doesn't work yet but less hacky approach : share automatically vfxdata among output event with same name

    * Remove useless naming pattern linking label & title for output

    Cleaner & Safer implementation for outputEvent edition

    * Use unique system naming

    * Add test for Data for VFXOutputEvent

    * Fix hacky OnInvalidate

commit 9cd41b81cef062991907d5ce446336bde78b79d3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 15:11:39 2020 +0100

    Add editor test to check return value of output event (not attribute, already cover by graphic test)

commit 1a09c63a98e4650b82160e670cedfb06b630284d
Merge: 35126156f2 52ce8b9636
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 22 11:02:45 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit 35126156f2b93b04543de0eb91aca79adf331b2c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Jan 17 13:58:06 2020 +0100

    Avoid exception if system isn't present yet

commit dccc1c5b9a98fa78749f9cd7844266a13478fb3f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Jan 16 10:53:13 2020 +0100

    *Update Test, adding a test on unused source attribute

commit bfd29d8862539cef5b14392e21cbd896436339a5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 20:20:59 2020 +0100

    Add reference to ReadSource in OutputEvent to retrieve all active attributes in spawn context (TODO : cover it in test)

commit d89160df852b64a4b5ecf378c506aa0c9f1c099c
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 16:13:02 2020 +0100

    Filters out orphan output event context

commit 721873c2f0ed0976d081402d6c6e3a45ab4ce0cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 14:30:08 2020 +0100

    *Update changelog

commit cf54e5372e273f86dd5c2e00a6178a543f234fd3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 15 08:40:09 2020 +0100

    Add reference image for HDRP

commit d710998eb133a3dbadbdec580d1ecad3752aca85
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 16:17:28 2020 +0100

    Add reference images for newly added test

commit bc5174dfae9ac396c720b4f30514b12a64ccd0f0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 14 15:23:18 2020 +0100

    *Add a material to unit test

commit 6b332b9afba57eaea64d1f5b55833ba55c6a25c2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 17:02:27 2020 +0100

    Start implementing a effective test project

commit 33e66d45fbb0846ee2d8f9f14d86ef400d0ce4a1
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 16:56:28 2020 +0100

    FIx system name synchronisation (not really ideal)

commit 7782b888266a011f4f986a7bb3161f024730caa7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 14:24:08 2020 +0100

    Fix UI of output event

commit 8c9ec8d65e07fac81da38a1cccb8228cace81e64
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Jan 8 10:11:56 2020 +0100

    Fix build

commit 50ae031af02d4c41e651f64b40e9d265668b803f
Merge: d838cd2d37 8ab634f533
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Jan 7 13:36:21 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/output-event

commit d838cd2d3792ca1c15af86b0385fdade7da9a3a8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 14:58:00 2019 +0100

    Add a wip test scene

commit 459b344b3f97c794d47a8eb6942b1129d18632cd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Dec 24 11:40:30 2019 +0100

    Fill VFXDataOutputEvent

commit e54905485dd553cadcde307ca00a8d7ce8454c0f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 18:21:31 2019 +0100

    Add basic output event type (empty FillDesc implementation for now)

* Change the way we are sharing outputevent to support subgraph (need to update test & merge master before going further) *WIP*

* Update 009_OutputEvent test

* Move 009_OutputEvent to correct folder (TODO, this to rename it before merge)

* Fix sanity test & allow multiple connection from in outputEvent (as initialize)

* Get rid of SynchronizeDataTitleAndEventName, using directly stored value per context

* Fix editor test using eventName instead of tile

* Revert unexpected changes

* *Update from C++ change => VisualEffect.OutputEventArgs => VisualEffectOutputEventArgs

See https://ono.unity3d.com/unity/unity/pull-request/107827/_/graphics/vfx/feature/output-event-with-delegate-squashed#comment-847485

* Rename VisualEffectOutputEventArgs => VFXOutputEventArgs

* Disable connection from OutputEvent to GPUEvent

* *Fix build

VisualEffect.OutputEventArgs => VFXOutputEventArgs
Missing change from : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/5

* Vfx/feature/enum parameter (#8)

* Restart of enum parameters

* more work

* more work

* Still more work.

* reorderable list looks good.

* Adding and removing values works.

* dragging item works.

* Enum values show in the inspector.

* fixes for rebase

* Enumvalue works on subgraphs.

* notify enum name change.

* Added documentation for blackboard value filtering.

* no value per enum

* only uint can now avec enum values.

* don't nicify enum values.

* Update Blackboard.md

* Update VFXBlackboard.uss

* sanitize parameter already having range

* Clamp enum value works.

* Changing switch testValue to uint.

* value appearing as menu if mode is enum.

* Update CHANGELOG.md

* Mutli editor of different values of enum parameter works.

* cpoy paste enumValues and min/max when copying parameter.

* Copy parameter mode when converting to subgraph.

* fix

* Fix IsCompatible for uintproperties. transfer known label width when PropertyRM rebuilt.

* Vfx/docs/new operator docs (#50)

* Added documentation for new operators

* Changed bullet format.

* Fix creation of StringPropertyRM (#51)

* Fix creation of StringPropertyRM

* Update CHANGELOG.md

* Fix input of event emitting block beeing to small because of output

* Multi-mesh output, LODs and compute culling (#14)

* Implement multi mesh

* Add LOD + lit mesh output support

* Small fix + optim

* Fix crash with multi mesh + sorting

* Fix shader compilation with single mesh and compute culling

* implement multi sorting

* Add globalSort parameter

* Fix camera absolute mode

* Fix URP shader compilation

* Add frustum culling to LOD

* Add frustum culling setting

* filter out implicit settings and add tooltips

* Add radius scale + tooltips

* Add a graphics test

* Update change log + lod and multi mesh as experimental features

* Forgot a file

* Small changes based on QA review

* Simulate headers on enum values in SlotContainerEditor (#49)

* Simulate headers on enum values in SlotContainerEditor

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Update VFX

* Fix for blackboard scrollable element hidden by resize.

* Disable LOD test for XR

* Fix test threshold that was reset to 0...

* Ignoer graphviz folder

* Target Gameobject windows resize doesn't go too far above scrollbars

* Missing or incorrect unit in uss.

* fix for reference image "VFX/Execution" not updated to new path ( warning when adding output)

* Change description in package.json to reflect VFX is not out of preview with URP and mobile

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Enable m_CachingShaderPreprocessor (#65)

* *Enable m_CachingShaderPreprocessor

* Try enabling vulkan

* Unify m_APIs in URP & HDRP

* Fix for node window staying when clicking elsewhere (#68)

* Fix for node window stayting when clicking elsewhere

* Update CHANGELOG.md

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix position of block creation window (#72)

* Fix Missing System Seed Builtin (#70)

* Add missing system seed variant

* Add test to cover all builtin expression are available through operator (avoid regression)

* *Update changelog.md

* Fix inconsistant case

* Fix indentation

* Fix Prefab Highlight for initial event name toggle & override (#71)

* Fix prefab blue highlight

* *Update changelog.md

* Add test for Mesh Stripping (#59)

* *Add test data

* Enable StripUnusedMeshComponents: 1

* Enable mesh stripping in HDRP project

* *Add reference images

* Call recreateCopy after recusion test not before. (#52)

* Call recreateCopy after recusion test not before.

* Update CHANGELOG.md

* Uniquify create visual effect gameobject name. Standard behaviour. (#75)

* Uniquify create visual effect gameobject name. Standard behaviour.

* Update CHANGELOG.md

* Use the AssetDatabase.FindAsset to find VFXResources asset (#48)

* Use the AssetDatabase.FindAsset to find VFXResources asset

* Update CHANGELOG.md

* Search VFXResource only if necessary.

* LoadUserResourcesIfNeeded

* Fix changelog merge

* Added feature: User can specify a directory that holds their VFX template assets (#34)

Added feature: User can specify a directory that holds their VFX template assets

Allow VFX artists to specify an asset directory that holds their own VFX templates aka Systems. This expands on the Systems functionality seen in the Node menu.

## How to use
The user directory is set in the menu: Edit -> Preferences -> Visual Effects -> User Systems
![image (1)](https://github.cds.internal.unity3d.com/storage/user/2318/files/d738c680-a1bb-11ea-94d4-68711743821d)

Open a VFX asset in the VFX Graph. Press spacebar to open the Node menu and note the new User Systems option.
![image (2)](https://github.cds.internal.unity3d.com/storage/user/2318/files/20891600-a1bc-11ea-8ab4-831989aef9df)

This option points to the User Systems directory specified by the user. This option will only show up if the user has set the directory to a valid location. It supports nested folders.
![image (3)](https://github.cds.internal.unity3d.com/storage/user/2318/files/4d3d2d80-a1bc-11ea-954f-4c29da91253f)

Compare this to the folder structure in Assets. Note that empty folders and folders not containing VFX assets are not displayed:
![image (4)](https://github.cds.internal.unity3d.com/storage/user/2318/files/7cec3580-a1bc-11ea-86e1-fa3154e108a2)

* Vfx/fix/1246989 normals and scale (#81)

* Fix normal for lit mesh and non uniform scales

* Use inverse transpose in planar primitives

* Fix planar primitive with non uniform scale in local

* Add gfx test

* Add comment

* Update changelog

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context

* Add case to changelog

* Temporarily deactivate non uniform scale test (Some files were lost :()

* [Test] Enable test to cover properly reset override behavior (#80)

* Renable test to cover issue 1206890

* Fix newly introduced test : Exepcted value is original after reset override & handle correctly color

* int and uint support in Compare (#53)

* Add int and uint to Compare node and condition expression

* minor fixes

* Change SerializeType so that tests are correct against System.Type and null

* Fix switch

* Update changelog

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching (#78)

* Fix square complexity on parameter to serialized property matching

* Update CHANGELOG.md

* Fix vfx view not beeing framed at launch (#79)

* Fix vfx view not beeing framed at launch

* safer implementation

* Update CHANGELOG.md

* Fix for the lookup of mixed values in the VisualEffectEditor with obj… (#84)

* Fix for the lookup of mixed values in the VisualEffectEditor with objects that can be null

* Update CHANGELOG.md

* SampleSDF operator (#88)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be di…
PaulDemeulenaere pushed a commit that referenced this pull request Nov 17, 2020
PaulDemeulenaere pushed a commit that referenced this pull request Nov 17, 2020
sebastienlagarde added a commit that referenced this pull request Nov 18, 2020
* Fix for blackboard scrollable element hidden by resize.

* Target Gameobject windows resize doesn't go too far above scrollbars

* e3ba0e6 - Missing or incorrect unit in uss.

* [VFX] Fix crash on NDA platform : 100_Fog (#1265)

* Disable noperspective flag for driver issue on NDA platform

* Add minor note to track the actual issue

* Isolate on concerned platform

* Change define condition

* Simplify linear drag (#67)

* Simplify linear drag

* Fix warning

* Vfx/docs/system requirements (#69)

* Added system requirements documentation.

* Corrected phrasing

* Added toc entry

* Reorganised toc entry

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix for node window staying when clicking elsewhere #68

* Prevent resourcehistory from beeing set to null by serialization (#66)

* Fix position of block creation window (#72)

* Fix Prefab Highlight for initial event name toggle & override #71

* Call recreateCopy after recusion test not before. #52

* Uniquify create visual effect gameobject name. Standard behaviour. #75

* Vfx/fix/1246989 normals and scale (#81)

* Fix Texture2DArray and Cubemap exposition from sg in output mesh context (#76)

* int and uint support in Compare (#53)

* Added render pipeline compatability table (#87)

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix square complexity on parameter to serialized property matching

* Fix vfx view not beeing framed at launch

* Fix for the lookup of mixed values in the VisualEffectEditor with obj…

* SampleSDF operator (#88)

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* Fix Construct Matrix on GPU (#102)

* Remove Debug Log

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* Setting ZClip in shadow caster templates (#99)

* Fix and reenable test (#117)

* Fix spawner set attribute/ custom category (#115)

* Fix non uniform scale test (once again)

* Fix cascaded type popup width (#124)

* Forbid creation of context in VisualEffectSubgraphBlock through edge … (#119)

* Make sure m_DependentDirty is flagged when the strutu change because kExpressionGraphChanged is not send for subgraphs. Cleanup (#121)

* Fix overlap in properties (#128)

* Fix Sample installation in URP #122

* Four bug fixes for event tester (#123)

* Reset the indentLevel at the end of VisualEffectEditor, also better c… (#127)

* Un edit nodes that are collapsed (#133)

* Fixes https://fogbugz.unity3d.com/f/cases/1268956/ (#125)

* Create new VisualEffect Graph" creates a graph

* fixed spelling (#142)

* Fix Several issue in Property Binder (#106)

* Add one pixel to height in non wide mode so that margin is equal to wide mode. (#145)

* Fix 1285603 View and Object mode of Shadergraph position node don't r…

* Fix collapse exception and added automated test (#149)

* Misc fixes for vfx shadergraph integrations (#130)

* Small fix for collapse test

* Fix 1255182 Compile errors using Baked GI (default UV settings) / Output Particle Mesh / Connected Attributes (#139)

* Update rebuild all script to take subgraph into account

* Fix suitableContext for subblocks not being serialized

* Fix subgraph not being sanitized at import

* [HDRP] Fix debug view material (albedo/normal/...)

* Force ui update when shader might be reimported in StaticMeshOutput (#158)

* Revert "Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)"

This reverts commit 84ad80d.

* Fix compil

* Backout int and uint support in Compare (#53)

* Override VFXPropertyAttribute equals to make it correct. (#73)

* Override VFXPropertyAttribute equals to make it correct.

* Update CHANGELOG.md

* 8.x.x Fix compile loop in vfxoperator by adding a RecreateCopy mecanism (#63)

* fix 8.x.x/vfx/sugraphoperator compile loop

* Update VFXSubgraphOperator.cs

* Fix changelog

* backout SampleSDF operator (#88)

* Fix some tests (8 and 26)

* Update HDRP VFX + meta

* Update URP project + add missing metas

* *Update HDRP_Debug considering the blending is enable for debug material

* *Add missing standalone 28_CameraProject.png

* *Increase treshold for 26_NonUnifomScale.unity

Co-authored-by: Tristan Genevet <tristan@unity3d.com>
Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>
Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>
Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>
Co-authored-by: Ludovic Theobald <ludovic.theobald@unity3d.com>
Co-authored-by: Gabriel de la Cruz <gabriel.delacruz@unity3d.com>
Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
PaulDemeulenaere added a commit that referenced this pull request May 5, 2021
* Fix Shadow compilation using shaderGraph (URP/HDRP) (#77)

* *Prepare a proper way to test different shadow cases

* prepare a shadow graph unlit (modifying alpha)

* Add reference data for shadow test

* Minimal data for reproduce issue 1259511

* Fix shadowpath using common integration of PassDepthOrMV & adding VFX_PASSDEPTH_SHADOW define

* *Update ShadowMaterial

* *Update ShaderGraphShadow.vfx

* *Move shader to common testing asset

* Add equivalent test for URP

* Add graphicTest for URP

* *Update reference images

* Fix display of alphaTreshold slider with shaderGraph : only if transparent using motionVector or shadowCasting

* Fix alphaClipping condition (will require validation of @shader-graph) : use proper boolean synchronized instead of testing slot presence

* Fix incorrect block listing

* *Update changelog.md

* Fix pass selection for lit effect

* Early remove ports which aren't active in VFXTarget : save code compilation & cleaner solution

* Voluntary add disabled branch on shadow unlit to cover alphaTreshold case

* *Minor comment

* Fix return alpha clipping (missing actual alpha test enabled)

* *Restore deleted file (to minimize change in MR, these files can be directly deleted on vfx/staging)

* VFX Graph Bugfix for shader compilation error in scene selection pass: 'Shaderpass should be defined at this stage.'

# Conflicts:
#	com.unity.visualeffectgraph/Shaders/ParticlePlanarPrimitives/PassDepthOrMV.template

* Revert unexpected change iVisualEffectGraph_HDRP\ProjectSettings\EditorBuildSettings.asset

* *Update reference image & Fix treshold for URP scene which was really too low (set to default 5e-4f)

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/77#discussion_r69288

It was a bad merge

Co-authored-by: pastasfuture <pastasfuture@gmail.com>

* Fix UInt/Int Condition Reduction (PS4/X1 issue) (#96)

* Fix missing type copy in reduce

Tested locally on a PS4

* Add expection to detect unsupported value type

* Fix 1154328 - infinite recompile with rand (#93)

* Change the way rand expression equality is handled

* Refactor a bit

* Add editor test

* World to Viewport Point & Viewport to World Point operators + Test (#98)

* World to Viewport Point & Viewport to World Point operators + Test

First implementation of World to Viewport Point operator and its reciprocal Viewport to World Point operator.
Includes a test scene for these 2 operators.

* Update CHANGELOG.md

Update Changelog

* Added documentation md files.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Make null ( not deserializable ) objects part of undo state (#86)

* Fix compile loop in vfxoperator (#61)

* Update to visual studio package 2.0.2 (#74)

* Fix SDF Operators and blocks from PR #88 (#94)

* Operator creation, does NOT sample an SDF

* First implementation of the sampleSDF operator, might not be optimised

* Delete VFXExpressionSampleSDF.cs

* Updated Test Graph

* Better handling of out of bounds queries for normals and distances

* Delete HDRenderPipelineEditorResources.asset

* Delete XRPackageSettings.asset

* Assumption that the SDF is baked in the world space, in a box matching the orientedBox given as input

* Update 27_SampleSDF.vfx

* Update 27_SampleSDF.vfx

* restored the deleted asset

* Enforces and apply the 4 parents max rule

* Removes the return statements in branch

* Revert "restored the deleted asset"

This reverts commit 57757b5a3ed4c303c34dc7dc920ad6d0328fcfdb.

* Revert "Revert "restored the deleted asset""

This reverts commit 7753b4e85aba5d75e8af659aedc66515a0c56e20.

* Fix compilation error and warnings

* Fix Pascal case

* Fix Pascal. Really.

* Revert "Revert "Revert "restored the deleted asset"""

This reverts commit daf8b79a78f55b47b6bd85afd9008a57d96f50f1.

* Uses the Inverse-Transpose matrix for SDF related normal transformations (for non uniform scaling)

* Delete packages-lock.json

* Revert "Delete packages-lock.json"

This reverts commit 4a10123f3171d6cf981c5effa52128ebb1411735.

* Revert "Revert "Delete packages-lock.json""

This reverts commit 84d700f0f1fde91d4ad5a6ab87f3946216f883f4.

* Restore this mistakenly modified file

* Update 27_SampleSDF.vfx

* Get rid of useless transpose

* Added Graphic Test

* Added reference images

* Fix incorrect out-of-bounds check  + auto recompile

* Added reference images

* Clarify the name of the output

* Remove the use of inverse transpose for the "normals"

* Restore the Inverse Transpose and modify Collision code

* Restore Conform and Collide previous behavior + direction points to the surface

* add documentation

* Consistent distance and normal handling + ref images

* Cleaning + World space stick distance and radius + references

* Max scale through expression evaluated on GPU (if needed)

* Max3 on CPU

* Fix Mesh Sampling for PS4/XOne (ByteAddressBuffer) (#91)

* Simpler update to use now available ByteAddressBuffer

* Temp Workaround a GPU hang

We should isolate properly this code.

* Proper fix of OOB FetchBuffer

* *Update changelog.md

* Update assets

* Update URP tests assets

* More update to assets

* Remove old gfx tests images ref

* Fix changelog

* Fix Construct Matrix on GPU (#102)

* Fix VFXExpressionVector3sToMatrix & VFXExpressionVector4sToMatrix evaluation on GPU

* *Update changelog.md

* Output Event Helpers (#58)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Add support for Gradient sampling with and without gradient mode #100

* Fix changelog

* Fix case 1279294 : Invalid Random per component behavior in spawn context (#107)

* Revert "Output Event Helpers" (#110)

* Revert "Output Event Helpers (#58)"

This reverts commit eb830bbf40be2dc6b696aa72885446c05ad9bf78.

* Revert "Fix changelog"

This reverts commit f6fd8a5183b75caf04f9a3544bd5da9e5aa11137.

* Fix changelog (missing revert)

* Fix changelog : Unexpected carriage return

* Point cache: Binary format corrupted due to an extra byte offset (#108)

* Point cache header, wait for new line character only (/n) and skip carriage return(/r)

An extra trailing new line character was causing an invalid offset in binary point cache files.

* Update Changelog

* Remove unnecessary files

* Fix InvalidCastException when using byte properties in point cache files (#109)

* Change casting to byte

We were trying to cast an object containing a byte to an int.
Also, a better normalization would be dividing by 255.

* Update CHANGELOG.md

* update asset and scripts

* Remove unwanted files

* Output Event Helpers (revival) (#111)

* Base Commit

* Moved Files down one folder

* Updated Package Configuration, CHANGELOG and documentation

* Fixed Behavior of ExposedProperty by implementing a simple Drawer / Debug Behaviour

* Small fixes and checks

* Updated Documentation / Renamed Attribute handler RigidBody to RigidBodyVeolcity + Safe check

* Small Fixes

* Added the Execute In Editor Capability + Custom Inspectors in order to handle the capability correctly

* Other custom Editors + Helpbox

* Added CMCameraShake Editor + Capabilities / Fixed Possible Circular Reference in  Prefab Spawn

* Removed Rerouting Helpers as CopyValuesFrom is broken at the moment.

* Fixed ASMDEFs / class accessibility

* Updated Documentation

* Fixed Class Accessibility for ExposedPropertyDrawer

* Updated Changelog (missing entry for Exposed Proeprty Custom Property Drawer)

* Revert "Revert "Output Event Helpers" (#110)"

This reverts commit e72745d0ce4df6205dffa8aca7332a8afea96880.

* Revert "Revert "Output Event Helpers" (#110)"

This reverts commit e72745d0ce4df6205dffa8aca7332a8afea96880.

* First pass of coding rule validation

* Rename VFXOutputEventHandler in VFXOutputEventAbstractHandler

Following coding rule from https://ono.unity3d.com/unity-extra/unity-meta/files/@/ReferenceSource/CSharp/Assets/CSharpReference.cs

* *Missing rename

* Remove useless member

* Rework VFXOutputEventPrefabSpawn :

- Avoid any inconsistency with transform
- Use prefab link when available
- Use a lazy approach and lock editable values to editor

* Fix issue with "Open Prefab" which was resetting the "Hide Flag"

* *Minor cleanup

* *Minor Change

* Missing DisposeInstance when we are disabling "Execute In Editor"

* Fix missing full stop at the end of all tooltips

* *Apply auto formatting

* Fix spamming null reference error reported by @vlad

https://unity.slack.com/archives/GA2Q6JU1X/p1601055259085900?thread_ts=1601044036.085800&cid=GA2Q6JU1X

* Safely fallback on Instanciate when InstantiatePrefab returns silently null

Instance of prefab within the scene are actually copies because an override could have been applied.

* Fix model spawn using NotAPrefab instead of Regular

* Expliciter code in VFXOutputEventPrefabSpawn

Doesn't change the internal behavior

* Minor fix : audio != null isn't equivalent than audio?.

* Fix assignement : prevent setting audioSource or rigidBody from a prefab asset

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/111#discussion_r73827

Use explicit DrawOutputEventProperties to avoid multiple serializedObject.Update per Inspector

* Minor : remove unexpected carriage return

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>
Co-authored-by: Thomas Iché <thomasi@unity3d.com>

* Fix spawner set attribute/ custom category (#115)

* Fix spawner set attribute/ custom category

* Update CHANGELOG.md

* Update CHANGELOG.md

* Setting ZClip in shadow caster templates (#99)

* Setting ZClip in shadow caster templates

Shadows from directional lights where culled by the near plane in some cascades
Added ZClip [_ZClip] to every PassShadowCaster.template file.

* Update CHANGELOG.md

Update changelog

* Modify graphic test for vfx shadows to test ZClip

Added an extra particle mesh output that could potentially be clipped by the near plane in some cascades

* Trigger output can start an edge drag [Case 1271691] (#114)

* Trigger output can start an edge drag [Case 1271691](https://fogbugz.unity3d.com/f/cases/1271691/)

* Update CHANGELOG.md

* Fix and reenable test (#117)

* Error display in vfx editor (#33)

* First commit for link impossible explanation.

* Some cleanup, delay before info appear. info appear always in the view.

* added error management when linking a GPU operator to a CPU slot.

* added uninitilized attribute message with context granularity.

* Alert when a context a context slot, a block or a block slot use an attribute that is not initialized, except for a known list of attributes with good default values (TBC).

* adding age to the list of attributes with good initial value

* fix errorr message bases on vlad feedback.

* fix for rebase

* use RequireInitialization Flag on attributes instead of list of attribute name with good value.

* really remove attribute with good default values.

* Fix for rebase

* fixes based on PR review

* cleanup based on PR comments

* Move resources for this PR to Editor Default Resources

* fixes for merge

* Work on error handling for invalidate

* Compile and Invalidate Error works.

* add ignore error

* Make sure non ignored error are visible at start

* make sure error indices are unique.

* clear unwanted diffs

* Fixes for merge

* fixes for uss warnings.

* Remove incrorrect code from VFXGraph.cs

* Fixes based on PR review.

* Removed VFXErrors

* Started working on drag ignore for refresherrors

* Drag on filed label on refresherrors once.

* Slider drag do not trigger a refresh error

* Remove debug log.

* Removed useless line

* Update CHANGELOG.md

* Fix editorTest which cover copy/past without a graph attached to the controller

* Add missing meta

* delete Editor/Resource empty directories and metas

* Removed VFXBlockDataAnchor from this branch as a bad merge readded it.

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

* *Add missing reference image & fix changelog bad merde

* Fix bad merge : unexpected change in "ConstantBuffer.cs"

* Fix non uniform scale test (once again)

* Update assets

* Update URP assets

* Increase error threshold on test 26 (due to sky)

* Fix reference images for shadow test

* Fix cascaded type popup width (#124)

* Fix cascaded type popup width

* Update CHANGELOG.md

* Be resilient to possible null subgraph references. (#120)

* Be resilient to possible null subgraph references.

* Update CHANGELOG.md

* Update CHANGELOG.md

* Fix 101_Exposure on PS4 (#126)

* Fix wrong code generation from PSSL

* *Update changelog.md

* Remove inout BuiltInData which is a bit counter intuitive

Bonus : Remove VFXClipFragmentColor which was done twice.

* Forbid creation of context in VisualEffectSubgraphBlock through edge … (#119)

* Forbid creation of context in VisualEffectSubgraphBlock through edge dropping

* Update CHANGELOG.md

* Make sure m_DependentDirty is flagged when the strutu change because kExpressionGraphChanged is not send for subgraphs. Cleanup (#121)

* Fix overlap in properties (#128)

* Fix overlap in properties

* Update CHANGELOG.md

* Fix bad merge from c72287dfdb8c9b041db6c6d49582241810c73a9b

Wrongly formed meta files

* Fix Sample installation in URP (#122)

* Fix RecreateCopy since subouput are conserved

Regression introduced at 273b6e32cac0e7ad19b7c8dbbed08593e39fe4f8

* *Update changelog.md

* Four bug fixes for event tester (#123)

* Fixe some bugs on event tester window

* Update CHANGELOG.md

* adding another bugfix

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Fix for displaying error from the creation of a node. (#131)

* Fix for displaying error from the creation of a node.

* *Add warning for CollisionDepthBuffer

Update & Fix Changelog.md

* Update message from @vlad suggestion

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

* Blackboard improvements ( clear unused properties, add output ) (#45)

* Added clear unused properties menu

* added add button to outputcategories.

* unused properties are greyed in the blackboard.

* Fix from PR review

* Update CHANGELOG.md

* Fix

* Menu for blackboard separated from menu for Pills no more triple dot menu.

* Fix unwanted changelog changes

* reset modified icon meta

* Delete Parameter in Blackboard deletes all selected parameters.

* Fixed weird blackboard field selection behaviour on Windows

* Reset the indentLevel at the end of VisualEffectEditor, also better c… (#127)

* Reset the indentLevel at the end of VisualEffectEditor, also better criteria for doubling the width when the inspector is not wide enough.

* Conserve original enabled state in VisualEffectEditor

* Update CHANGELOG.md

* Un edit nodes that are collapsed (#133)

* Un edit nodes that are collapsed

* Update CHANGELOG.md

* Update CHANGELOG.md

* Fixes https://fogbugz.unity3d.com/f/cases/1268956/ (#125)

* Block - Position on SDF (#105)

* Initial commit

* Update PositionOnSDF.cs

* Test scene + new SDF assets

* Two step approach for projection, texture margin in expression, new test scene

* Performance improvement

* Revert "Performance improvement"

This reverts commit 42ce897756bcdb3bb279abbd529fa9fe33e49884.

* Modify test scene

* minor changes

* Fixing the output direction

* Add graphic tests

* Update references

* Update CHANGELOG.md

* Fast derivatives, outliers killing option, cleaning

* Convert line endings

* Added docoumentation and supporting media.

* Update PositionOnSDF.cs

* Filename did not match the class name ...

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Fix several URP issue (for 10.2) (#116)

* *Prepare Scene for new sample reflection test

* *Update Scene

* Fix Reflection Probe missing edition

URP only because SupportedRenderingFeatures.active.reflectionProbes is tested

* Filter out rendererPriority if SupportedRenderingFeatures.active.rendererPriority returns false

* Fix missing layer option : correctly fallback to the default layer if srpAsset.renderingLayerMaskNames returns null

* Prepare test addition for RenderDepth

* Fix missing depthpass in URP

* *Add test data

* *Add Test Data for SubPixelAA

* Fix SubPixelAA

* Fix missing warning using Proxy Volume with URP

* Add two sections in inspector to separate probe setting than additionnal

Also add a comment about m_SortingOrder

* *Update 014 before moving this to common

* Add 014_ScreenSpaceSize to HDRP

* *Add graphicTest for URP

* *Add Reference images for player

* *Add missing meta file

* *Add Editor Image reference

* *Update changelog.md

* Add editor test : Check_VFXRenderer_DefaultRenderingLayerNames

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/116#discussion_r78363

* "Create new VisualEffect Graph" creates a graph from the default template [Case 1279999](https://fogbugz.unity3d.com/f/cases/1279999/) (#113)

* fixed spelling (#142)

* Positition on SDF - Graphics Tests Fix (#138)

* Complete .vfx files and update references

* Updated documentation.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Update assets

* Fix changelog

* More changelog fixes

* Add missing warning for other block operator using depth (#140)

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#discussion_r79026

* *Adding missing meta file in TestProject

* Missing doc & Deprecate VFXViewModicationProcessor (#143)

* Fix missing doc & Deprecate VFXViewModicationProcessor

Unexpected public API

* *Revert unexpected change

* Fix several issue from @lewisjordan

- fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/143#discussion_r79397
- fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/143#discussion_r79398

* Fix Several issue in Property Binder (#106)

* Fix case 1274790 : Use DestroyImmediate when editor isn't playing

* Fix case 1247230 : Avoid null exposed property

Property entry is modified by UX always not null, however, it requires a default value

* Fix case 1274788 : Missing null check in Hierarchy to Attribute Map

* Fix case 1248711 : Property window view wasn't working

Missing Update, it also fixes Undo/Redo

* *Update changelog

* Fix compilation when ENABLE_LEGACY_INPUT_MANAGER isn't enabled

Should be fix for 10.2

* Fix case 1279471 : Avoid OnMouseDown/Up/... declaration

Game scripts or other custom code contains OnMouse_ event handlers. Presence of such handlers might impact performance on handheld devices." when building for Android/IOS

* Fix positionDepthOperator ref images

* Add one pixel to height in non wide mode so that margin is equal to wide mode. (#145)

* Update CHANGELOG.md

* Fix API validation

* Harmonize Composition in Position / Velocity Blocks (#44)

* Base refactor + Attempt to get position from AABox (not working for thickness ATM)

* Fixed cone syntax issues + correct computation of AABox direction

* Added Variant providers + Composition in Sequential

* Updated Variants for Shape Sequential Blocks

* Harmonized Namings + added composition to Position Depth

* Updated Changelog

* Fixes for PR

* Fixed Blend Composition in Sequential

* Added Direction to PositionSequential

* Fixes in Position Circle / Set Blend factor in shapes to 1.0 by default

* Used Absolute Box size as expression

* Propal for https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44/files/e029bb9ec37555e70af21a97399774667030c031#r61533

Use case by case approach for direction of AABox

* *Temp add test data for graphicTest

* Fix ApplyAddressingMode : clamp & mirror was overflowing, mirror has also a wrong pattern

* Edit graphicTest

* Move 014 to common package

* Add 014_PositionBlock in editor test listing

* Precompute line_direction in PositionLine

Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44/files#r67908

* *Add reference images

* Fix editor test (wrong reference data)

* Fix issue introduced at 9c54056a68e9ef90354e969e9baba18aa552f8f4 : Looping correctly the circle

See also : https://unity.slack.com/archives/G1BTWN88Z/p1598508170069200?thread_ts=1598429838.039200&cid=G1BTWN88Z

* Probably uploaded the wrong image reference for standalone

* *Update reference images (I think I mess up twice, I should double check the change in motionVector)

* Fix build (VFXExpressionCondition now supports uint)

* *Temp* Delete motion vector reference image, should regenerate them from yamato.

* Readd reference image using yamato result at b9a04b7424323e0c3801e34c13213c4050f020f1

* *Update changelog

Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44#discussion_r70582

* Fix PositionTorus when used in vertex shader

* Fix multiple definition of UNITY_PI

* Fix changelog

bad automatic merge

* Fix incorrect volume

Base radius while computing volume factor on sphere & circle : use fix approach from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/89 using name instead of index
See : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/44#issuecomment-28990 & https://docs.google.com/document/d/1RAVkfmMQA9D_hKkJyt6PKOgRs8JHkjlYRhcfBtIU1Ag/edit?disco=AAAAJ7Z4S18

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>
Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>
Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix 1285603 View and Object mode of Shadergraph position node don't return proper values (#141)

* Update VFXShaderGraphParticleOutput.cs

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix collapse exception and added automated test (#149)

* Misc fixes for vfx shadergraph integrations  (#130)

* Diffusion profile has PropertyType.Float but isn't castable in Vector1ShaderProperty : safeprof code

* Unity serialization produced a beast with object.ReferenceEquals(null) != 0 and instanceID == 0 foolProof code for this

* Update CHANGELOG.md

* Small fix for collapse test

* Some extra security around error feedback (#153)

* Prevent exceptions from making notification stay. Prevent exception in errors to potential break the ui

* Prevent list from being badly deserialized.

* Fix Event connected directly to Output Event (#152)

* Add missing filter in CanLink function

* Add editor test

* *Update changelog.md

* *Update comment

* *Update Comment

* Misc fixes in strips (#136)

* Vfx/feature/strips improvements (#265)

* Add spanwIndexInStrip attribute

* Fix particleCountInStrip in Init

* Add OrientStrip block

* Remove some useless code

* Add From Target Position mode in Orient Strip

* Update changelog

* Fix SpawnOverDistance

* Fix reference images

* Fix changelog

* Merge Orient and OrientStrip blocks

* Remove FaceCameraPlane from strips

* Sanitize quad strip orientation

* Update VFX

* Update changelog

* Add error feedback

* Use IsPerspectiveProjection

* Fix GetStripTangent for lines

* Add subpixel AA to head and trails template system

* Add strip variant for intialize in menu

* Fix for errors not appearing after convert output

* Update graph version

* Fix ribbon VFX

* Fix spawnIndexInStrip (tooltip + init)

* Fix issue with inspector not triggering OnSettingChanged

* Check that a converted output could keep the same flow links.

Co-authored-by: Tristan Genevet <tristan@unity3d.com>

* Revert adaeba7f20802aa19fe089463e1abfaf2a0488e6

* update vfx

* Update URP assets

* Update URP ref

* Vfx/fix/additional subgraphs 2 (#155)

* Updated Changelog

* Updated Blocks with Fixes and Missing Workflows

* update VFX additions

Co-authored-by: Thomas Iché <peeweek@gmail.com>

* Fix 1255182 Compile errors using Baked GI (default UV settings) / Output Particle Mesh / Connected Attributes (#139)

* Reindex the TEXCOORD[n]

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix serveral minor issues (#103)

Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458987790
Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988272
Fix issue https://github.com/Unity-Technologies/Graphics/pull/1131#discussion_r458988870

* Update rebuild all script to take subgraph into account

* Update VFX assets

* Fix URP vfx assets

* *WIP graphicTest

* Renable exact fixed time option

Actual fix in progress, I'm adding a graphicTest to cover problematic behavior.

* *Update test effect

* Share same graph for both mode

TODO : Updat graphicTest frame to allow special case

* *Add settings to scale fixed time step

* *Update fixed time scene

* Fix Event connected directly to Output Event (revival) (#154)

* Add missing filter in CanLink function

* Add editor test

* *Update changelog.md

* *Update comment

* *Update Comment

* Fix regression with subgraph

* Add Subgraph_Event_Link_To_Spawn editor test

* Cover test with prewarm behavior

* Fix changelog

Add entry in the right place from 0009e5373ddd6927977fc8054e2ab16c14b5e81b

* Restore disabled 26_NonUnifomScale due to a wrong merge (need backport to 10.x.x)

* *Update 015 settings & Move force paused in testing repro

* Move 015_FixedTime to common testing package

* Add 015_FixedTime test to HDRP as well

* [HDRP] Fix debug view material (albedo/normal/...) (#163)

* Fix debug view material

TODO : Add GraphicTest

* Fix tab/space mix

* Add HDRP debug scene

* *Add reference image for HDRD_Debug(Property)

* *Update changelog.md

* Use explicitly layer zero for independant system

That's actually the way the runtime assumed

* *Add reference image (yamato & local result strictly identical)

* Force ui update when shader might be reimported in StaticMeshOutput (#158)

* Don't create VFXGraph during import callbacks (#148)

* do not Create VFXGraph in import callbacks

* error when graph missing. Better test code for asset creation

* Add the necessary openasset callback for the system to know if we open the asset inside the editor. (#118)

* Added OnOpenAssetAttributeMode.Validate

* added UNITY_2021_1

* remove the shaders has they are not edited in the editor.

* Fix macro

* Select node on create (#166)

* Select node on create

* Fix for right click in block and add doesn't deselect clicked block

* fix for subgraph not being selected on drag and drop

* Select converted node/block after convert subgraph

* Fix for selection undo separate in some cases. Fixed flow anchor drag context selection.

* Fix for undo of add subgraph operator

* “Refactor”

* "Refactor" bis (some file has been missed)

* Dont flag dirty in vfxgraph is the model modified is a copy (#165)

* Workflow improvement : Change VisualEffect inspector "Edit" button to "New" when no asset is set. (#173)

* Base Commit
* Documentation
* Updated Changelog
* Fixed Typo

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Added excludeFromTAA setting to VFX outputs (#170)

* Added excludeFromTAA setting to VFX outputs

Added excludeFromTAA setting to VFX outputs.
Currently it is only supported in HDRP suboutputs.
Required adding ${VFXStencilForward} variable to forward pass templates

* Update VFXHDRPSubOutput.cs

suport exclude from TAA in transparent only

* Added documentation to exclude from TAA property

* Graphic test

Added graphic test: 32_ExcludeFromTAA

* Update graphic test background for better contrast

* Update CHANGELOG.md

Co-authored-by: Lewis Jordan <lewisjordan@unity3d.com>

* Missing Reference image for test 32_ExcludeFromTAA

* Add test to cover case exposed by 1258022 (#54)

* Fix Custom Spawn serialization (#132)

* Allow Set Spawn Count & Set Spawn Time

TODO : List Spawn count in available variant

* Fix reference lost in m_SerializableType

No idea of implication of this :-/

* Squashed commit of the following: (retrieve fix from @tristan)

commit c24981d7dad15100eb40a92a6a9370e9ba800acd
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Oct 9 17:27:57 2020 +0200

    Update message from @vlad suggestion

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/131#issuecomment-30757

commit a87ba182b30da7683e31a29048c9f2f3a0312927
Merge: 13b501e15863 296ffd333bcf
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Oct 9 09:25:02 2020 +0200

    Merge branch 'vfx/staging' into vfx/fix/error-at-creation

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit 13b501e158634dfc98b96058723d248cd5d1f34d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Oct 9 09:24:27 2020 +0200

    *Add warning for CollisionDepthBuffer

    Update & Fix Changelog.md

commit 4bfb1e7c9874d8a9403ca5267d1e10735e52a87b
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Thu Oct 8 18:10:42 2020 +0200

    Fix for displaying error from the creation of a node.

* Add error feedback on failing custom spawner reference

* Revert "Allow Set Spawn Count & Set Spawn Time"

This reverts commit 0a6c75cc54072b831dcc56bffc3bbe04734d3324.

# Conflicts:
#	com.unity.visualeffectgraph/Editor/Expressions/VFXAttributeExpression.cs

* Remove unexpected change

* *Revert change in changelog

* *WIP* add ResolveCustomCallbackInstance

Some refactor mark as "TODOPAUL"

* Clean implementation : customBehavior & comment

* *Add test to cover sanitize before modify references

* Change namespace for builtin custom spawner & sanitize

* Extend test to verify connexion

* *Update changelog.md

* Add specific error if customBehavior returns null

* Fix corner case when ScriptableObject reference has been lost

* Work but not idea with copy/past + potential leak

* Better implementation : use directly "MonoScript"

* Fix spawnerTest

* Rename "Can't found" => "Can't find"

* Fix case 1294180 : Error feedback throwing an error while changing capacity (#174)

Issue introduced with https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136
And more precisely https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/136/commits/27c041da92ec89407ae775fe4c4f24681f156cb8

* [Test] Add test to cover "Thread Group Size" error (#104)

* Add test

* Add test to cover behavior from case 1271839

* Fix Preset (with exclusion) (#177)

* Trick ExcludeFromPreset

Since this attribute is declared with "Inherited = false", we can't use it directly on VFXObject.
Extend the VFXInfo is valid to filter out preset.

* Fix missing ExcludeFromPreset for subgraph

* *Update changelog

* Fix 1276602 incorrect uchar pcache import (#129)

* Base Commit

* Updated Documentation with explicit limitations.

* Fixed incorrect Merge

* Add regression Test

* Removed Test as It can't handle Exceptions thrown in Custom Importers

* Fixed value divider

Co-authored-by: Thomas ICHÉ <peeweek@gmail.com>

* Update gradient test (#151)

* Update gradient test

* Update CHANGELOG.md

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Sample Point Cache Operator (#92)

* Initial commit

* Overflow handling options for the user

* Addressing mode for overflow to the choice of the user

* Foldable to Constant value

* Update 09_PointCache.vfx

* Added reference images

* Remove float-to-integer conversion

* Put the choice of the output type in the Inspector only

* Simplify output type handling

* Sample Point cache != Attribute map => two operators

* Update Branch (error .yamato/docs/editor_pinning.png)

* Update SamplePointCache.cs

* Update 09_PointCache.vfx

* Output type set in a cogwheel

* Update 09_PointCache.vfx

* Revert "Update Branch (error .yamato/docs/editor_pinning.png)"

This reverts commit 02f6b6c993c2382bb10669edd16f7d06876a0cbc.

* Restore vfx asset

* Revert back to using generics for type handling

* Update SampleAttributeMap.cs

* Reformating + changelog

* Update 09_PointCache.vfx

* Update SamplePointCache.cs

* Refactor of AttributeFromMap using VFXExpressionSampleAttributeMap

* Merge branch 'vfx/staging' into vfx/feature/sample-point-cache

* Revert "Merge branch 'vfx/staging' into vfx/feature/sample-point-cache"

This reverts commit b4a03e182a3e106c2fabc262777615f9c3b94a7e.

* Fix point cache vfx + update HDRP vfx

* Update URP assets

* Fix changelog

* Fix Case 1223747 - NaN caused by normal bending (#181)

* Update Pass.template

* Update CHANGELOG.md

* 1293608 - Fix LPPV not working in deferred (#180)

* Enable LPPV in HDRP test project

* Fix LPPV for gbuffer pass

* Add graphics test

* Update changelog

* Fix 1290493 - Spaceship specific warnings (#176)

* Avoid implicit trucation in template + safe normalize setting

* Update CHANGELOG.md

* Added variants

* Delete conditioning on GPU evaluation + conservative safe normalize

Co-authored-by: Julien Fryer <julienf@unity3d.com>

* Fix incorrect compilation condition for linux build (#184)

* Fix formatting

* Update 26_NonUniformScale kind of sky : gradient instead of procedural

* Fix regression from https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/176

Issue introduced at 44f497b438b46a54072721d335910bfab3e392ef : Incorrect VFXExpressionCondition
See also : https://unity.slack.com/archives/G1BTWN88Z/p1607963794139900?thread_ts=1607955907.136600&cid=G1BTWN88Z

* Disable Gradient Sky in 26_NonUniformScale & 33_LightProbe

* *Update VFX (newly introduced safeNormalize, default 0)

* Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA

* Revert "Add VFXGraphicTest settings to disable XR for 32_ExcludeFromTAA"

This reverts commit ddee2e356dc7e529cad2904836fef8a688e546a8.

* 32_ExcludeFromTAA : Disable XR

* 33_LightProbe : Slighlty increase treshold from 0.0005 to 0.0006

* *Update Image Reference for D312 (mainly missing file)

* *Disable 32_ExcludeFromTAA

Instability detected.

* *Add missing D3D12 image references

* Fix GPUEvent & SubGraph (#178)

* Fix SelectionHasCompleteSystems

Detect correctly if there are dependencies due to GPUEvent (or stripAttribute)

* Add allDependenciesIncludingNotCompilable in VFXData

This helper is usefull for UI + use it in SelectionHasCompleteSystems

* Add note without change the beahvior

* Remove debug ToArray()

* [Subgraph] Prevent Pasting Context invalid subgraph (#191)

* Prevent pasting context within operator/block subgraph

* Fix case https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/191#discussion_r102007

Fix Approximate english log warning

* Update VFXPaste log message

Missing "the"

* Fix Mouse Event Binder in player (#175)

* Fix missing call to CreateVFXEventAttribute

OnValidate is only called in editor, in runtime, we should init cache data with OnEnable

* *Update changelog.md

* Add editor test to cover Safe Normalize behavior (#189)

* Vfx/docs/bugfixes (#188)

* Resolved 1272101

* Resolved 1264943

* Removed uncertainty around 'should'

* Resolved 1298031

* Added snippets file

* Resolved 1292127

* Fixed typos

* Resolved 1295296

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Texture2D Array Layout for Flipbooks (#97)

* Initial commit, working for planar primitives only

* Increased support to Cube, Decals, Meshes, Lit Planar Primitives, Lit Meshes

* Correct handling of depth pass

* Added Reference images for test

* Added graphic test / restore defaut HD Material

This reverts commit 1d8c36af255f41e515cbe3c87ea691125cd43077.

* Update Test References

* Added Tooltips, simplify input type selection

* Fix handling of Lit Mesh output

* Automatic Flipbook size for Array Layout

* Delete the flipBookSize slot when Texture2DArray is set

* More explicative Tooltip + end of flipbook blend fixed

* Update CHANGELOG.md

* Distortion Quad and Mesh output support

* Update VFXAbstractParticleHDRPLitOutput.cs

* Retrieve changelog from staging

* Added entry

* Motion Vector generation improvements (#194)

* Added VFX_FEATURE_MOTION_VECTORS_VERTS mode to store motion vector info per vertex

Optimized default motion vectors mode to store 4x3 matrix instead of 4x4.
Added mode to store each previous vertex position for quads, triangles, lines and points.
Refactor of motion vector defines.

* Motion vectors support in lines and points

* Resize buffer according to the element size

* fix points and lines when not using the optimization

* Fix motion vectors for lines

* Changes suggested in review

- Removed misplaced comment in VFXLineStripOutput
- Access VFXLineOutput useTargetOffset through GetSettingValue in VFXOutputUpdate
- Moved previous frame position calculation to the end of OutputUpdate compute
- Added 4 bytes per particle for last frame index in elementToVFXBufferMotionVector buffer
- Added noperspective when using VFX_FEATURE_MOTION_VECTORS_VERTS, through VFX_FEATURE_MOTION_VECTORS_INTERPOLATION define.
- Fixed order of verts in lineSW particles.

* Missing define rename in ParticleMeshes/PassForward.template

* Improved condition for discarding due to not enough indirect buffers

* Missing renaming of WRITE_MOTION_VECTOR_IN_FORWARD for particle lit meshes

* Spawn State documentation  (#195)

* Added Spawn State doc

* Fixed formatting

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* Added what's new page and moved blocks out one level in the table of contents  (#199)

* Added what's new documentation for version 10

* Updated image and minor rewording

* Added link from what's new to node library

* Updated changelog link

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* HDRP - Fix Debug View Material (#182)

* Fix fallback (?) depth state in debug view material

Not sure about this : should double check with HDRP team

* *Update changelog

* *Updare reference image

It corresponds to the result in 7.x.x & 8.x.x

* *Apply reformat

* *Apply reformat (bis)

* Fix CameraFade for shadows (#179)

* Fix CameraFade for shadows

+CameraFade was taking the distance to the light when rendering the shadow map.
+Added setting to optionally affect shadow, with warning for multiple cameras
+Implemented functions to get camera position and direction

* Update CHANGELOG.md

* Update CameraFade.cs

-Change fade default value to false.
-Fix behaviour when affect shadows is false

* Update documentation

Added Affect shadows setting

* Update documentation

Modified AffectShadows setting description following @lewisjordan suggestions

* Move camera functions to VFXCommonOutput

* Remove ${VFXFragmentCommonFunctions}

${VFXFragmentCommonFunctions} was used only for the VFXCommonOutput.hlsl include, which is now generated by VFXCodeGenerator as part of ${VFXPerPassInclude}

* Correct Sign operator node output for float when input is 0.0f (#190)

* Changed specialization for floats to be consistent with others.

* Update CHANGELOG.md

* Update test

* changed sky, emission scale, and updated references (#203)

* Fix ProcessOperatorSign test

Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/190 & this change 1d6e19db547ca6a79f75c839825e15943fde6288

* Allow remaking an existing link. (#146)

* Allow remaking an existing link.

* Update CHANGELOG.md

Co-authored-by: Paul Demeulenaere <pauld@unity3d.com>

* ShaderGraph loosing reference while updating (sync with 7.x.x) (#185)

* Use explicit GetOrRefreshShaderGraphObject & always lazy init the shadeGraph access.

# Conflicts:
#	com.unity.render-pipelines.high-definition/Editor/VFXGraph/Outputs/VFXAbstractParticleHDRPLitOutput.cs
#	com.unity.visualeffectgraph/Editor/Models/Contexts/Implementations/VFXMeshOutput.cs
#	com.unity.visualeffectgraph/Editor/Models/VFXGraph.cs
#	com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphParticleOutput.cs
#	com.unity.visualeffectgraph/Editor/ShaderGraph/VFXShaderGraphPostProcessor.cs

* Fix shaderGraph not listed in VFXModel

This is actually an issue in VFXModel.GetSettings, we don't have any cases like this where the parent value is private.

* Update changelog.md

Same entry than https://github.com/Unity-Technologies/Graphics/pull/2873/

* Removing changelog entry

The actual fix was already there, this code is only a synchronisation with 7.x.x & prior version.

* *Minimal test to check actual content of modified property after an override (#171)

* Add test to cover behavior from https://fogbugz.unity3d.com/f/cases/1122404/ (#196)

* *Updating reference image for D3D12

Related to this PR : https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/182

* Force re-apply formatting

* Fix ordering for "+" button in blackboard (#197)

* Add test to cover behavior of https://fogbugz.unity3d.com/f/cases/1300115/ (#192)

* Fix changelog.md (new entries should be in 12.0.)

* *Update changelog.md (unexpected diff in 11.x.x)

* [Fix Case 1221557] Checkbox Age Particles consistency (#202)

* Provides consistent behavior with Add Age and Set Age

* Update Changelog

* update changelog

* Add _CameraViewMatrix shader variable (#208)

Add _CameraViewMatrix shader variable in HDRP, instead of using legacy unity_CameraToWorld.
Remove functions using unity_CameraToWorld from VFXCommonOutput.hlsl and move to SRP specific VFXCommon.hlsl files

* Fix compute culling compilation in URP (case 1309174) (#210)

* Add GeometricTools.hlsl include

Missing include containing DistanceFromPlane function used by IsSphereOutsideFrustum

* Update changelog

* [pCache] Fix minor UX issues (#207)

* Disable mesh statistic field

* Fix cancel while save texture

* Fix create pCache from unreadable texture

* *Update changelog.md

* Fix missing disable for Texture Statistics

* Disable motion vector per vertex optimization (#214)

Temporarily disable motion vector per vertex optimization.
Small refactor for vertex count calculation

* Fallback for camera buffers from Main camera (#200)

* Add setting for main camera buffer fallback

* Move enum to C++

* Update changelog

* Rename setting to Main Camera fallback and the option "None" to "No fallback"

* Added an entry for Main Camera feedback in the preferences doc.

* Updated tooltip

* Reworded tooltip and doc entry

* Added doc entry for User Systems.

Co-authored-by: Lewis Jordan <lewis.jordan@hotmail.co.uk>

* [VCS] Handle correctly locked asset (#193)

* Prelimary refactor : gather IsAssetEditable in common test to ease testing

* Move always m_LockedElement in front

* Fix inspector of slot container when asset is locked

* Fix inspector for VFXManager when asset is locked

* *Update changelog.md

* Fix incorrect cast in VFXSlotContainerEditor

* Use m_LockedElement in blackboard & redirect it when needed

Simplify integration from m_ComponentBoard

* Fix case 1243947 : Debug View artefact

Correctly clear the VFXDebugView while reassigning

* *Update changelog.md

* Let selection passing through locked label : it allows inspection

* Fix locked label in blackboard when empty

* Fix "Shader Value is not saved when switching between VFX Manager and Version Control"

* Prevent Drag&Drop when asset is locked

* Prevent tricky way to instantiate BuildContextualMenu

There was an issue while clicking on left & right at the same time

* Fix two issue with target

- Attach a stopped visualEffect component
- Stop & Reset behavior

* Fix UpdateDebugMode which could be called too soon

In the case of an not yet loaded VisualEffect component (because the VFXGraph has been just recompiled)

* Fix ordering

We want the "asset locked" just after contentViewContainer and not just before m_ComponentBoard

* Update maxAlive state checking the actual IsAssetEditable during update

* Fix locked issue with the VFXParameterEditor

Should disable everything if IsAssetEditable returns false

* Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graphics/pull/193#discussion_r109552

blackboard => componentBoard

* Mesh Index & Skinned (#30)

* Squashed commit of the following:

commit f51b7d616b77487339b2ec3db1e2e8bee35b3ae1
Merge: 2589034c08 229945b992
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Apr 6 17:32:10 2020 +0200

    Merge branch 'vfx/feature/mesh-sampling-support-texcoord-dimension' into vfx/feature/mesh-sampling-index-buffer

commit 229945b99247402006916c9c73a640d2b5662486
Merge: d26b342644 4cd4cb244d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Apr 6 17:31:23 2020 +0200

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 4cd4cb244d720c87580c3386a75209532f2b8629
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:13:24 2020 +0200

    Minor change to ease graphViz output view

commit a6f9f78ecff57045899508f8a7bb03c9cc731c29
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 18:11:09 2020 +0200

    Fix VFXObjectValue initial flag (cc @tristan) : Store ContentType & return it in VFXObjectValue directly (VFXObjectValue become an extension of VFXValue)

    Fix regression introduced by my change at 7abaf9bbf27c587033ad621301778b15748793e4 (due to missing in PropagateParentsFlags)
    Add OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant & OuputExpression_From_Slot_Mesh_Should_Be_Invalid_Constant_Propagation to ease the check of expected behavior

commit 7c11de30553cbc378926e3a1d6775f361921ad7a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Apr 2 14:54:57 2020 +0200

    *Update 007 SampleMesh to cover more cases

commit 2589034c088795ba63bf61f22e8ba84a7ffe7607
Merge: 47e04162e6 a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:24:43 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling-index-buffer

commit 47e04162e60683e331c930a02e77f6d5eeae568e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:18:43 2020 +0200

    Minor : add a TODO

commit a7bd11748549e25789e7515c50b1c3d96499301b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:17:32 2020 +0200

    Actually, keep minimal scope for VFX_GENERIC_BUFFER, it's useful for platform testing purpose.

commit 0baa1401f6fad276323d6369eb4330ef717c978f
Merge: 40749ce2ba a9338688a6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 18:04:49 2020 +0200

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 0f9fc14afb9e6e8666b39860bd84922eba4a64e5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 16:49:52 2020 +0200

    Remove temporary code

commit bc8121349789de632d1115a7804a17b882559e1b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 31 16:02:23 2020 +0200

    Choose StructuredBuffer<float> over ByteAddressBuffer

commit 21b9d002b29b9887da8661f32505973e75d0420f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 30 17:16:37 2020 +0200

    Change Buffer<uint> to Buffer<float> to avoid dx warning issue.

commit be691cd625a18194c5662de17c952613b4f591e3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sun Mar 29 19:06:25 2020 +0200

    Fix alignement for ByteAddressBuffer

commit 3ec05dfadefc483507d3de12caf4a2e216af6e66
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sun Mar 29 17:58:05 2020 +0200

    WIP : Trying to move to ByteAddressBuffer

commit 2cf1db8679851ff55afcd5f17afa8a52b4d9e179
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 18:06:49 2020 +0100

    add note for later

commit e6fd7c1931919c657b7c65f8197be03e387e56dc
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 17:44:24 2020 +0100

    *Draft test data (will be removed)

commit c84f0e927ebe00f655d3fb92bbe98d6c03fdcf34
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 17:16:12 2020 +0100

    Fix expressionMesh format

commit 6f48ffbdb55f38da5750f63fc1a38d79a5d19800
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 15:01:01 2020 +0100

    Update draft test

commit edec8e1e997188e0dbc82ad9bb38e0ac178476d2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Sat Mar 28 15:00:41 2020 +0100

    Sample Index *WIP*

commit 2853d8b25eabd0dcf3f5af4718d71f17685d5a7b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 15:54:29 2020 +0100

    *Remove End expression for mesh evaluation (invalid because we can't guess context for this case)

commit d4f09e0cc4c058d07a2c40366e4e0bd45476d7fb
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 12:00:30 2020 +0100

    Add minimal integration for newly added VFXExpressionVertexBufferFromMesh

commit baf39dcdf6fc340269fb5442c763e4932ead57f2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 11:59:25 2020 +0100

    Add test data (to revert)

commit 7a2fd0337ecc965dcea105dfd34973499f736bb8
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 11:58:53 2020 +0100

    Revert "Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh"

    This reverts commit 6d507a684f14dc09641877d6d691fd96adb63be4.

commit 6d507a684f14dc09641877d6d691fd96adb63be4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 11:56:51 2020 +0100

    Add test file & minimal integration testing newly added VFXExpressionVertexBufferFromMesh

commit d26b342644bc08c2ab4118a71899bb78a2c303a7
Merge: b1512335cb 40749ce2ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 27 09:27:26 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 40749ce2ba015f004c6e161d75c4063edefd0f3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:50:40 2020 +0100

    *Reupdate Image (HDRP, there was an issue with shaderGraph)

commit fa7ecbf9656db5316a60aadd450414b4d790e9ff
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 21:46:02 2020 +0100

    *Update reference Image & .vfx (always in HDRP project)

commit b1512335cb09b7b3e1ee783f991347704c4952be
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 18:24:05 2020 +0100

    Fix after merge

commit 43e25995ca9a15aa0ee5c88297616ccbd3fc5c2d
Merge: e357f4871b 7abaf9bbf2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 17:47:34 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Expressions/VFXExpressionMesh.cs

commit 7abaf9bbf27c587033ad621301778b15748793e4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 15:13:20 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714 : set InvalidConstant directly on VFXValueType of Mesh

commit c5a7a3ed477af8732da0095091c080692c9c64b2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 14:52:07 2020 +0100

    Add graphic test to cover constant folding (TODO : Update all images)

commit 27e3c7464d60659905f13f172c79a79a94b7ac56
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Mar 26 13:37:38 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r44714

commit e357f4871b8c39257c62daf1fe63f85241325712
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Mar 25 08:56:53 2020 +0100

    Fix build in 2020.1 to resolve comment https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/258#pullrequestreview-52608

commit bfc0d9f7aeaa8b34407bfa8279d30bf59cf55099
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 18:44:28 2020 +0100

    *Fix compilation

commit 6cfd2d90292796c5b21e63d01c4b4bf8563c0184
Merge: 41a1a8e212 128101bc63
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 14:56:22 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 128101bc638d98d9628dc90be078450e1f706534
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 12:39:39 2020 +0100

    Minor : forgot a punctation

commit 8c395cd600dfd8301cf6c83d1354ba457e49e889
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 24 11:01:30 2020 +0100

    *Update documentation from @lewis feedback https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-18488

commit 41a1a8e212c82b48832ab88f68348c145c0960c6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 15:19:24 2020 +0100

    *Update expression name

commit 27794064fd01207a35e7d967ff322e9d552a2054
Merge: ad597a0388 28f0ca20a0
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 10:21:38 2020 +0100

    Merge branch 'vfx/feature/mesh-sampling' into vfx/feature/mesh-sampling-support-texcoord-dimension

commit 28f0ca20a0c422c5a5f1e64e1401271f63762ade
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:33:39 2020 +0100

    Fix documentation image link (bis)

commit 1b102c1c1ef3d3da69c9aa4332737e3f935959fa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:24:13 2020 +0100

    *Fix path in documentation

commit 662d086481c228491536d1463dfe61198048a263
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 09:06:12 2020 +0100

    Fix issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43790

commit 241ca5edf7451345ecce30da9310b19e24ee37d5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 23 08:21:56 2020 +0100

    *Update documentation

commit d89f307aca40f88bdda2dc0e9a0324556e296400
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 17:50:44 2020 +0100

    *Update documentation

commit 9f79d5a48e22881011ccf978217b21ce44ed9a37
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 15:59:56 2020 +0100

    first draft of documentation

commit f84300e560bfd3698e27da58a4e93236209ac513
Merge: 9c5bd4e887 c04b64c1b3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Fri Mar 20 13:22:28 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit ad597a03881e11743e68555f985c304ee2d7557d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 11:18:40 2020 +0100

    Support float or uint read in sample mesh color

commit 8ca98dd9a375431ddc04c7a0cb625c35a2c99f57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 17 10:05:40 2020 +0100

    Add compatibility code & use new available expression from https://ono.unity3d.com/unity/unity/changeset/6afd1f99b768984023366f3aba746390c763432f

commit 9c5bd4e88764d91371d0551fdf3fe64654c2e63f
Merge: f8284406c8 ec959d5de3
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:13:09 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit f8284406c8a99ceb442c13e20049ca14efd3cd7d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Mar 16 10:12:08 2020 +0100

    Fix issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43071 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43068 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r43067 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#pullrequestreview-50944

    Split Texture & Buffer

commit 39328fb09e1d470727becea05842cd48ceb7c5e2
Author: Tristan Genevet <tristan@unity3d.com>
Date:   Wed Mar 11 11:42:23 2020 +0100

    Fix delegate set that must not be postponed

commit 9ddac63551eea34f630ddea0380035728b97bf3a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 17:48:44 2020 +0100

    Add sample test for case 1226578 (TODO : fix HDRP 007_SimpleMaterial)

commit e04224320d5404e44c969e49470eec827622916f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:30:46 2020 +0100

    Fix after merge

commit fb7dbd291fc063640295b35a24caf87ddccef1f9
Merge: 302ae40d59 5bdcd30bd9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Mar 10 15:15:42 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 302ae40d59ec0c3dd214405392853de8097373ca
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:48:54 2020 +0100

    Fix build & behavior

commit 61ce50e6dd9e08987bb7273f678e064edc01d110
Merge: 70c93148d4 5d2dfe278f
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 25 10:18:17 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/Editor/Compiler/VFXShaderWriter.cs

commit 70c93148d49f776dc68a47c28053258f8a713f54
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Wed Feb 12 09:04:23 2020 +0100

    Relate to issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressing mode in Position (Mesh) too & Update Tooltips

commit e5d35ed0d6b6398c7d25d02166a32ca7d2afec65
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 17:18:28 2020 +0100

    *Update reference image for HDRP (clear color isn't exactly the same)

commit 65883b0f521cd1e1438890084593081400d594a2
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 16:09:18 2020 +0100

    Fix Color Sampling test

commit 3e7ab2cddca5556855280709d18395df1229be57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:54:25 2020 +0100

    *Update Mesh Sampling vfx

commit b46ffc745a55347e4d310e617afd1a40f2c2a804
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:47:06 2020 +0100

    Resolve issue https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15567

commit 03dff8383f4cc7acb383a630f0745871db2b7303
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:31:48 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#issuecomment-15555

    Remove output count from the SampleMesh for consistency

commit 0d6620339efc53b56906226e78b005ab06a0ab53
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:26:24 2020 +0100

    *Update test using vertex mesh sampling

commit 33433a4ccacc91c5861957b4f1d414d91eb1abb5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 15:17:00 2020 +0100

    *Use flag in inspector as @julienf suggested

commit f6d9f3ab494b50dcd15ad7104ff0ea40f398cee9
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 11:22:36 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36772

    Add adressingMode in Custom Sampling

commit 00444271a0c3c1efda6373f16432cad3659d8238
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 10:29:07 2020 +0100

    Resolve issue : https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36771 & https://github.cds.internal.unity3d.com/unity/vfx-graph/pull/197#discussion_r36770

commit d4422c88b66f0cf67c561086798b176db69b3d1a
Merge: a7052746e1 0e325d7de5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:05:59 2020 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	com.unity.visualeffectgraph/CHANGELOG.md

commit a7052746e10326979c3e4c4d69ddc4004bcad83b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Feb 11 09:04:44 2020 +0100

    Unexpected change in upm-ci-vfxmain.yml

commit 3fa67e367aeda4f85025886d53729111a0d841e6
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:57 2019 +0100

    Update upm-ci-vfxmain.yml

commit 8abf8e07dbe96fb4f02ab0733e3f22fa30622a7d
Merge: 442c3cd4e0 1758e4de4b
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 23 10:34:28 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 442c3cd4e0264a0ef2942ebbe4c1476da370d848
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Dec 9 08:59:41 2019 +0100

    Fix experimental & add mesh vertex count output as suggested by @vlad

commit 7e306fe26a8839a9d72f4625a61e91814b4105ce
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:13:04 2019 +0100

    Update upm-ci-vfxmain.yml

commit 31604a66ff6f0b2031681bf26ac7f59d047d493d
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:12:46 2019 +0100

    Revert upm-ci-vfxmain.yml

commit 9f8cdafdbc98f084453894897b54858a67e75483
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Thu Nov 28 13:11:49 2019 +0100

    Revert upm-ci-vfx_lwrp.yml

commit e95e7659b7f0a5a6cf1fc15ee8aef9a207038573
Merge: 858f1a94ed 5b678082c5
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:55:52 2019 +0100

    Merge branch 'vfx/staging' into vfx/feature/mesh-sampling

commit 858f1a94edfc88756a43b41d4652624939a6ab57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:49:20 2019 +0100

    Restrict constant folding on mesh operation

commit 1b5216571e1a8b6d21787f10f33c4a819729c0ba
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 16:04:40 2019 +0100

    *Update ChangeLog.md

commit 651ce34b5baa57c43b2aff6b10f602f4643ec13a
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 14:21:01 2019 +0100

    Clean useless code

commit 8e2e438886de3db5b8ba6c2613102a38947461aa
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 13:45:51 2019 +0100

    Use name expression to compute vertex index

commit 8349f56e96668f3656113850048e427859602583
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 09:03:17 2019 +0100

    Rename "texture_" to "mesh_" when expression is actually a mesh

    Remove useless sampler for mesh

commit 51f1e01943e4d221a7323363c39656b861a94fe7
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 08:39:31 2019 +0100

    Update Canvas to include test in graphicTest

commit fff4b79856a215bc1d13cb08752f88e40549ddbb
Merge: ca39c0d6ec efba8dad57
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 26 07:49:14 2019 +0100

    Merge branch 'refs/heads/vfx/staging' into vfx/feature/mesh-sampling

    # Conflicts:
    #	TestProjects/VisualEffectGraph/ProjectSettings/EditorBuildSettings.asset
    #	TestProjects/VisualEffectGraph_LWRP/ProjectSettings/EditorBuildSettings.asset

commit ca39c0d6ece391081f786e10e96aa6007af6b18e
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Tue Nov 19 11:22:36 2019 +0100

    Remove shape test

commit 2aedcdd8bcee3342fc2a43be759f7c31d77628d4
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 15:02:58 2019 +0100

    Temporary : change yamato target to graphics/vfx/fix/mesh-sampling

commit aea552d59b018fbf7c217b37d8846e02bfefb349
Author: Paul Demeulenaere <pauld@unity3d.com>
Date:   Mon Nov 18 14:59:04 2019 +0100

    *Update player reference images

com…
@sebastienlagarde sebastienlagarde deleted the HDRP/integrate_hdri branch September 1, 2021 10:23
mohammad22 pushed a commit that referenced this pull request May 24, 2022
* Bursted shadow requests

* Removed project-specific differences

Co-authored-by: Adam Strick <adam.strick@unity3d.com>
mohammad22 pushed a commit that referenced this pull request May 24, 2022
* Bursted shadow requests

* Removed project-specific differences

Co-authored-by: Adam Strick <adam.strick@unity3d.com>
mohammad22 pushed a commit that referenced this pull request May 24, 2022
…)"

This reverts commit 76c589f.

Encountered some editor-only native collection lifetime management issues in HDLightRenderDatabase
mohammad22 pushed a commit that referenced this pull request May 27, 2022
* Bursted shadow requests

* Removed project-specific differences

Co-authored-by: Adam Strick <adam.strick@unity3d.com>
mohammad22 pushed a commit that referenced this pull request May 27, 2022
…)"

This reverts commit 76c589f.

Encountered some editor-only native collection lifetime management issues in HDLightRenderDatabase
mohammad22 pushed a commit that referenced this pull request May 31, 2022
* Bursted shadow requests

* Removed project-specific differences

Co-authored-by: Adam Strick <adam.strick@unity3d.com>
mohammad22 pushed a commit that referenced this pull request May 31, 2022
…)"

This reverts commit 76c589f.

Encountered some editor-only native collection lifetime management issues in HDLightRenderDatabase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants