FIX: Drag-reordering actions changing IDs (case 1231233). #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 1231233 (Issue Tracker).
My initial fix was to explicitly clear out cached GUIDs in
InputActionMap.OnAfterDeserialize. However, I decided that a better course of action is probably to do away with the cached GUIDs altogether so I removed them fromInputActionMap,InputAction, andInputBinding.This means that every
idgetter of these will now parse GUIDs on the fly (which, if everything goes well, will not allocate). However, non-string GUIDs are rarely used and for the most part, not used at all internally within the system. So, think this is the better setup. Also saves 16 bytes on an already massive InputBinding struct...//NOTE: The fact we even have the problem is because we can't serialize Guids with Unity and because our own GUID struct (which is in fact serializable) is editor-only.