FIX: A number of problems with HID joysticks. #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 26, 2019 20:37
Rene-Damm
requested review from
jechter and
douglas-piconi
and removed request for
jechter and
douglas-piconi
|
can't approve just yet, lot of red on these tests. Other than that code looks fine |
Yeah, hit "add reviewers" a tad bit too early :) I'll go green it first. |
douglas-piconi
approved these changes
Aug 27, 2019
jechter
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into problems with the G25 Racing Wheel, I found quite a number of issues around joysticks so unfortunately, this branch ended up accumulating quite a few changes.
Most important changes:
HIDcan now deal with sticks that have their X and Y control sitting in unrelated places in the HID input report and being of different geometry. On the G25 Racing Wheel in particular, we have a 14bit X axis with a 2-bit offset (!) and several controls later an 8-bit Y axis.InputDeviceBuilderwith settings on controls like up/down/left/right not coming through because of an unfinished refactor of mine. Turned out to be very simple to solve and removed a bunch of code.featureSizewas calledsizein C# and thus always 0.