Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Universal Outline Post and 3D character menus examples #35

Merged
merged 8 commits into from
Oct 2, 2020

Conversation

phi-lira
Copy link
Contributor

@phi-lira phi-lira commented Sep 14, 2020

Purpose of this PR

  • Fixed OutlinePostProcessPass and 3D Character Menu.
  • Converted Blit Feature to a more general DrawFullscreenFeature and made a few improvements:
    -- Now you can select source texture to be either Camera or Custom, in which you can bind a custom property Id. In case of custom texture, the pipeline will create the texture if not available.
    -- Now you can select destination texture to be either Camera or Custom. Likewise source.
    -- We now fetch the pass list from the material and show pass names availables instead of expecting a user to input an index that might be invalid.

Still there are some known issues with this feature we need to fix but I'll address those in a follow up PR:

  • If blitting / drawing after post-processing the pass will not work when having Camera as either source of destination, as at this point in the pipeline the camera texture is not _CameraColorTexture anymore, it's AfterPostProcess texture.
  • We don't execute the pass if the material is null, we could improve it by executing the blit with a built-in blit shader.
    DrawFullscreenFeature

Comment to Reviewers

This PR depends on Unity-Technologies/Graphics#1861

@phi-lira phi-lira changed the title Update blit feature Fix Universal Outline Post and 3D character menus examples Sep 14, 2020
Copy link

@erikabar erikabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Graphics PR: Unity-Technologies/Graphics#186
Tested on Windows, OSX, Android and iOS, no issues found

Copy link
Contributor

@Verasl Verasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phi-lira phi-lira merged commit cc4f75e into master Oct 2, 2020
@phi-lira phi-lira deleted the UpdateBlitFeature branch October 2, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants