New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMCL-0000: add isDelayed to some fields #939
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
==========================================
- Coverage 26.67% 26.65% -0.03%
==========================================
Files 246 247 +1
Lines 27573 27598 +25
==========================================
Hits 7356 7356
- Misses 20217 20242 +25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's such a great idea!!!
* Add missing length check to 3rdPersonFollow * CMCL-1551: add missing empty check when overriding a blend stack (#930) * add missing empty check * Update CHANGELOG.md * Better filtering for vcam Navel Gazing warning (#927) * Revert "Update CinemachineThirdPersonFollow.cs" This reverts commit c15efbe. * Update CMWaveform.compute * Update CMWaveform.compute * Update README.md * another tweak - binding modes this time * Revert "another tweak - binding modes this time" This reverts commit 91a0b6c. * Fix typo in Editor min req version (#936) * CMCL-0000: FreeLookOnSphericalSurface sample is improved (#935) * FreeLookOnSphericalSurface sample is improved, adding a moving surface and second camera. * forgot to commit * tewaking blend hints * binding mode tweaks * Cleanup, tweaking * cosmetic * bugfix in AddCustomBlendable * deprecate RangeSliderAttribute (#944) * Add some missing null checks in shot editor to handle missing scripts * CMCL-0000: add isDelayed to some fields (#939) * add isDelayed to some fields * Fix outdated tooltip, add "Custom" label to SensorSize presets dropdown * Update LensSettings.cs * statedrivencamera bugfix for minactivationtime, add CancelWait (#938) * CMCL-1565: Deoccluder improvements, and add CinemachineShotQualityEvaluator (#899) * Add CinemachineDecollider * Added Cinemachine Terran Decollider * Update RuntimeUtility.cs * Fix OrbitalFollow inappropriate vertical damping * Update CinemachineDecollider.cs * small fixes * Add CinemachineShotQualityEvaluator * Add deoccluder Resolve towards follow target option * Terrain Decollider improvements * Deoccluder evaluates shot quality only when evaluation is enabled * Add doc and editor for shot quality evaluator * Remove TerrainDecollider * Add terrain functionality to Decollider * Remove decollider (to another PR) * Update CinemachineShotQualityEvaluator.md * Update TableOfContents.md * Update CHANGELOG.md * Update CHANGELOG.md * Remove ResolveTowardsFollowTarget * Update CHANGELOG.md * Update CinemachineOrbitalFollow.cs * Update CinemachineOrbitalFollow.cs * Update CinemachineDeoccluder.cs * Add a comment * CMCL-0000: Fix OrbitalFollow inappropriate vertical damping (#942) * Fix OrbitalFollow inappropriate vertical damping * small fixes * Revert "small fixes" This reverts commit 7d32f6a. * new strategy * Setting isDelayed was causing some exceptions on domain reload * Add another missing isDelayed * Axis recentering happens independently on axes (#937) --------- Co-authored-by: Gregory Labute <gregoryl@unity3d.com> Co-authored-by: Sébastien Duverne <55094336+sebastienduverne@users.noreply.github.com>
Purpose of this PR
Typing values in certain text fields can be confusing because validation kicks in as you're typing and changes the value unintuitively. Solution is to wait for Enter or focus loss before validating.
Added this property to the UX of some fields:
If later we find more fields that need this, we can fix in a similar manner.
Testing status