CMCL-0000: Fix OrbitalFollow inappropriate vertical damping #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
=======================================
Coverage 26.67% 26.68%
=======================================
Files 246 246
Lines 27572 27573 +1
=======================================
+ Hits 7356 7358 +2
+ Misses 20216 20215 -1 ☔ View full report in Codecov by Sentry. |
This reverts commit 7d32f6a.
|
|
|
hmmmm nice catch! |
AntoineCharton
approved these changes
Mar 8, 2024
glabute
added a commit
that referenced
this pull request
Mar 11, 2024
* Add missing length check to 3rdPersonFollow * CMCL-1551: add missing empty check when overriding a blend stack (#930) * add missing empty check * Update CHANGELOG.md * Better filtering for vcam Navel Gazing warning (#927) * Revert "Update CinemachineThirdPersonFollow.cs" This reverts commit c15efbe. * Update CMWaveform.compute * Update CMWaveform.compute * Update README.md * another tweak - binding modes this time * Revert "another tweak - binding modes this time" This reverts commit 91a0b6c. * Fix typo in Editor min req version (#936) * CMCL-0000: FreeLookOnSphericalSurface sample is improved (#935) * FreeLookOnSphericalSurface sample is improved, adding a moving surface and second camera. * forgot to commit * tewaking blend hints * binding mode tweaks * Cleanup, tweaking * cosmetic * bugfix in AddCustomBlendable * deprecate RangeSliderAttribute (#944) * Add some missing null checks in shot editor to handle missing scripts * CMCL-0000: add isDelayed to some fields (#939) * add isDelayed to some fields * Fix outdated tooltip, add "Custom" label to SensorSize presets dropdown * Update LensSettings.cs * statedrivencamera bugfix for minactivationtime, add CancelWait (#938) * CMCL-1565: Deoccluder improvements, and add CinemachineShotQualityEvaluator (#899) * Add CinemachineDecollider * Added Cinemachine Terran Decollider * Update RuntimeUtility.cs * Fix OrbitalFollow inappropriate vertical damping * Update CinemachineDecollider.cs * small fixes * Add CinemachineShotQualityEvaluator * Add deoccluder Resolve towards follow target option * Terrain Decollider improvements * Deoccluder evaluates shot quality only when evaluation is enabled * Add doc and editor for shot quality evaluator * Remove TerrainDecollider * Add terrain functionality to Decollider * Remove decollider (to another PR) * Update CinemachineShotQualityEvaluator.md * Update TableOfContents.md * Update CHANGELOG.md * Update CHANGELOG.md * Remove ResolveTowardsFollowTarget * Update CHANGELOG.md * Update CinemachineOrbitalFollow.cs * Update CinemachineOrbitalFollow.cs * Update CinemachineDeoccluder.cs * Add a comment * CMCL-0000: Fix OrbitalFollow inappropriate vertical damping (#942) * Fix OrbitalFollow inappropriate vertical damping * small fixes * Revert "small fixes" This reverts commit 7d32f6a. * new strategy * Setting isDelayed was causing some exceptions on domain reload * Add another missing isDelayed * Axis recentering happens independently on axes (#937) --------- Co-authored-by: Gregory Labute <gregoryl@unity3d.com> Co-authored-by: Sébastien Duverne <55094336+sebastienduverne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Bug:
Create the following:
No damping should happen in response to mouse movement (only player movement).
This PR fixes that. OrbitalFollow was calculating the damping bypass for the follow target when it should be for the lookat target.
Testing status
Documentation status
Technical risk
low