Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic prefabs loaded status correctly shown on host #111

Merged
merged 2 commits into from Mar 6, 2023

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Mar 2, 2023

Proposed change(s)

Quick PR to fix Loaded status name not displaying on loaded prefabs on the host. This is just a visuals bug-fix. Implementation remains the same.

Platform and Editor version used to develop and test this PR

  • Windows, 2021.3.18f1

Related links

N/A

Affected sample(s)

  • 2DSpaceShooter
  • Invaders
  • Client Driven
  • API Diorama
  • DynamicAddressablesNetworkPrefabs
  • N/A (please describe)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • UI/UX (see style guide)
  • Breaking change
  • Documentation update (see style guide)
  • Other (please describe)

Checklist

  • Unit tests pass locally --> n/a right now
  • Added tests, if feasible, that prove my fix is effective or that my feature works
  • No warnings in the Console
  • Documented (///) public APIs (public/protected functionality of public/protected classes), if applicable
  • Updated the sample documentation, if applicable (see style guide)
  • UI & Style sheet changes: both Dark and Light styles/themes updated/tested --> n/a right now
  • Remember to familiarize yourself with the coding conventions

How to test/validate

  1. Clone this branch.
  2. Open it with the aforementioned Unity version.
  3. Open Scene 02_Server Authoritative Preload All Prefabs Asynchronously.
  4. Create a ParrelSync clone. Start a host and a client.
  5. Have a client join the host.
  6. Press the shown API Calls button for the use-case on the host.
  7. Inspect the load status be displayed correctly on the host after loading as "Loaded".
  8. Repeat steps 3-7 with scenes: 03_Server Authoritative Try Spawn Synchronously & 05_API Playground Showcasing All Post-Connection Use-Cases.

Other comments

N/A

@fernando-cortez fernando-cortez added the bug Something isn't working label Mar 2, 2023
@fernando-cortez fernando-cortez merged commit 0d86862 into develop Mar 6, 2023
@fernando-cortez fernando-cortez deleted the fix/dynamic-prefabs-loaded-status-on-host branch March 6, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants