Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: applying address inside TMP field to UTP connection data as host #112

Merged
merged 5 commits into from Mar 6, 2023

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Mar 3, 2023

Proposed change(s)

Invaders didn't previously allow for passing in the IP address' input field text value into UTP's connection data and only allowed local hosting (127.0.0.1). This PR adds that functionality to the Invaders sample, allowing the ability to connect to a remote IP address.

Platform and Editor version used to develop and test this PR

  • Windows, 2021.3.18f1

Related links

  • N/A

Affected sample(s)

  • 2DSpaceShooter
  • Invaders
  • Client Driven
  • Dynamic Addressables Network Prefabs
  • N/A (please describe)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • UI/UX (see style guide)
  • Breaking change
  • Documentation update (see style guide)

Checklist

  • Unit tests pass locally --> n/a right now
  • Added tests, if feasible, that prove my fix is effective or that my feature works
  • No warnings in the Console
  • Documented (///) public APIs (public/protected functionality of public/protected classes), if applicable
  • Updated the sample documentation, if applicable (see style guide)
  • UI & Style sheet changes: both Dark and Light styles/themes updated/tested --> n/a right now
  • Remember to familiarize yourself with the coding conventions

How to test/validate

  1. Clone this branch
  2. Open it with the aforementioned Unity version
  3. Create a build.
  4. Host and set public IP for the connect address.
  5. Have a client join the host.
  6. Both clients should be sent to the pre-game lobby.

Other comments

N/A

@fernando-cortez fernando-cortez added the bug Something isn't working label Mar 3, 2023
@fernando-cortez fernando-cortez merged commit 96465ee into develop Mar 6, 2023
@fernando-cortez fernando-cortez deleted the fix/invaders-not-using-address-field-fix branch March 6, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants