Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DynamicAddressablesNetworkPrefabs showing loading status on already spawned prefabs [MTT-6688] #132

Merged
merged 2 commits into from Aug 11, 2023

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Aug 10, 2023

Description

This PR fixes the "Loading" state being displayed inside the API Playground scene when the host hits the Spawn

Issue Number(s)

MTT-6688

Repro steps:

  • Open scene 05_API Playground Showcasing All Post-Connection Use-Cases
  • Hit play
  • Host
  • Hit Try Spawn Synchronously button
  • Observe that the loading state of the loading prefab transitions from Loading to Loaded (this can happen quickly), but does not get stuck on Loading.

This was reproduceable on just the host, but testing the same steps with a ParrelSync client connected would be appreciated for sanity's sake.

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez added the bug Something isn't working label Aug 10, 2023
Copy link
Contributor

@jilfranco-unity jilfranco-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a host and a client and it looks good to me!

@fernando-cortez fernando-cortez merged commit 50cd4fb into develop Aug 11, 2023
10 checks passed
@fernando-cortez fernando-cortez deleted the fix/wrong-status-on-sync-spawns branch August 11, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants