Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bitesize samples 2022.3.9 LTS & NGO v1.6.0 upgrade [MTT-7247] #134

Merged
merged 5 commits into from Sep 20, 2023
Merged

feat: Bitesize samples 2022.3.9 LTS & NGO v1.6.0 upgrade [MTT-7247] #134

merged 5 commits into from Sep 20, 2023

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Sep 19, 2023 •
edited

Description

PR to upgrade the bitesize samples projects to 2022.3.9f1 LTS & Netcode for GameObjects v1.6.0.

Additionally, some NetworkVariable warnings were removed inside 2DSpaceShooter, as a QoL fix.

Issue Number(s)

MTT-7247

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez added the enhancement New feature or request label Sep 19, 2023
@fernando-cortez fernando-cortez requested a review from a team September 19, 2023 18:39
LPLafontaineB
LPLafontaineB reviewed Sep 19, 2023
View reviewed changes
Basic/2DSpaceShooter/Assets/Scripts/Spawner.cs Outdated Show resolved Hide resolved
Basic/ClientDriven/Packages/manifest.json Outdated Show resolved Hide resolved
Basic/DynamicAddressablesNetworkPrefabs/Packages/manifest.json Outdated Show resolved Hide resolved
Basic/Invaders/Packages/manifest.json Outdated Show resolved Hide resolved
@fernando-cortez fernando-cortez merged commit 96bbf2d into develop Sep 20, 2023
10 checks passed
@fernando-cortez fernando-cortez deleted the feat/bitesize-samples-2022.3.9LTS-upgrade branch September 20, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fernando-cortez @LPLafontaineB