Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change urp grading mode to hdr #73

Merged
merged 5 commits into from Dec 7, 2022
Merged

Conversation

chrispope
Copy link
Collaborator

@chrispope chrispope commented Dec 3, 2022

Within the URP asset, the grading mode property within post-processing was set to a low dynamic range. I switched it to a high dynamic range to improve the precision and quality of the colour grading. Producing a nicer render.

Compare the output. HDR is a higher quality and precise colour grading.

LDR

HDR

Within the URP asset, the grading mode property within post-processing was set to a low dynamic range. I switched it to a high dynamic range to improve the precision and quality of the colour grading. Producing a nicer render.
@chrispope chrispope self-assigned this Dec 3, 2022
@chrispope chrispope changed the base branch from main to develop December 3, 2022 15:01
@jilfranco-unity
Copy link
Contributor

It's a good idea to switch the color grading mode to HDR to get a more accurate render, but I am missing the warmth from the LDR version since the HDR version looks more blue tinted overall. We should keep the switch to HDR, but I'd like adjust the post processing profile itself to bring some of the warmer tones back. What do you think @chrispope?

@chrispope
Copy link
Collaborator Author

It's a good idea to switch the color grading mode to HDR to get a more accurate render, but I am missing the warmth from the LDR version since the HDR version looks more blue tinted overall. We should keep the switch to HDR, but I'd like adjust the post processing profile itself to bring some of the warmer tones back. What do you think @chrispope?

Yeah, I realised the tint went colder and bluer, we should warm it back up if that is your preferred aesthetic.

@jilfranco-unity
Copy link
Contributor

Yeah, I realised the tint went colder and bluer, we should warm it back up if that is your preferred aesthetic.

It is--is it alright if I do those changes right on your branch for simplicity?

@chrispope
Copy link
Collaborator Author

LGTM

@chrispope chrispope merged commit ec1eddd into develop Dec 7, 2022
@chrispope chrispope deleted the Change-urp-grading-mode-to-HDR branch December 7, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants