Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Readme Updates [MTT-5460] #96

Merged
merged 14 commits into from Feb 16, 2023

Conversation

jilfranco-unity
Copy link
Contributor

@jilfranco-unity jilfranco-unity commented Feb 15, 2023

Description

A new folder for readme updates branched off of develop post dynamic prefabs project rename to avoid a messy merge (was originally based off of Phil's old branch)

Github readmes updated in this PR:

  • Global Bitesize
  • Dynamic Prefabs
  • Client Driven
  • 2D Spaceshooter
  • Invaders

The dynamic prefabs in editor readme will also be edited here

All comments from the old PR #93 will be addressed here

The bossroom readme has also been updated

Issue Number(s)

jira ticket MTT-5460 here

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@jilfranco-unity jilfranco-unity changed the base branch from main to develop February 15, 2023 03:22
@jilfranco-unity jilfranco-unity added the enhancement New feature or request label Feb 15, 2023
@jilfranco-unity jilfranco-unity changed the title Feat: Readme Updates (Post Project Rename) [MTT-5460] Feat: Readme Updates [MTT-5460] Feb 15, 2023
@jilfranco-unity jilfranco-unity marked this pull request as ready for review February 15, 2023 18:40
Copy link
Collaborator

@MorwennaG MorwennaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement already! I've popped some comments on here to discuss. Nothing major, just a few potential additions :)

jilfranco-unity and others added 2 commits February 16, 2023 16:11
Co-authored-by: Sam Bellomo <71790295+SamuelBellomo@users.noreply.github.com>
Co-authored-by: Sam Bellomo <71790295+SamuelBellomo@users.noreply.github.com>
@fernando-cortez fernando-cortez merged commit fe1ed71 into develop Feb 16, 2023
@fernando-cortez fernando-cortez deleted the feat/readme-updates-postrename branch February 16, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants