Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dynamic prefabs UI integration #98

Merged
merged 15 commits into from Feb 16, 2023
Merged

feat: dynamic prefabs UI integration #98

merged 15 commits into from Feb 16, 2023

Conversation

fernando-cortez
Copy link
Collaborator

Description

PR for integration of DynamicAddressableNetworkPrefabs with UI overhaul.

Issue Number(s)

N/A

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez added the enhancement New feature or request label Feb 16, 2023
LPLafontaineB
LPLafontaineB reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@LPLafontaineB LPLafontaineB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from nitpicks, lgtm

SamuelBellomo
SamuelBellomo approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@SamuelBellomo SamuelBellomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving while you're fixing the string in rpc comments. Feel free to merge once that fix is in

@fernando-cortez fernando-cortez merged commit 289635b into develop Feb 16, 2023
@fernando-cortez fernando-cortez deleted the feat/dynamic-prefabs-UI-integration branch February 16, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPLafontaineB LPLafontaineB LPLafontaineB left review comments

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@jilfranco-unity jilfranco-unity Awaiting requested review from jilfranco-unity

Assignees

@LPLafontaineB LPLafontaineB

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fernando-cortez @SamuelBellomo @LPLafontaineB @jilfranco-unity