feat: NetworkAnimator added to boss door & floor switch #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
added
2-Easy
| /// Client-side representation of a floor switch. | ||
| /// </summary> | ||
| [RequireComponent(typeof(NetworkFloorSwitchState))] | ||
| public class ClientFloorSwitchVisualization : NetworkBehaviour |
There was a problem hiding this comment.
oh nice, I like that red :)
SamuelBellomo
approved these changes
Sep 1, 2021
pdeschain
reviewed
Sep 1, 2021
| /// </summary> | ||
| public class NetworkDoorState : NetworkBehaviour | ||
| { | ||
| public NetworkVariableBool IsOpen { get; } = new NetworkVariableBool(); |
There was a problem hiding this comment.
Ah, sadly this definition of NetworkVariableBool is removed in further versions of the netcode. Not an issue at this point, just remarking on the fact that it will have to be repalced with NetworkVariable<bool> at a later point
There was a problem hiding this comment.
same goes for all other non-generic NetworkVariable invocations
pdeschain
approved these changes
Sep 1, 2021
pdeschain
added
3-Good to Merge
and removed
1-Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part of the work needed to finish MTT-993.
This adds
NetworkAnimatorfunctionality to only the doors and switches in the Boss Room scene.