Feature/network object pool #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ryan Thomas Warner seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
LukeStampfli
reviewed
Sep 1, 2021
LukeStampfli
reviewed
Sep 1, 2021
LukeStampfli
reviewed
Sep 1, 2021
…jectpool into the bossroom scene, adds cleanup to OnDestroy in networkobjectpool.cs. Clears up code style on awake method.
LukeStampfli
previously approved these changes
Sep 13, 2021
Assets/BossRoom/Scripts/Server/Game/Action/FXProjectileTargetedAction.cs
Outdated
Show resolved
Hide resolved
Assets/BossRoom/Scripts/Server/Game/Action/LaunchProjectileAction.cs
Outdated
Show resolved
Hide resolved
SamuelBellomo
previously approved these changes
Sep 13, 2021
SamuelBellomo
dismissed stale reviews from LukeStampfli and themself
via
bfce22b
…logies/com.unity.multiplayer.samples.coop into feature/network-object-pool * 'feature/network-object-pool' of github.com:Unity-Technologies/com.unity.multiplayer.samples.coop: adding comment to explain the magic
- Replaced the hardcoded offset when spawning a projectile with using its prefab's transform when pooling it. - Moved the resetting of properties to the OnNetworkSpawn method
Assets/BossRoom/Scripts/Server/Game/Action/LaunchProjectileAction.cs
Outdated
Show resolved
Hide resolved
Assets/BossRoom/Scripts/Server/Game/Action/LaunchProjectileAction.cs
Outdated
Show resolved
Hide resolved
Assets/BossRoom/Scripts/Server/Game/Action/LaunchProjectileAction.cs
Outdated
Show resolved
Hide resolved
Assets/BossRoom/Scripts/Server/Game/Entity/ServerProjectileLogic.cs
Outdated
Show resolved
Hide resolved
Cleaned up old comments Co-authored-by: Sam Bellomo <71790295+SamuelBellomo@users.noreply.github.com>
LukeStampfli
previously approved these changes
Oct 13, 2021
SamuelBellomo
previously approved these changes
Oct 14, 2021
|
|
LPLafontaineB
dismissed stale reviews from SamuelBellomo and LukeStampfli
via
e15ff97
SamuelBellomo
approved these changes
Oct 15, 2021
LukeStampfli
approved these changes
Oct 15, 2021
SamuelBellomo
added a commit
that referenced
this pull request
Oct 18, 2021
* develop: feat: server-authoritative character NetworkAnimator (#367) Feature/network object pool (#362) Update compatible Unity version in Readme (#376) # Conflicts: # Assets/BossRoom/Prefabs/Character/PlayerAvatar.prefab # Assets/BossRoom/Scenes/BossRoom.unity # Assets/BossRoom/Scripts/Client/Game/Action/DashAttackActionFX.cs # Assets/BossRoom/Scripts/Client/Game/Entity/ClientAvatarGuidHandler.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.