feat: server-authoritative character NetworkAnimator #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assets/BossRoom/Scripts/Client/Game/Action/AnimationOnlyActionFX.cs
Outdated
Show resolved
Hide resolved
Assets/BossRoom/Scripts/Client/Game/Character/ClientCharacterVisualization.cs
Outdated
Show resolved
Hide resolved
Assets/BossRoom/Scripts/Client/Game/Action/FXProjectileTargetedActionFX.cs
Outdated
Show resolved
Hide resolved
fernando-cortez
added
1-Needs Review
SamuelBellomo
approved these changes
Oct 15, 2021
LukeStampfli
approved these changes
Oct 15, 2021
SamuelBellomo
added a commit
that referenced
this pull request
Oct 18, 2021
* develop: feat: server-authoritative character NetworkAnimator (#367) Feature/network object pool (#362) Update compatible Unity version in Readme (#376) # Conflicts: # Assets/BossRoom/Prefabs/Character/PlayerAvatar.prefab # Assets/BossRoom/Scenes/BossRoom.unity # Assets/BossRoom/Scripts/Client/Game/Action/DashAttackActionFX.cs # Assets/BossRoom/Scripts/Client/Game/Entity/ClientAvatarGuidHandler.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira task here.
Here, server-authoritative
NetworkAnimatoris added to the Characters (players, imps, imp boss). With this change the player hierarchy looks like so:PlayerAvatar (
NetworkObject)NetworkTransform)Animator&NetworkAnimator)Animations are now triggered through server-side Action scripts. This change then gets replicated to other clients through
NetworkAnimator.