fix: while updating lobby, query count wasn't always back to 0 #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing issue where it's possible if there's an exception during updating lobby, query count never goes back to 0
SamuelBellomo
added
2-Easy
SamuelBellomo
requested review from
pdeschain,
fernando-cortez and
LPLafontaineB
SamuelBellomo
added
the
0-URGENT
LPLafontaineB
approved these changes
Mar 14, 2022
pdeschain
approved these changes
Mar 14, 2022
SamuelBellomo
added a commit
that referenced
this pull request
Mar 14, 2022
SamuelBellomo
added a commit
that referenced
this pull request
Mar 14, 2022
…-not-going-away * release/GDC2022: fix: leaving lobby when disconnecting (#515) better error messages and lobby fix (#550) feat: authentication failure message popups will tell the user to try direct ip connection option (#547) feat: replace guid with auth playerid for session management (#488) (#548) # Conflicts: # Assets/BossRoom/Scripts/Shared/Net/ConnectionManagement/ClientGameNetPortal.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
fixing issue where it's possible if there's an exception during updating lobby, query count never goes back to 0
adding some better error logging and popups.
Issue Number(s) (*)
Fixes issue(s): No issue, this was discovered quickly. If a new issue was created, it'd be closed anyway as soon as this is merged. No release notes needed for this PR, as this is related to lobby which is new anyway.