Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: empty lobby list text #567

Merged
merged 1 commit into from
Mar 17, 2022
Merged

feat: empty lobby list text #567

merged 1 commit into from
Mar 17, 2022

Conversation

pdeschain
Copy link
Contributor

Description (*)

A tiny feature - added a text label that states "NO LOBBIES" when there are no loaded lobbies. Enabled and disabled automatically.

Related Pull Requests

Issue Number(s) (*)

MTT-2658
Fixes issue(s):

Manual testing scenarios

  1. ...
  2. ...

Questions or comments

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@pdeschain pdeschain added 1-Needs Review PR needs attention from the assignee and reviewers GDC-cherrypick labels Mar 16, 2022
@pdeschain pdeschain added the 2-Easy This PR is trivial and can be reviewed quickly label Mar 16, 2022
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 17, 2022
@pdeschain pdeschain merged commit 9e2f3c2 into develop Mar 17, 2022
@pdeschain pdeschain deleted the pdeschain/empty-lobby-list-text branch March 17, 2022 17:50
pdeschain added a commit that referenced this pull request Mar 17, 2022
@pdeschain
Added empty lobby list text label and code to drive it's visibility (#…
8f1d4a5 
…567)
SamuelBellomo added a commit that referenced this pull request Mar 17, 2022
@SamuelBellomo
Merge branch 'release/GDC2022' into sam/fix/disconnect-issue-with-wif…
819e2a1 
…i-turned-off

* release/GDC2022:
  feat: better lobby exceptions handling (#568)
  fix: updaterunner item already added (#565)
  Added empty lobby list text label and code to drive it's visibility (#567)
  feat: display popup when failing to connect to full lobby (#525)
  Darker Eyebrows for Player Characters (#555) (#564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Assignees
No one assigned
Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge GDC-cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdeschain @SamuelBellomo @fernando-cortez @LPLafontaineB