MTT-3026 feat: Lobby and Authentication services to use async await #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing async wrapping needs, let's use async await properly # Conflicts: # Assets/BossRoom/Scripts/Client/UI/Lobby/LobbyUIMediator.cs # Assets/BossRoom/Scripts/Shared/Infrastructure/UpdateRunner.cs # Assets/BossRoom/Scripts/Shared/Net/UnityServices/Auth/AuthenticationServiceFacade.cs # Assets/BossRoom/Scripts/Shared/Net/UnityServices/Infrastructure/RateLimitCooldown.cs # Assets/BossRoom/Scripts/Shared/Net/UnityServices/Lobbies/LobbyServiceFacade.cs
All of the methods that are exposed are now async-await based and are wrapping native Tasks with basic error handling. # Conflicts: # Assets/BossRoom/Scripts/Shared/Net/UnityServices/Lobbies/LobbyAPIInterface.cs
# Conflicts: # Assets/BossRoom/Scripts/Client/Game/State/ClientMainMenuState.cs # Assets/BossRoom/Scripts/Shared/Net/UnityServices/Auth/AuthenticationServiceFacade.cs
Rate limiting code is now simplified and is not handling retires (should be handled by the sdk)
pdeschain
added
0-URGENT
# Conflicts: # Assets/BossRoom/Scripts/Client/Game/State/ClientMainMenuState.cs
…-async-await # Conflicts: # Assets/BossRoom/Scripts/Client/UI/Lobby/LobbyUIMediator.cs # Assets/BossRoom/Scripts/Shared/Net/UnityServices/Lobbies/LobbyServiceFacade.cs
Assets/BossRoom/Scripts/Shared/Net/UnityServices/Auth/AuthenticationServiceFacade.cs
Outdated
Show resolved
Hide resolved
SamuelBellomo
approved these changes
Apr 6, 2022
fernando-cortez
approved these changes
Apr 6, 2022
fernando-cortez
removed
the
1-Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The API for our lobby sdk wrapper has been converted to async await pattern, and all the call-sites were adapted accordingly.
Issue Number(s)
MTT-3026
Contribution checklist