fix: host not generating its own local client disconnect notification #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadauxCat
reviewed
Feb 5, 2024
| } | ||
| m_ServerNetworkManager.OnClientDisconnectCallback += firstCallback; | ||
| m_ClientsDisconnected.Clear(); | ||
| m_ServerNetworkManager.OnClientDisconnectCallback += OnClientDisconnected; |
There was a problem hiding this comment.
Can you also add a check for this behavior in OnConnectionEvent? InvokeOnClientDisconnectCallback should invoke both of them.
There was a problem hiding this comment.
Also discovered an issue with StopOneClient while adding the test... so it was a 2 4 1.
Validated the ConnectionEvent.ClientDisconnected triggers under both scenarios and fixed the integration test method.
👍
Adding check for ConnectionEvent.ClientDisconnected for both test types. Fixing issue with StopOneClient destroying the NetworkManager when destroy is set to false.
ShadauxCat
approved these changes
Mar 12, 2024
NoelStephensUnity
deleted the
fix/host-on-client-disconnect-local-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix assures a host will invoke
OnClientDisconnectCallbackfor its local client when it is internally shutting down.fix: #2789
Changelog
OnClientDisconnectCallbackfor its own local client when internally shutting down.Testing and Documentation