Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: host not generating its own local client disconnect notification #2822

Merged
merged 11 commits into from
Mar 12, 2024
Merged

fix: host not generating its own local client disconnect notification #2822

merged 11 commits into from
Mar 12, 2024

Commits on Feb 4, 2024

  1. fix 

    Assure the host generates a notification for the local host client no longer being connected when it shuts itself down.
    @NoelStephensUnity
    NoelStephensUnity committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    6e9afdb View commit details
    Browse the repository at this point in the history

  2. test 

    Include modification to the DisconnectTest to validate this fix.
    @NoelStephensUnity
    NoelStephensUnity committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    7c0ef24 View commit details
    Browse the repository at this point in the history

  3. update 

    updating the change log
    @NoelStephensUnity
    NoelStephensUnity committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    31fa58f View commit details
    Browse the repository at this point in the history

  4. update 

    fixing improper name for callback
    @NoelStephensUnity
    NoelStephensUnity committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    d2cdfb8 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. style

    @NoelStephensUnity
    NoelStephensUnity committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    9f5ce0b View commit details
    Browse the repository at this point in the history

  2. test 

    Rewrote the SenderIdTest to be a bit more flexible with regard to waiting for the client disconnect event and not failing if it received anything afterwards.
    @NoelStephensUnity
    NoelStephensUnity committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    2470bb4 View commit details
    Browse the repository at this point in the history

  3. style 

    whitespace removal
    @NoelStephensUnity
    NoelStephensUnity committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    49194e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. test - fix 

    Adding check for ConnectionEvent.ClientDisconnected for both test types.
Fixing issue with StopOneClient destroying the NetworkManager when destroy is set to false.
    @NoelStephensUnity
    NoelStephensUnity committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    67c9e80 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Merge develop into fix/host-on-client-disconnect-local-client

    @netcode-ci-service
    netcode-ci-service committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    4037ddd View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Merge develop into fix/host-on-client-disconnect-local-client

    @netcode-ci-service
    netcode-ci-service committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e480bc9 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Merge develop into fix/host-on-client-disconnect-local-client

    @netcode-ci-service
    netcode-ci-service committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    4e098a4 View commit details
    Browse the repository at this point in the history