Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop modify stepping logic #3448

Merged
merged 10 commits into from
Feb 19, 2020
Merged

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Making changes to the step counting in both the Academy and the Agent.
The Academy will first set status, then tick its step count, then tick all agents step counts.
Collect observations and Act happen as usual.
At the end of the loop, the Agent resets if max step was reached.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Is continuation of #3432
Jira is MLA-619

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added updated the changelog (if applicable)
  • I have added necessary documentation (if applicable)
  • I have updated the migration guide (if applicable)

Other comments

 - Created a new Academy Event called AgentIncrementStep to be called before SetStatus
 - Implemented the AgentSteping logic
…it the tests but I think they are now closer to what we want
@surfnerd
Copy link
Contributor

surfnerd commented Feb 14, 2020

what does the step count look like for an episode?

It looks like if maxStep = 5 the step count will look like:

AgentStep = 1
  Agent Observe; Agent Act;
AgentStep = 2
  Agent Observe; Agent Act;
AgentStep = 3
  Agent Observe; Agent Act;
AgentStep = 4
  Agent Observe; Agent Act;
AgentStep = 5
  Agent Observe; Agent Act; Agent Reset;

Is my understanding correct?

@vincentpierre
Copy link
Contributor Author

Is my understanding correct?

Yes, this is what I am aiming at

vincentpierre and others added 2 commits February 14, 2020 14:05
Co-Authored-By: Chris Goy <goyenator@gmail.com>
Co-Authored-By: Chris Goy <goyenator@gmail.com>
Copy link
Contributor

@surfnerd surfnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to make sense. Should there be a test for this?

@vincentpierre vincentpierre marked this pull request as ready for review February 17, 2020 02:19
Co-Authored-By: Chris Elion <chris.elion@unity3d.com>
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just add something in the changelog.

@vincentpierre vincentpierre merged commit ed5f2be into master Feb 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-modify-stepping-logic branch February 19, 2020 00:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants