Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wget and gdebi for xvfb and add to apt-get #4791

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Conversation

andrewcoh
Copy link
Contributor

@andrewcoh andrewcoh commented Dec 22, 2020

Proposed change(s)

The patch for xvbf is gone (http://security.ubuntu.com/ubuntu/pool/universe/x/xorg-server/xvfb_1.18.4-0ubuntu0.10_amd64.deb).

This adds xvfb to the list of packages for apt-get install and removes wget and gdebi for xvfb. Also, updates cuda base image.

Reflects changes to the cloud repo https://github.com/Unity-Technologies/ml-agents-cloud-internal/pull/253/commits/297f4c457be91f7539cd67820ef0351d0bd98f81

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Copy link
Contributor

@hvpeteet hvpeteet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andrewcoh andrewcoh merged commit 13332ad into master Dec 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-dockerfile branch December 22, 2020 19:30
chriselion pushed a commit that referenced this pull request Dec 22, 2020
Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants