Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move common loss functions for PPO and POCA #5079

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Move common loss functions for PPO and POCA #5079

merged 2 commits into from
Mar 11, 2021

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Mar 11, 2021

Proposed change(s)

Move shared loss functions to ModelUtils.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng requested a review from andrewcoh March 11, 2021 00:55
@ervteng ervteng merged commit 20c8759 into develop-coma2-trainer Mar 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-poca-staticfn branch March 11, 2021 02:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewcoh andrewcoh andrewcoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ervteng @andrewcoh