Unity master new unitychanges profiles #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nothing here jumps out at me - this all looks sane. Thanks! |
UnityAlex
force-pushed
the
unity-master-new-unitychanges
branch
from
bf32378
to
188d261
Compare
|
I've pushed two commits to this branch to allow the profile stubber to work and to enable it in the build. |
…e profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script.
…et_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master.
The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled.
UnityAlex
force-pushed
the
unity-master-new-unitychanges-profiles
branch
from
3aafee9
to
69cafb9
Compare
joncham
reviewed
May 15, 2020
| -d:UNITY_AOT \ | ||
| -d:MOBILE,MOBILE_LEGACY \ | ||
| -d:DISABLE_COM \ | ||
| -d:WIN_PLATFORM \ |
There was a problem hiding this comment.
Fine for now, but if the aot profile will be cross platform the windows defines likely don't make sense.
joncham
reviewed
May 15, 2020
| @@ -0,0 +1 @@ | |||
| #include win32_build_corlib.dll.sources | |||
There was a problem hiding this comment.
Again, win32 based. Fine for now but we'll need to address this.
|
Looks okay-ish. We'll need to figure out how to make unityaot be platform independent. |
UnityAlex
added a commit
that referenced
this pull request
May 15, 2020
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
May 21, 2020
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Jun 10, 2020
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Jul 1, 2020
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Jul 17, 2020
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Jul 31, 2020
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Aug 14, 2020
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Sep 24, 2020
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Oct 30, 2020
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Nov 13, 2020
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Dec 22, 2020
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Jan 29, 2021
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Feb 5, 2021
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Feb 12, 2021
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Feb 22, 2021
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
UnityAlex
added a commit
that referenced
this pull request
Mar 16, 2021
* Adding unityjit and unityaot profiles and attempting to build with them. WIP * Classlibs now appear to build successfully. Need to start trimming the profiles to remove uneeded APIs Fixing typo that would cause case sensitive systems (linux) to fail to build the win32 unityjit profile. Also adding clean option to linux runtime build script. * Fixing file copying so unityjit and unityaot wind up in monodistribution correctly. * Disabliing profile stubber for now... do we still need it? * Created a function for profile copying code. We are now copying the net_4_x profile in addition to the unityjit and unityaot profiles. Also removed some unityscript and boo stuff we don't need anymore and has already been removed in unity-master. * Make EndpointAddress10 public in the unityaot profile The profile stubber cannot handle changing a type from `internal` to `public`, so just make this type `public` when the profile is compiled. * Enable the use of the profile stubber for all unity profiles Co-authored-by: Josh Peterson <joshuap@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought it would be a good idea to let you guys take a look at what was involved to get the unityjit-^OS^ and unityaot profiles created. I assume there are some definite things that we want removed as I somewhat blindly followed the net_4_x and winaot profiles when setting these up.