pkg(com.hoffnung): change removal

[stormbeforesunsetbee]

In my case, it cause the screen went blank, but the power option UI is still accessible on my Infinix phone. But there's a worse case: https://xdaforums.com/t/infinix-note-10-uninstall-tpms-com-hoffnung-package-causes-bootloop.4647456/

So, just don't recommend 'com.hoffnung'

[AnonymousWP]

Thanks for your PR. I'll review it after I got some questions answered that I'm curious about:

1. After reading through the XDA post, com.hoffnung is an app for car enthusiasts. Why is the Android skin of Infinix depending on this app as if it's highly essential?
2. We should at least also mention this in the description field, don't you think?

[ThatGreenBlur]

Hi! I have a Infinix HOT 12 Play and disabling com.hoffnung has never caused issues for me and is just a random background process that also has some telemetry, what seems to be your phone?

[ThatGreenBlur]

Also did you use Disable instead of Uninstall?

[Blitz517]

dont put it in expert, he just didnt read description

[AnonymousWP]

@rivanfebrian123 Please follow up on this.

[ThatGreenBlur]

if he doesnt follow up, i suggest we keep it because disabling it for me does help because it is a unnecessary background process, we can assume that he didnt disable but rather uninstall

[stormbeforesunsetbee]

Sorry for late follow up

Replies

Why is the Android skin of Infinix depending on this app as if it's highly essential?

It's the XOS thingies I guess

We should at least also mention this in the description field, don't you think?

Sure, that would be great

Also did you use Disable instead of Uninstall?

I uninstalled it

dont put it in expert, he just didnt read description

I think most of beginners would just select all and uninstall them

if he doesnt follow up, i suggest we keep it because disabling it for me does help because it is a unnecessary background process

Yep, but the thing is, the default action for 'recommended' package is to uninstall them. So beginners would assume that it's safe to do that (clicking the button)

[AnonymousWP]

I'm either thinking about moving it to Advanced or change its description. Two reasons/things about this:

1. Users should always carefully read the descriptions of packages

2. Recommended means the package complies with the following description:

   Pointless or outright negative packages, and/or apps available through Google Play.

   Is that the case? No, I don't think so.

[ThatGreenBlur]

i agree that beginners should be able to just select everything in recommended and be able to just press uninstall and be done, however com.hoffnung is in a tough position where disabling it is absolutely recommended but it has to actually be disabled
my idea is that we somehow get that package to always be disabled no matter what but that might require program changes
or we recommend to disable programs as a default

[stormbeforesunsetbee]

What if... we make it possible to use different removal action for different package? With that being said, the JSON file would look like this:

  "com.hoffnung": {
    "description": "TPMS\nRemote Config Test. Instead Uninstall better Disable this app\nbecause it uninstalling cause screen flicker",
    "removal": "Recommended",
    "removalAction": "Disable",
    "list": "Oem",
    "dependencies": [],
    "neededBy": [],
    "labels": []
  },

[ThatGreenBlur]

this also goes for tech.palm.id which is recommended to be disabled

[AnonymousWP]

What if... we make it possible to use different removal action for different package? With that being said, the JSON file would look like this:

  "com.hoffnung": {
    "description": "TPMS\nRemote Config Test. Instead Uninstall better Disable this app\nbecause it uninstalling cause screen flicker",
    "removal": "Recommended",
    "removalAction": "Disable",
    "list": "Oem",
    "dependencies": [],
    "neededBy": [],
    "labels": []
  },

This requires a feature request. Also, all packages would need this extra field.

[AnonymousWP]

Closing this PR as the user did not carefully read its description (it clearly said you should disable, not uninstall). I'll make a change to the description.

[Rudxain]

#609 (comment)