Review CI by correcting the configurations #71

destogl · 2021-04-10T08:31:30Z

PR against destogl/edit-non-functional-files (#70) for better changes overview.

It should be rebased after (#70) is merged. But it can be already reviewed.

…iversal_Robots_ROS2_Driver into add-support-for-gpios

destogl · 2021-04-13T14:26:41Z

@AndyZe this can be reviewed after #66 is merged. It is expected that "Format" fails. The correction will be done in the follow-up PR.

AndyZe · 2021-04-13T17:53:08Z

@denis I tried to rebase this but it has almost diverged too far to do manually. Can you handle that?

Or, you might want to create a new branch (starting from develop) and cherry-pick the new commits you want to keep. That would probably be easier. Then make a new PR

destogl · 2021-04-13T20:30:29Z

I commented out the dependency on ur_client_library because it can not be found by rosdep. We are not exporting it properly. Opening follow-up issue for this.

destogl · 2021-04-13T20:39:56Z

The coverage build has issues with the ur_client_library, but industrial_ci is working. We should go for merge...

AndyZe

I'll push a commit to clean up my minor nitpicks

CONTRIBUTING.md

AndyZe · 2021-04-13T20:41:24Z

LICENSE

+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright [yyyy] [name of copyright owner]
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.


Is this something people normally do with the Apache license? I'm not familiar with it but it seems unusual to modify the license file. Think I will ask @tylerjw to review this PR

Please generate the license with ament_copyright adding the copyright holder and year correctly.

ur_controllers/package.xml

ur_robot_driver/package.xml

AndyZe · 2021-04-13T20:45:25Z

@tylerjw can you please review the license and CI stuff?

tylerjw · 2021-04-13T20:55:46Z

Please fix the Format errors. Here is a guide for using pre-commit to fix those issues: https://moveit.ros.org//documentation/contributing/code/

destogl · 2021-04-13T21:14:18Z

Please fix the Format errors. Here is a guide for using pre-commit to fix those issues: https://moveit.ros.org//documentation/contributing/code/

I want to fix them in the separate PR to keep them smaller.

…sal_Robots_ROS2_Driver into destogl/revive-ci

tylerjw

I don't understand not fixing the pre-commit errors (outside of the catkin_lint errors) or not squashing this before merging. The 58 commits are completely unnecessary (this is a ~300 line pr) and most of the pre-commit errors are fixed automatically by just running pre-commit. The catkin_lint ones would be more work but I still would have wanted to see them fixed.

😕

tylerjw · 2021-04-13T21:34:36Z

LICENSE

@@ -187,7 +187,7 @@
      same "printed page" as the copyright notice for easier
      identification within third-party archives.

-   Copyright [yyyy] [name of copyright owner]
+   Copyright 2021 PickNik, Inc.


This should be PickNik Inc. (no comma) as @nbbrooks had me do for moveit2 as that is the legal name we should use.

* Update license. * Update CI configs. Co-authored-by: Lovro <lovro.ivanov@gmail.com> Co-authored-by: AndyZe <zelenak@picknik.ai>

livanov93 and others added 20 commits April 10, 2021 09:26

Add ur_msgs as dependency.

5cdb039

Bare bone tool io controller.

0f518b4

Register all non-joint interfaces.

973deec

Fix typo.

9db0ec9

Configure state and command interfaces in gpio controller.

7b10559

Fix clang issue.

a4443c7

Register needed services and publishers.

5ddd54c

Reorganize state and command interfaces for easier enumeration.

192a4d3

Update licence.

5c3ca1d

Include success check for io service.

f829008

Fix ci.

b0f84f1

Publish data of interest.

4e76086

Clang tidy.

10e4c5e

Apply suggestions from code review

d649e1a

Launch Arguments for xacro are working, not all params added

371cbd3

Moved files and one step further with the Arguemnts

fa3ce36

Add launch for all version of UR robots

452f024

Small updated from offline review

6e7d6c7

Some rewrapping and testing GPIO controller.

98a8e08

Reduce unintended changes

8af1cd2

destogl changed the base branch from main to develop April 10, 2021 08:33

destogl marked this pull request as draft April 10, 2021 08:33

AndyZe and others added 8 commits April 11, 2021 10:02

Readme grammar check and minor re-org

2fc8dba

Minor comment and typo cleanup

43bc4f0

Reduce duplication of default launch args

35fb4e7

Initial add of moveit configs

0b53e7c

Added MoveIt configs and example launch file

749ac6f

Remove unused mongodb node

82e71de

Merge branch 'add-support-for-gpios' of github.com:PickNikRobotics/Un…

6a7c25b

…iversal_Robots_ROS2_Driver into add-support-for-gpios

Enabled monogodb

34dc8f0

destogl added 2 commits April 13, 2021 16:20

Now all pre-commit hooks are working

db8d03b

Update package list for ros-tooling CI

3211a22

destogl force-pushed the destogl/revive-ci branch from 8eadbb7 to 3211a22 Compare April 13, 2021 14:25

destogl marked this pull request as ready for review April 13, 2021 14:25

destogl added 2 commits April 13, 2021 16:28

Remove lint CI. It is integrated into Format check.

876b325

Use old clang-format configuration. It was OK

590c737

Merge branch 'develop' into destogl/revive-ci

7eccd3c

destogl mentioned this pull request Apr 13, 2021

Edit and Clean non-functional files #70

Closed

destogl requested a review from AndyZe April 13, 2021 20:28

destogl mentioned this pull request Apr 13, 2021

Enable ur_client_library dependency #78

Closed

AndyZe reviewed Apr 13, 2021

View reviewed changes

AndyZe requested a review from tylerjw April 13, 2021 20:45

Minor CONTRIBUTING.md and package.xml cleanup

3d5aedd

AndyZe approved these changes Apr 13, 2021

View reviewed changes

destogl added 2 commits April 13, 2021 23:21

Added license owner

2a0ead8

Merge branch 'destogl/revive-ci' of github.com:PickNikRobotics/Univer…

bfa7f84

…sal_Robots_ROS2_Driver into destogl/revive-ci

destogl merged commit 3790877 into develop Apr 13, 2021

delete-merged-branch bot deleted the destogl/revive-ci branch April 13, 2021 21:23

tylerjw reviewed Apr 13, 2021

View reviewed changes

AndyZe pushed a commit that referenced this pull request Apr 14, 2021

Review CI by correcting the configurations (#71)

dc4511d

* Update license. * Update CI configs. Co-authored-by: Lovro <lovro.ivanov@gmail.com> Co-authored-by: AndyZe <zelenak@picknik.ai>

AndyZe pushed a commit that referenced this pull request Apr 14, 2021

Review CI by correcting the configurations (#71)

72de46d

* Update license. * Update CI configs. Co-authored-by: Lovro <lovro.ivanov@gmail.com> Co-authored-by: AndyZe <zelenak@picknik.ai>

AndyZe pushed a commit that referenced this pull request Apr 14, 2021

Review CI by correcting the configurations (#71)

111fb9b

* Update license. * Update CI configs. Co-authored-by: Lovro <lovro.ivanov@gmail.com> Co-authored-by: AndyZe <zelenak@picknik.ai>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Review CI by correcting the configurations #71

Review CI by correcting the configurations #71

destogl commented Apr 10, 2021 •

edited

Loading

destogl commented Apr 13, 2021 •

edited

Loading

AndyZe commented Apr 13, 2021

destogl commented Apr 13, 2021 •

edited

Loading

destogl commented Apr 13, 2021

AndyZe left a comment

AndyZe Apr 13, 2021

tylerjw Apr 13, 2021

AndyZe commented Apr 13, 2021

tylerjw commented Apr 13, 2021

destogl commented Apr 13, 2021

tylerjw left a comment •

edited

Loading

tylerjw Apr 13, 2021

Review CI by correcting the configurations #71

Review CI by correcting the configurations #71

Conversation

destogl commented Apr 10, 2021 • edited Loading

destogl commented Apr 13, 2021 • edited Loading

AndyZe commented Apr 13, 2021

destogl commented Apr 13, 2021 • edited Loading

destogl commented Apr 13, 2021

AndyZe left a comment

Choose a reason for hiding this comment

AndyZe Apr 13, 2021

Choose a reason for hiding this comment

tylerjw Apr 13, 2021

Choose a reason for hiding this comment

AndyZe commented Apr 13, 2021

tylerjw commented Apr 13, 2021

destogl commented Apr 13, 2021

tylerjw left a comment • edited Loading

Choose a reason for hiding this comment

tylerjw Apr 13, 2021

Choose a reason for hiding this comment

destogl commented Apr 10, 2021 •

edited

Loading

destogl commented Apr 13, 2021 •

edited

Loading

destogl commented Apr 13, 2021 •

edited

Loading

tylerjw left a comment •

edited

Loading