remove use_mock_hardware from moveit launchfile #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fdurchdewald Could you please fix the duplicated target in the |
2 tasks
fmauch
reviewed
Nov 15, 2023
|
@fdurchdewald does this means that you will have different robot descriptions used on driver launch and MoveIt launch |
No, we should remove the description from the moveit launch. AFAIK it takes the one from the RSP's description topic by now. |
|
Before merging this, we should consider UniversalRobots/Universal_Robots_ROS2_Gazebo_Simulation#22 What do we do about the scaled jtc in gazebo? Probably we should still provide an option for the default controller. |
fdurchdewald
force-pushed
the
issue-830
branch
3 times, most recently
from
cda731b
to
1ae71fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scaled JTC can be used on fake hardware as well. Therefore, there is no real reason for keeping the use_mock_hardware argument in the MoveIt launch file.