keeping sidebars and header visible on mobile view #949
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 125a86d:
|
| @@ -32,6 +32,9 @@ export class LeftPanel< | |||
| this.options.panelOpen | |||
| ); | |||
|
|
|||
| const viewportWidth: number = document.documentElement.clientWidth; | |||
| if(viewportWidth <= 767) return; | |||
There was a problem hiding this comment.
I like the functionality that this provides, but I wonder if we can implement it in a more flexible way that avoids hard-coded magic numbers. Might it make sense to replace the panelOpen boolean configuration setting with a panelOpenMinWidth integer setting? Then it could be 0 to always open, some incredibly high number to always close, or a configurable breakpoint the rest of the time. What do you think? @edsilv?
Description of what you did:
Modified CSS rules to keep sidebar and header visible when on mobile view. Relating to issue #938