Fix crash with /restart kt

G_ChangeTeam was doing ClientSpawn which shouldn't happen for clients
that haven't entered the game.

src/sgame/sg_client.cpp

@@ -1197,16 +1197,16 @@ const char *ClientConnect( int clientNum, bool firstTime )
 		                                Quote( client->pers.netname ) ) );
 	}
 
-	// count current clients and rank for scoreboard
-	CalculateRanks();
-
 	// if this is after !restart keepteams or !restart switchteams, apply said selection
 	if ( client->sess.restartTeam != TEAM_NONE )
 	{
 		G_ChangeTeam( ent, client->sess.restartTeam );
 		client->sess.restartTeam = TEAM_NONE;
 	}
 
+	// count current clients and rank for scoreboard
+	CalculateRanks();
+
 	return nullptr;
 }
 

src/sgame/sg_team.cpp

@@ -284,6 +284,25 @@ void G_ChangeTeam( gentity_t *ent, team_t newTeam )
 		return;
 	}
 
+	if ( ent->client->pers.connected != CON_CONNECTED )
+	{
+		// This can happen with /restart ktl (or admin putteam maybe?).
+		// We shouldn't call ClientSpawn if it hasn't entered the game.
+
+		ent->client->pers.team = newTeam;
+
+		// userinfo configstrings
+		ClientUserinfoChanged( ent->client->ps.clientNum, false );
+
+		// configstring restrictions
+		G_UpdateTeamConfigStrings();
+
+		// Prevent the team from getting stomped on by G_namelog_restore later
+		G_namelog_update_score( ent->client );
+
+		return;
+	}
+
 	G_LeaveTeam( ent );
 	ent->client->pers.teamChangeTime = level.time;
 	ent->client->pers.team = newTeam;