Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't replace the last egg that supports other structures without replacing them first/also. #625

Closed
lamefun opened this issue Feb 22, 2015 · 7 comments
Labels
A-Gamelogic T-Improvement Improvement for an existing feature

Comments

@lamefun
Copy link
Contributor

lamefun commented Feb 22, 2015

Sometimes I mark an egg for replacement and build something only to find this was the last egg supporting a lot of buildings, and they die.

@illwieckz
Copy link
Member

Yes, replacing an egg with an acide tube (for example), and 5 acide tubes, 5 trappers and 10 hives die. 😧

No need to be the last egg, only the last egg for an area where there is buildings.

@Kangz Kangz added A-Gamelogic T-Improvement Improvement for an existing feature labels Feb 23, 2015
@Viech Viech changed the title Last egg Don't replace the last egg that supports other structures without replacing them first/also. Feb 25, 2015
@lamefun
Copy link
Contributor Author

lamefun commented Mar 11, 2015

I can also Alt+E deconstruct the last egg supporting a bunch of structures.

@illwieckz
Copy link
Member

gameplay changes actually in pipe makes this issue obsolete: with these changes unpowered buildables are just unpowered and ineffective, but not destroyed.

@illwieckz illwieckz added this to the Alpha 51 (v0.51.0) milestone Oct 23, 2017
@DolceTriade
Copy link
Member

DolceTriade commented Oct 24, 2017

I haven't tested to confirm whether this is accurate for aliens.

For the record, we allow replacing the last spawn, but only as a last resort:
https://github.com/Unvanquished/Unvanquished/blob/master/src/sgame/sg_buildable.cpp#L1013

@illwieckz
Copy link
Member

illwieckz commented Oct 24, 2017

I confirm that removing eggs can't destroy any alien creep anymore. Change introduced makes all alien buildables alive if the overmind is alive, and makes the buildables shutdown (not destroyed, alive but ineffective) if overmind is down. The other case where an alien buildable shutdown is when they depend on leech build point pool and nearly leech was destroyed/removed, but in that other case, the nearby buildables are not destroyed too, they are just unpowered.

Human behavior is the same.

By releasing 0.51.0 this issue will be fixed.

@illwieckz
Copy link
Member

mmmh, is that code in master or in devgames branch? if in master we can close this issue.

@illwieckz
Copy link
Member

I confirm the code is in for-0.51.0 branch, hence this issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Gamelogic T-Improvement Improvement for an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants