-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rmlui: Update assets after the update to master #146
Conversation
This should target something other than master, shouldn't it? |
Ah those are not silenced
It looks like I fixed the |
Yes maybe, we can change the target anyway once we create a better one. |
This may be needed on Unvanquished side: diff --git a/src/cgame/rocket/rocket.cpp b/src/cgame/rocket/rocket.cpp
index ace047a83..bff864a39 100644
--- a/src/cgame/rocket/rocket.cpp
+++ b/src/cgame/rocket/rocket.cpp
@@ -394,7 +394,7 @@ void Rocket_Init()
// Add custom client elements
RegisterElement<SelectableDataGrid>( "datagrid" );
- RegisterElement<RocketProgressBar>( "progressbar" );
+ RegisterElement<RocketProgressBar>( "progress" );
RegisterElement<RocketDataSelect>( "dataselect" );
RegisterElement<RocketConsoleTextElement>( "console_text" );
RegisterElement<RocketDataSourceSingle>( "datasource_single" ); But some progress bar are still full white, and they're always full. Anyway this is low priority, I just wanted to try to know if that was easy or not. |
rmlui starts children nodes at index 1, so we need to skip the first child since that is the cancel button.
Master changed it so that properties should be set for the main element, not the fill child element.
The branch is named
ishq/rmlui
despite not being mine because this way it's easier to find:I spotted that:
But that breaks HUD progress bars.