Update RmlUI to master #2027
Merged
Update RmlUI to master #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow wow wow wow |
|
Spotted:
|
|
Once people have reviewed it, I will squash the broken commits |
slipher
reviewed
Aug 11, 2022
slipher
reviewed
Aug 11, 2022
|
Yeah, I will only squash enough that it compiles and loads without errors. |
The following changes compile and generally work, but are buggy. Below are the squashed changes: rmlui: Update srclists code doesn't compile rmlui: Rml::Core -> Rml:: sed -i 's/Rml::Core/Rml/g' `grep -r Rml::Core | cut -d: -f1 | sort -u` rmlui: Fix srclists rmlui: Fix GetIntrinsicDimensions args rmlui: Rename Rml::Controls -> Rml:: rmlui: Rename RmlUi/Controls -> RmlUi/Core rmlui: Rename RmlUi/Core/Lua -> RmlUi/Lua rmlui: Remove nonexistent Rmlui/Lua/Controls.h rmlui: A bunch of other API upgrades and fixes that I forget rmlui: Don't initialize rmlui twice rmlui: Rename progresbar -> progress to be consistent with RmlUI thanks @illwieckz
Now it properly remembers your old value.
If we start with regenerationInterval == 0, it leads to a divide by zero because the we won't set regenerationInterval to interval because it's guarded by an "else if".
For example, if I run rocket menu_main reload, It will only reload that file. Say menu_main.rml contains <link type="text/rcss" href="/ui/shared/basics.rcss" />, and I edit basics.rcss, any changes to basics.rcss will not be reflected in the reload. Given that this is a developer focused command and there really isn't a huge performance penalty for this, I think it is a safe change.
GCC7 has a bunch of warnings that fail under -Werror with rmlui on master like: : error: ‘Rml::Style::InheritedValues::line_height_inherit_type’ is too small to hold all values of ‘enum Rml::Style::LineHeight::InheritType’ [-Werror]
The old code naively just set the value of the form to the value of the cvar and hoped RmlUi would do something intelligent if the value set didn't mask any of the options. However, RmlUi will simply select the last value if it doesn't match any of the values. This is not what we want, so if be smarter by checking the values of all the options, if none of them match, dynamically add a new option for the current value.
This always sets the value, even when it hasn't changed, or sets it to the wrong value.
DolceTriade
force-pushed
the
ishq/rmlui
branch
from
c9f4e23
to
9b31997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer buggy 😄 Thanks for all your testing!