Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charging Loop Counter not always considered #18

Closed
JanBoldt-uml opened this issue Jan 10, 2018 · 1 comment
Closed

Charging Loop Counter not always considered #18

JanBoldt-uml opened this issue Jan 10, 2018 · 1 comment

Comments

@JanBoldt-uml
Copy link

JanBoldt-uml commented Jan 10, 2018

Hello,

Thanks for providing this great tool, it has been very helpful in getting a feel for the V2G communication.

As i have been "playing around" with RiseV2G, i noticed the isChargingLoopActive method and the chargingLoopCounter in the DummyEVController, which are used to control the number of charging loops and thus the amount of messages exchanged in between the EVSE and the EV.

When setting the energy transfer mode to DC_COMBO_CORE (via the EVCCConfig.properties or the getRequestedEnergyTransferMode method of the DummyEVController) the amount of exchanged messages increases significantly compared to other transfer modes. Often there are more than 100 CurrentDemandReq/Res and MeteringReceiptReq/Res pairs. Apparently the MeteringRecipt handling does inhibit the correct consideration of the charge loops.

The communication finally terminates when a Signature Exception is thrown at the EVSE side, which seems to be a different issue.

Could you please confirm this behaviour? - Thank you!

MarcMueltin pushed a commit that referenced this issue Jan 12, 2018
…eteringReceiptRes) and #19 (error in DER encoding of ECDSA signature)
@MarcMueltin
Copy link
Contributor

Hi Jan,

I fixed the issue with commit 0e4b838.
The problem was that the class WaitForMeteringReceiptRes did not check if the chargingLoop is still active.
Thanks for the hint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants