Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider unifying collapsible "dropdown" functionality #114

Open
jernestmyers opened this issue Sep 14, 2022 · 0 comments
Open

Consider unifying collapsible "dropdown" functionality #114

jernestmyers opened this issue Sep 14, 2022 · 0 comments

Comments

@jernestmyers
Copy link
Contributor

In looking over options for a "dropdown" icon, I noticed that we handle this functionality in various ways.

In genomics records pages, we leverage WDKClient's CollapsibleSection component. In terms of icon, it uses Font Awesome's fa-caret-down and its related fa-caret-right. It looks as follows:

image

In web-eda's variable selection buttons, we'll see two different dropdown implementations in the popover: one for the Featured variables and another to expand/collapse the variables. Note the difference between the icons. The expand/collapse toggle for Featured variables uses the native HTML elements details and summary and thus uses the browser's default icon for such elements. On the other hand, the expand/collapse functionality in the variable tree derives from CheckboxTreeNode and uses the same icons as the CollapsibleSection. (Note also that the button itself uses the same icon.)
image

In the short term, I suspect we could leverage CollapsibleSection for the "Featured variables" to unify the icons in the dropdown menu. In the long term, we may want to create a version of a CollapsibleSection component in CoreUI that could meet our use cases described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants