OrthoMCL - Custom tree-table for OrthoGroup page #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobular
changed the title
… the Mesa inline option
…cally fixed-height mode)
…de (basically fixed-height mode)" This reverts commit f215762.
dmfalke
reviewed
Mar 19, 2024
Comment on lines
96
to
111
| <div | ||
| style={{ | ||
| flexGrow: 1, | ||
| width: 1 /* arbitrary non-zero width seems necessary for flex */, | ||
| }} | ||
| > | ||
| <Global | ||
| styles={globalStyle` | ||
| .DataTable { | ||
| margin-bottom: 0px !important; | ||
| width: 80%; | ||
| } | ||
| `} | ||
| /> | ||
| <Mesa state={tableState} /> | ||
| </> | ||
| </div> |
There was a problem hiding this comment.
Sorry, I'm just noticing this. I'm not sure we should use Global here, as the style will be reflected on all subsequent pages.
Instead, could you use a css prop on the parent div component (line 96), and target .DataTable in there?
<div
css={{
flexGrow: 1,
width: 1 /* arbitrary non-zero width seems necessary for flex */,
'.DataTable': {
marginBottom: '0px !important',
width: '80%'
}
}}
>
<Mesa state={tableState} />
</div>There was a problem hiding this comment.
Oh yeah, that's much simpler (and no side effects) - done in 5c896a0 - thanks!
There was a problem hiding this comment.
Could we change these identifiers such that they include the "group" prefix? E.g., GroupTreeResponse, groupTreeResponseDecoder, etc?
|
Latest commit adds this. No dashed outline when there are PFam domains. |
…use flex-wrap to prevent large buttons crowding the search box
…ilter Orthogroup tree table pfam filter
…o-instant-filters
…ther optimisations
…o-instant-filters
Instant filters for the orthogroup page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
There are only a few tree files available on the back end, so only a few orthogroups work. Here's are the valid OGs at the moment:
Run
ortho-sitelocally and access the path/app/record/group/OG6_102443Back end config for
.envisTo do:
From the #1140 branch
UX suggestions