-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orthogroup tree table pfam filter #1140
Orthogroup tree table pfam filter #1140
Conversation
…use flex-wrap to prevent large buttons crowding the search box
Hi @dmfalke I just made some adjustments to avoid the species button overflowing with taxon abbreviations. I also made the update behaviour consistent between all three filters. I wonder if all the popovers should have a "close" or "apply" button? (or even a cancel/apply...?) |
For "Add ability to highlight table rows from species filter" why don't we just highlight the rows that have their checkboxes checked? This way users can use any search they like to highlight rows. |
This PR introduces table filters to the tree table section of group pages. There are three filters: pfam domains, core/peripheral, and species.
The first two filters are applied after the popover is dismissed, while the third one is applied immediately. This is a bug, as the intended behavior is to apply the selection after the popover is dismissed. Question: Which behavior is preferable?
Here is a screenshot:
TODO