Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orthogroup tree table pfam filter #1140

Merged
merged 11 commits into from
Jul 18, 2024

Conversation

dmfalke
Copy link
Member

@dmfalke dmfalke commented Jul 16, 2024

This PR introduces table filters to the tree table section of group pages. There are three filters: pfam domains, core/peripheral, and species.

The first two filters are applied after the popover is dismissed, while the third one is applied immediately. This is a bug, as the intended behavior is to apply the selection after the popover is dismissed. Question: Which behavior is preferable?

Here is a screenshot:
image

TODO

  • Remove "Phyletic distribution" section
  • Move "Protein" section to top
  • Add ability to highlight table rows from species filter

@dmfalke dmfalke requested a review from bobular July 16, 2024 15:44
@dmfalke dmfalke changed the base branch from main to orthogroup-tree-table July 16, 2024 16:58
@bobular
Copy link
Member

bobular commented Jul 17, 2024

Hi @dmfalke

I just made some adjustments to avoid the species button overflowing with taxon abbreviations.

I also made the update behaviour consistent between all three filters.

I wonder if all the popovers should have a "close" or "apply" button? (or even a cancel/apply...?)

@bobular
Copy link
Member

bobular commented Jul 17, 2024

For "Add ability to highlight table rows from species filter" why don't we just highlight the rows that have their checkboxes checked? This way users can use any search they like to highlight rows.

@bobular
Copy link
Member

bobular commented Jul 17, 2024

For "Add ability to highlight table rows from species filter" why don't we just highlight the rows that have their checkboxes checked? This way users can use any search they like to highlight rows.

Here's what it looks like (after filter, select all, unfilter)

image

@bobular bobular merged commit f00a872 into orthogroup-tree-table Jul 18, 2024
1 check passed
@bobular bobular deleted the orthogroup-tree-table__pfam-filter branch July 18, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants