Instant filters for the orthogroup page

[bobular]

Note that this targets orthogroup-tree-table, so can be merged without review.

Maybe we demo both or make a video with both?

[dmfalke]

Sorry for the delay. I will take a look at this today or tomorrow

[dmfalke]

I think the name of the new prop should be consistent with what we use for the checkbox select component. I'm fine with both being instantUpdate.

Also, I don't think buttonDisplayContent needs to be tracked with React state. I know this was already in place, but would be good to remove all unnecessary state and effects.

[dmfalke]

This should be called in a callback used as the onChange prop of CheckboxList. We don't currently have one defined, so it will be a new callback.

[bobular]

Hi @dmfalke - thanks for the review.

I removed all but one effect thanks to your suggestion. While testing things were still working in EDA/Lineplot I found a new bug (already on qa and presumably prod) which I have a fix for too.

I don't think it's wise to get rid of the local state for buttonDisplayContent . The local state allows us to delay changing the button label until the drop-down is closed, which prevents it moving around as its contents change. I think this is OK.

[dmfalke]

I don't think it's wise to get rid of the local state for buttonDisplayContent . The local state allows us to delay changing the button label until the drop-down is closed, which prevents it moving around as its contents change. I think this is OK.

Makes sense. Thanks for checking!