Remove watcher #51
Closed
Remove watcher #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remram44
added
T-enhancement
remram44
force-pushed
the
master
branch
2 times, most recently
from
18a2b63
to
268ba00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally opened 2020-03-30 13:44 EDT by @remram44
Fixes #46
Instead of having the 'web' pod watch started 'runner' pods to note their exit, update the database, and delete them, this makes the 'runner' pods do it themselves.
This means less processing in the 'web' pod and easier horizontal scaling, but is more dangerous: if something goes wrong in the 'runner' pod no one is deleting it.
Maybe there should still be a regular process in the 'web' pod going over terminated pods, noting problems, and reaping them.