Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: TEST: Добавить тесты #1152

Merged
merged 29 commits into from
Dec 14, 2020
Merged

WIP: TEST: Добавить тесты #1152

merged 29 commits into from
Dec 14, 2020

Conversation

thoughtspile
Copy link
Contributor

@thoughtspile thoughtspile commented Nov 18, 2020

  • Этот пр ждёт ключей от корпоративного с3
  • .github/workflows/update_screens.yml нужно черипикнуть в мастер, чтобы подсосался экшн для обновления скриншотов

@thoughtspile thoughtspile requested a review from a team as a code owner November 18, 2020 16:33
dangerfile.js Outdated

const lintPath = path.join(__dirname, 'lint-results.json')
const readFileP = path => new Promise((ok, fail) => fs.readFile(path, (err, file) => err ? fail(err) : ok(file)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node поддерживает нативные, можно импортить fs/promises либо через fs.promises.<метод>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

о, кайф

@VKCOM VKCOM deleted a comment from github-actions bot Nov 25, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2020

Messages
📖 Code coverage: 236 / 3223 lines (7.32%), 240 / 3290 statements (7.29%), 50 / 760 functions (6.58%), 124 / 2425 branches (5.11%)

Generated by 🚫 dangerJS against 64a2e7f

ArthurStam
ArthurStam previously approved these changes Dec 14, 2020
@ArthurStam ArthurStam merged commit 067f40e into v4 Dec 14, 2020
@thoughtspile thoughtspile deleted the test branch December 22, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants