Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maturin, PyO3, pyo3-asyncio, pyo3-logをアップデート #664
Maturin, PyO3, pyo3-asyncio, pyo3-logをアップデート #664
Changes from 17 commits
61730d8
3a5de57
818e5f7
724e1c6
eca2c1b
9f82d86
e133286
a6f6683
b7e9e10
ebe2112
f37e4bd
1c706cc
fa8bae5
16fd981
267057f
6277822
170676c
197219e
a46864d
93a7cfd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poetry環境でcargo buildする、なるほどです!!
ちなみに
|| true
は失敗することがある感じでしょうか? 👀There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
失敗の例としては、これですね。
#664 (comment)
open_jtal-sysのビルド(= Maturinの外で
cargo build
する目的)はできますがdylibのリンクには失敗します。そしてdylibのリンクまでは不要です (何故ならそっちはそもそもMaturinがやるべきなので)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
へーーーなるほどです。
リンクに失敗するのも不思議感ありました。とりあえずビルドは進みきりそうなので。
ちなみに将来問題が起きたときのためにお聞きしておきたいのですが、maturinがopen_jtalk-sysのビルドに失敗する(open_jtalkのdylibのリンクに失敗する)のは、何が原因っぽい感じなんでしょう 👀
理由はわからないけどmaturinがmacos-12でビルド後のリンク処理に失敗する、みたいな・・・?
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.