Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remap of ['j', 'j'] to ['<Esc>'] deletes character if insertion is repeated with dot '.' #4814

Closed
lalexf opened this issue May 7, 2020 · 0 comments · Fixed by #4829
Closed

Remap of ['j', 'j'] to ['<Esc>'] deletes character if insertion is repeated with dot '.' #4814

lalexf opened this issue May 7, 2020 · 0 comments · Fixed by #4829
Labels
area/remap kind/bug

Comments

@lalexf
Copy link

lalexf commented May 7, 2020 •
edited
Loading

Describe the bug
If you remaped jj to esc in insert mode, repeating the last insertion with dot command delete the character behinde the insertion.

To Reproduce
Steps to reproduce the behavior:

  1. map jj to esc in insert mode:
    "vim.insertModeKeyBindings": [
        {
            "before": [
                "j", "j"
            ],
            "after": [
                "<Esc>"
            ]
        },
    ]

bug

Expected behavior
Pressing dot '.' results in functionName(foo).

Environment:

  • Extension Version: 1.14.1
  • OS Version: Windows_NT x64 10.0.18363
  • VSCode version: 1.44.2
@lalexf lalexf changed the title Remap of ['j', 'j'] to ['<Esc>'] deletes character if insert is repeated with dot '.' Remap of ['j', 'j'] to ['<Esc>'] deletes character if insertion is repeated with dot '.' May 7, 2020
@J-Fields J-Fields self-assigned this May 8, 2020
@berknam berknam mentioned this issue May 11, 2020
Closed
berknam added a commit to berknam/Vim that referenced this issue May 11, 2020
@berknam
Fix bugs with a remapped <Esc> in insert mode
e8e25fb 
- Fix DotCommand deleting extra character when used after a remapped <Esc> in insert mode
Fixes VSCodeVim#4817 and VSCodeVim#4814

- Fix remapped <Esc> leaving trailing character when used with multiple cursors
Fixes VSCodeVim#4811
@berknam berknam mentioned this issue May 11, 2020
Merged
berknam added a commit to berknam/Vim that referenced this issue May 11, 2020
@berknam
Fix bugs with a remapped <Esc> in insert mode
d63711c 
- Fix DotCommand deleting extra character when used after a remapped <Esc> in insert mode
fixes VSCodeVim#4817
fixes VSCodeVim#4814

- Fix remapped <Esc> leaving trailing character when used with multiple cursors
fixes VSCodeVim#4811
@J-Fields J-Fields removed their assignment May 11, 2020
@J-Fields J-Fields mentioned this issue May 11, 2020
Closed
J-Fields added a commit that referenced this issue May 12, 2020
@berknam @J-Fields
Fix bugs with a remapped <Esc> in insert mode (#4829)
67cde57 
- Fix DotCommand deleting extra character when used after a remapped <Esc> in insert mode
Fixes #4817
Fixes #4814

- Fix remapped <Esc> leaving trailing character when used with multiple cursors
Fixes #4811

Co-authored-by: Jason Fields <jasonfields4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/remap kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bugs with a remapped <Esc> in insert mode berknam/Vim
2 participants
@lalexf @J-Fields