Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeating c-i-w with dot causes it to make an extra character disappear #4817

Closed
rightaway opened this issue May 8, 2020 · 2 comments · Fixed by #4829
Closed

Repeating c-i-w with dot causes it to make an extra character disappear #4817

rightaway opened this issue May 8, 2020 · 2 comments · Fixed by #4829

Comments

@rightaway
Copy link

Type c-i-w over a word to replace it and type the new text. Now go to another word and type .. It should replace just that word with the previous replacement text, but it replaces that word plus one extra character at the end. The bug isn't there in 1.13.1 but is there in 1.14.1.

@J-Fields
Copy link
Member

J-Fields commented May 8, 2020

Hmm, not able to reproduce. Can you give a specific scenario in which you can repro? And maybe post your settings, in case those are the culprit?

@rightaway
Copy link
Author

The reason looks like using jj to exit insert mode. I see the error if I type c-i-w to change a word, then enter the new word, type jj to enter escape mode and go over another word and type ..

But if I do the exact same but use Esc instead of jj, then it works fine. It was working fine in all cases a few releases ago. Not sure when the problem started but I think it actually wasn't working in 1.13.1 either unlike what I said.

  "vim.insertModeKeyBindings": [
    {
      "before": [
        "j",
        "j"
      ],
      "after": [
        "<Esc>"
      ],
    },
  ],

berknam added a commit to berknam/Vim that referenced this issue May 11, 2020
- Fix DotCommand deleting extra character when used after a remapped <Esc> in insert mode
Fixes VSCodeVim#4817 and VSCodeVim#4814

- Fix remapped <Esc> leaving trailing character when used with multiple cursors
Fixes VSCodeVim#4811
berknam added a commit to berknam/Vim that referenced this issue May 11, 2020
- Fix DotCommand deleting extra character when used after a remapped <Esc> in insert mode
fixes VSCodeVim#4817
fixes VSCodeVim#4814

- Fix remapped <Esc> leaving trailing character when used with multiple cursors
fixes VSCodeVim#4811
J-Fields added a commit that referenced this issue May 12, 2020
- Fix DotCommand deleting extra character when used after a remapped <Esc> in insert mode
Fixes #4817
Fixes #4814

- Fix remapped <Esc> leaving trailing character when used with multiple cursors
Fixes #4811

Co-authored-by: Jason Fields <jasonfields4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants