Fix bugs with a remapped <Esc> in insert mode #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix DotCommand deleting extra character when used after a remapped <Esc> in insert mode fixes VSCodeVim#4817 fixes VSCodeVim#4814 - Fix remapped <Esc> leaving trailing character when used with multiple cursors fixes VSCodeVim#4811
berknam
force-pushed
the
fixDotCommandRemovingChar
branch
from
e8e25fb
to
d63711c
Compare
|
There is a bug in this PR still, I just saw it now. I'll try to fix it and make a test for it. |
|
I think this is fixed now. I've also added some tests for both situations. |
This limits the number of blocking calls to one
|
Thanks! I made a slight edit to remove the characters all at once; I'll merge pending the tests passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix DotCommand deleting extra character when used after a remapped <Esc> in insert mode
Fixes Repeating c-i-w with dot causes it to make an extra character disappear #4817 and fixes Remap of ['j', 'j'] to ['<Esc>'] deletes character if insertion is repeated with dot '.' #4814
Fix remapped <Esc> leaving trailing character when used with multiple cursors
Fixes Remap of ['j', 'k'] to ['<Esc>'] in visual block mode leaves a trailing 'j' #4811